Re: [Qemu-devel] [PATCH] add CephFS support in VirtFS

[Jevon Qiao <scaleqiao@gmail.com>]

On 17/2/16 17:37, Daniel P. Berrange wrote:
> On Wed, Feb 17, 2016 at 03:32:06PM +0800, Jevon Qiao wrote:
>> Hi Daniel,
>>
>> Thank you for reviewing my code, please see my reply in-line.
>> On 15/2/16 17:17, Daniel P. Berrange wrote:
>>> On Sun, Feb 14, 2016 at 01:06:40PM +0800, Jevon Qiao wrote:
>>>> +
>>>> +static int cephfs_parse_opts(QemuOpts *opts, struct FsDriverEntry *fse)
>>>> +{
>>>> +    const char *sec_model = qemu_opt_get(opts, "security_model");
>>>> +    const char *path = qemu_opt_get(opts, "path");
>>>> +
>>>> +    if (!sec_model) {
>>>> +        fprintf(stderr, "Invalid argument security_model specified with "
>>>> +        "cephfs fsdriver\n");
>>> Bad indent.
>> BTW, is there any tool I can use to check the coding style in Qemu?
> As already mentioned there is 'scripts/checkpatch.pl'. If you are just
> wanting to check a single patch before sending it you can run it
> manually eg
>
>     git show | ./scripts/checkpatch.pl -
>
> If you have a branch holding a whole series of patches to submit, then
> it is easier to automate it. eg
>
>   git rebase -i master -x 'git show | ./scripts/checkpatch.pl -'
Thank you for the detailed answers.
> NB, the script doesn't catch all style problems, but it does a pretty
> good job. So even if the script passes, don't be suprised if reviewers
> point out further style issues.
Good to know:-) .

Thanks,
Jevon
> Regards,
> Daniel