From: scan-admin@coverity.com
To: ceph-devel@vger.kernel.org
Subject: New Defects reported by Coverity Scan for ceph
Date: Sat, 27 Feb 2016 10:07:16 -0800 [thread overview]
Message-ID: <56d1e5d48e29d_6f0aabd330944fd@ss1435.mail> (raw)
Hi,
Please find the latest report on new defect(s) introduced to ceph found with Coverity Scan.
52 new defect(s) introduced to ceph found with Coverity Scan.
39 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 20 of 52 defect(s)
** CID 716871: Error handling issues (CHECKED_RETURN)
/test/multi_stress_watch.cc: 157 in main()
________________________________________________________________________________________________________
*** CID 716871: Error handling issues (CHECKED_RETURN)
/test/multi_stress_watch.cc: 157 in main()
151 }
152 ret = cluster.conf_parse_env(NULL);
153 if (ret) {
154 std::cerr << "Error " << ret << " in cluster.conf_read_env" << std::endl;
155 return ret;
156 }
>>> CID 716871: Error handling issues (CHECKED_RETURN)
>>> Calling "connect" without checking return value (as is done elsewhere 20 out of 25 times).
157 cluster.connect();
158
159 if (type == "rep")
160 test_replicated(cluster, pool_name, obj_name);
161 else if (type == "ec")
162 test_erasure(cluster, pool_name, obj_name);
163
164 sem_destroy(&sem);
165 return 0;
** CID 1219460: Error handling issues (CHECKED_RETURN)
/tools/cephfs/JournalTool.cc: 112 in JournalTool::main(std::vector<const char *, std::allocator<const char *>> &)()
________________________________________________________________________________________________________
*** CID 1219460: Error handling issues (CHECKED_RETURN)
/tools/cephfs/JournalTool.cc: 112 in JournalTool::main(std::vector<const char *, std::allocator<const char *>> &)()
106 if (r < 0) {
107 derr << "RADOS unavailable, cannot scan filesystem journal" << dendl;
108 return r;
109 }
110
111 dout(4) << "JournalTool: connecting to RADOS..." << dendl;
>>> CID 1219460: Error handling issues (CHECKED_RETURN)
>>> Calling "connect" without checking return value (as is done elsewhere 20 out of 25 times).
112 rados.connect();
113
114 int const pool_id = mdsmap->get_metadata_pool();
115 dout(4) << "JournalTool: resolving pool " << pool_id << dendl;
116 std::string pool_name;
117 r = rados.pool_reverse_lookup(pool_id, &pool_name);
** CID 1354430: Error handling issues (CHECKED_RETURN)
/tools/cephfs/TableTool.cc: 318 in TableTool::main(std::vector<const char *, std::allocator<const char *>> &)()
________________________________________________________________________________________________________
*** CID 1354430: Error handling issues (CHECKED_RETURN)
/tools/cephfs/TableTool.cc: 318 in TableTool::main(std::vector<const char *, std::allocator<const char *>> &)()
312 if (r < 0) {
313 derr << "RADOS unavailable, cannot scan filesystem journal" << dendl;
314 return r;
315 }
316
317 dout(4) << "connecting to RADOS..." << dendl;
>>> CID 1354430: Error handling issues (CHECKED_RETURN)
>>> Calling "connect" without checking return value (as is done elsewhere 20 out of 25 times).
318 rados.connect();
319
320 int const pool_id = mdsmap->get_metadata_pool();
321 dout(4) << "resolving pool " << pool_id << dendl;
322 std::string pool_name;
323 r = rados.pool_reverse_lookup(pool_id, &pool_name);
** CID 1354431: Error handling issues (CHECKED_RETURN)
/test/rbd_mirror/test_PoolWatcher.cc: 157 in TestPoolWatcher::clone_image(const std::basic_string<char, std::char_traits<char>, std::allocator<char>>&, const std::basic_string<char, std::char_traits<char>, std::allocator<char>>&, const std::basic_string<char, std::char_traits<char>, std::allocator<char>>&, bool, std::basic_string<char, std::char_traits<char>, std::allocator<char>>*)()
________________________________________________________________________________________________________
*** CID 1354431: Error handling issues (CHECKED_RETURN)
/test/rbd_mirror/test_PoolWatcher.cc: 157 in TestPoolWatcher::clone_image(const std::basic_string<char, std::char_traits<char>, std::allocator<char>>&, const std::basic_string<char, std::char_traits<char>, std::allocator<char>>&, const std::basic_string<char, std::char_traits<char>, std::allocator<char>>&, bool, std::basic_string<char, std::char_traits<char>, std::allocator<char>>*)()
151 ASSERT_EQ(0, m_cluster->ioctx_create(clone_pool_name.c_str(), cioctx));
152
153 string snap_name = "snap" + stringify(++m_snap_number);
154 {
155 librbd::ImageCtx *ictx = new librbd::ImageCtx(parent_image_name.c_str(),
156 "", "", pioctx, false);
>>> CID 1354431: Error handling issues (CHECKED_RETURN)
>>> Calling "open" without checking return value (as is done elsewhere 8 out of 9 times).
157 ictx->state->open();
158 EXPECT_EQ(0, ictx->operations->snap_create(snap_name.c_str()));
159 EXPECT_EQ(0, ictx->operations->snap_protect(snap_name.c_str()));
160 ictx->state->close();
161 }
162
** CID 1354432: Error handling issues (CHECKED_RETURN)
/tools/rados/RadosImport.cc: 45 in RadosImport::import(std::basic_string<char, std::char_traits<char>, std::allocator<char>>, bool)()
________________________________________________________________________________________________________
*** CID 1354432: Error handling issues (CHECKED_RETURN)
/tools/rados/RadosImport.cc: 45 in RadosImport::import(std::basic_string<char, std::char_traits<char>, std::allocator<char>>, bool)()
39 }
40 ret = cluster.conf_parse_env(NULL);
41 if (ret) {
42 cerr << "Error " << ret << " in cluster.conf_read_env" << std::endl;
43 return ret;
44 }
>>> CID 1354432: Error handling issues (CHECKED_RETURN)
>>> Calling "connect" without checking return value (as is done elsewhere 20 out of 25 times).
45 cluster.connect();
46
47 ret = cluster.ioctx_create(pool.c_str(), ioctx);
48 if (ret < 0) {
49 cerr << "ioctx_create " << pool << " failed with " << ret << std::endl;
50 return ret;
** CID 1354433: Security best practices violations (DC.WEAK_CRYPTO)
/osd/PGBackend.cc: 671 in PGBackend::be_compare_scrubmaps(const std::map<pg_shard_t, ScrubMap *, std::less<pg_shard_t>, std::allocator<std::pair<const pg_shard_t, ScrubMap *>>> &, bool, bool, std::map<hobject_t, std::set<pg_shard_t, std::less<pg_shard_t>, std::allocator<pg_shard_t>>, hobject_t::BitwiseComparator, std::allocator<std::pair<const hobject_t, std::set<pg_shard_t, std::less<pg_shard_t>, std::allocator<pg_shard_t>>>>>&, std::map<hobject_t, std::set<pg_shard_t, std::less<pg_shard_t>, std::allocator<pg_shard_t>>, hobject_t::BitwiseComparator, std::allocator<std::pair<const hobject_t, std::set<pg_shard_t, std::less<pg_shard_t>, std::allocator<pg_shard_t>>>>>&, std::map<hobject_t, std::list<pg_shard_t, std::allocator<pg_shard_t>>, hobject_t::BitwiseComparator, std::allocator<std::pai
r<const hobject_t, std::list<pg_shard_t, std::allocator<pg_shard_t>>>>>&, std::map<hobject_t, std::pair<unsigned int, unsigned int>, hobject_t::BitwiseComparator, std::allocator<std::pair<const hobj
ect_t, std::pair<unsigned int, unsigned int>>>>&, int &, int &, Scrub::Store *, const spg_t &, const std::vector<int, std::allocator<int>> &, std::basic_ostream<char, std::char_traits<char>>&)()
________________________________________________________________________________________________________
*** CID 1354433: Security best practices violations (DC.WEAK_CRYPTO)
/osd/PGBackend.cc: 671 in PGBackend::be_compare_scrubmaps(const std::map<pg_shard_t, ScrubMap *, std::less<pg_shard_t>, std::allocator<std::pair<const pg_shard_t, ScrubMap *>>> &, bool, bool, std::map<hobject_t, std::set<pg_shard_t, std::less<pg_shard_t>, std::allocator<pg_shard_t>>, hobject_t::BitwiseComparator, std::allocator<std::pair<const hobject_t, std::set<pg_shard_t, std::less<pg_shard_t>, std::allocator<pg_shard_t>>>>>&, std::map<hobject_t, std::set<pg_shard_t, std::less<pg_shard_t>, std::allocator<pg_shard_t>>, hobject_t::BitwiseComparator, std::allocator<std::pair<const hobject_t, std::set<pg_shard_t, std::less<pg_shard_t>, std::allocator<pg_shard_t>>>>>&, std::map<hobject_t, std::list<pg_shard_t, std::allocator<pg_shard_t>>, hobject_t::BitwiseComparator, std::allocator<std::pai
r<const hobject_t, std::list<pg_shard_t, std::allocator<pg_shard_t>>>>>&, std::map<hobject_t, std::pair<unsigned int, unsigned int>, hobject_t::BitwiseComparator, std::allocator<std::pair<const hobj
ect_t, std::pair<unsigned int, unsigned int>>>>&, int &, int &, Scrub::Store *, const spg_t &, const std::vector<int, std::allocator<int>> &, std::basic_ostream<char, std::char_traits<char>>&)()
665 (!auth_oi.is_data_digest() || !auth_oi.is_omap_digest())) {
666 dout(20) << __func__ << " missing digest on " << *k << dendl;
667 update = MAYBE;
668 }
669 if (auth_object.digest_present && auth_object.omap_digest_present &&
670 g_conf->osd_debug_scrub_chance_rewrite_digest &&
>>> CID 1354433: Security best practices violations (DC.WEAK_CRYPTO)
>>> "rand" should not be used for security related applications, as linear congruential algorithms are too easy to break.
671 (((unsigned)rand() % 100) >
672 g_conf->osd_debug_scrub_chance_rewrite_digest)) {
673 dout(20) << __func__ << " randomly updating digest on " << *k << dendl;
674 update = MAYBE;
675 }
676
** CID 1354434: Security best practices violations (DC.WEAK_CRYPTO)
/msg/async/AsyncConnection.cc: 354 in AsyncConnection::_try_send(bool, bool)()
________________________________________________________________________________________________________
*** CID 1354434: Security best practices violations (DC.WEAK_CRYPTO)
/msg/async/AsyncConnection.cc: 354 in AsyncConnection::_try_send(bool, bool)()
348 ssize_t AsyncConnection::_try_send(bool send, bool more)
349 {
350 if (!send)
351 return 0;
352
353 if (async_msgr->cct->_conf->ms_inject_socket_failures && sd >= 0) {
>>> CID 1354434: Security best practices violations (DC.WEAK_CRYPTO)
>>> "rand" should not be used for security related applications, as linear congruential algorithms are too easy to break.
354 if (rand() % async_msgr->cct->_conf->ms_inject_socket_failures == 0) {
355 ldout(async_msgr->cct, 0) << __func__ << " injecting socket failure" << dendl;
356 ::shutdown(sd, SHUT_RDWR);
357 }
358 }
359
** CID 1354435: (DC.WEAK_CRYPTO)
/common/WeightedPriorityQueue.h: 175 in WeightedPriorityQueue<std::pair<boost::intrusive_ptr<PG>, PGQueueable>, entity_inst_t>::Queue::pop(bool)()
/common/WeightedPriorityQueue.h: 190 in WeightedPriorityQueue<std::pair<boost::intrusive_ptr<PG>, PGQueueable>, entity_inst_t>::Queue::pop(bool)()
________________________________________________________________________________________________________
*** CID 1354435: (DC.WEAK_CRYPTO)
/common/WeightedPriorityQueue.h: 175 in WeightedPriorityQueue<std::pair<boost::intrusive_ptr<PG>, PGQueueable>, entity_inst_t>::Queue::pop(bool)()
169 }
170 return ret;
171 }
172 if (queues.size() > 1) {
173 while (true) {
174 // Pick a new priority out of the total priority.
>>> CID 1354435: (DC.WEAK_CRYPTO)
>>> "rand" should not be used for security related applications, as linear congruential algorithms are too easy to break.
175 unsigned prio = rand() % total_prio + 1;
176 unsigned tp = total_prio - i->key;
177 // Find the priority coresponding to the picked number.
178 // Subtract high priorities to low priorities until the picked number
179 // is more than the total and try to dequeue that priority.
180 // Reverse the direction from previous implementation because there is a higher
/common/WeightedPriorityQueue.h: 190 in WeightedPriorityQueue<std::pair<boost::intrusive_ptr<PG>, PGQueueable>, entity_inst_t>::Queue::pop(bool)()
184 tp -= i->key;
185 }
186 // Flip a coin to see if this priority gets to run based on cost.
187 // The next op's cost is multiplied by .9 and subtracted from the
188 // max cost seen. Ops with lower costs will have a larger value
189 // and allow them to be selected easier than ops with high costs.
>>> CID 1354435: (DC.WEAK_CRYPTO)
>>> "rand" should not be used for security related applications, as linear congruential algorithms are too easy to break.
190 if (max_cost == 0 || rand() % max_cost <=
191 (max_cost - ((i->get_cost() * 9) / 10))) {
192 break;
193 }
194 i = --queues.end();
195 }
** CID 1354436: Compiler dependency (DELETE_ARRAY)
/log/Log.cc: 318 in ceph::log::Log::_flush(ceph::log::EntryQueue *, ceph::log::EntryQueue *, bool)()
________________________________________________________________________________________________________
*** CID 1354436: Compiler dependency (DELETE_ARRAY)
/log/Log.cc: 318 in ceph::log::Log::_flush(ceph::log::EntryQueue *, ceph::log::EntryQueue *, bool)()
312 buf[buflen] = '\n';
313 int r = safe_write(m_fd, buf, buflen+1);
314 if (r < 0)
315 cerr << "problem writing to " << m_log_file << ": " << cpp_strerror(r) << std::endl;
316 }
317 if(need_dynamic)
>>> CID 1354436: Compiler dependency (DELETE_ARRAY)
>>> Deleting array variable "buf" with non-array delete in "delete buf".
318 delete buf;
319 }
320 if (do_graylog2 && m_graylog) {
321 m_graylog->log_entry(e);
322 }
323
** CID 1354437: Control flow issues (MISSING_BREAK)
/build/rados.c: 13185 in __pyx_pw_5rados_5Rados_51mon_command()
________________________________________________________________________________________________________
*** CID 1354437: Control flow issues (MISSING_BREAK)
/build/rados.c: 13185 in __pyx_pw_5rados_5Rados_51mon_command()
13179 }
13180 kw_args = PyDict_Size(__pyx_kwds);
13181 switch (pos_args) {
13182 case 0:
13183 if (likely((values[0] = PyDict_GetItem(__pyx_kwds, __pyx_n_s_cmd)) != 0)) kw_args--;
13184 else goto __pyx_L5_argtuple_error;
>>> CID 1354437: Control flow issues (MISSING_BREAK)
>>> The above case falls through to this one.
13185 case 1:
13186 if (likely((values[1] = PyDict_GetItem(__pyx_kwds, __pyx_n_s_inbuf)) != 0)) kw_args--;
13187 else {
13188 __Pyx_RaiseArgtupleInvalid("mon_command", 0, 2, 4, 1); {__pyx_filename = __pyx_f[0]; __pyx_lineno = 1110; __pyx_clineno = __LINE__; goto __pyx_L3_error;}
13189 }
13190 case 2:
** CID 1354438: Control flow issues (MISSING_BREAK)
/build/rados.c: 13190 in __pyx_pw_5rados_5Rados_51mon_command()
________________________________________________________________________________________________________
*** CID 1354438: Control flow issues (MISSING_BREAK)
/build/rados.c: 13190 in __pyx_pw_5rados_5Rados_51mon_command()
13184 else goto __pyx_L5_argtuple_error;
13185 case 1:
13186 if (likely((values[1] = PyDict_GetItem(__pyx_kwds, __pyx_n_s_inbuf)) != 0)) kw_args--;
13187 else {
13188 __Pyx_RaiseArgtupleInvalid("mon_command", 0, 2, 4, 1); {__pyx_filename = __pyx_f[0]; __pyx_lineno = 1110; __pyx_clineno = __LINE__; goto __pyx_L3_error;}
13189 }
>>> CID 1354438: Control flow issues (MISSING_BREAK)
>>> The above case falls through to this one.
13190 case 2:
13191 if (kw_args > 0) {
13192 PyObject* value = PyDict_GetItem(__pyx_kwds, __pyx_n_s_timeout);
13193 if (value) { values[2] = value; kw_args--; }
13194 }
13195 case 3:
** CID 1354439: Control flow issues (MISSING_BREAK)
/build/rados.c: 13195 in __pyx_pw_5rados_5Rados_51mon_command()
________________________________________________________________________________________________________
*** CID 1354439: Control flow issues (MISSING_BREAK)
/build/rados.c: 13195 in __pyx_pw_5rados_5Rados_51mon_command()
13189 }
13190 case 2:
13191 if (kw_args > 0) {
13192 PyObject* value = PyDict_GetItem(__pyx_kwds, __pyx_n_s_timeout);
13193 if (value) { values[2] = value; kw_args--; }
13194 }
>>> CID 1354439: Control flow issues (MISSING_BREAK)
>>> The above case falls through to this one.
13195 case 3:
13196 if (kw_args > 0) {
13197 PyObject* value = PyDict_GetItem(__pyx_kwds, __pyx_n_s_target);
13198 if (value) { values[3] = value; kw_args--; }
13199 }
13200 }
** CID 1354440: Control flow issues (MISSING_BREAK)
/build/rados.c: 13828 in __pyx_pw_5rados_5Rados_53osd_command()
________________________________________________________________________________________________________
*** CID 1354440: Control flow issues (MISSING_BREAK)
/build/rados.c: 13828 in __pyx_pw_5rados_5Rados_53osd_command()
13822 }
13823 kw_args = PyDict_Size(__pyx_kwds);
13824 switch (pos_args) {
13825 case 0:
13826 if (likely((values[0] = PyDict_GetItem(__pyx_kwds, __pyx_n_s_osdid)) != 0)) kw_args--;
13827 else goto __pyx_L5_argtuple_error;
>>> CID 1354440: Control flow issues (MISSING_BREAK)
>>> The above case falls through to this one.
13828 case 1:
13829 if (likely((values[1] = PyDict_GetItem(__pyx_kwds, __pyx_n_s_cmd)) != 0)) kw_args--;
13830 else {
13831 __Pyx_RaiseArgtupleInvalid("osd_command", 0, 3, 4, 1); {__pyx_filename = __pyx_f[0]; __pyx_lineno = 1167; __pyx_clineno = __LINE__; goto __pyx_L3_error;}
13832 }
13833 case 2:
** CID 1354441: Control flow issues (MISSING_BREAK)
/build/rados.c: 13833 in __pyx_pw_5rados_5Rados_53osd_command()
________________________________________________________________________________________________________
*** CID 1354441: Control flow issues (MISSING_BREAK)
/build/rados.c: 13833 in __pyx_pw_5rados_5Rados_53osd_command()
13827 else goto __pyx_L5_argtuple_error;
13828 case 1:
13829 if (likely((values[1] = PyDict_GetItem(__pyx_kwds, __pyx_n_s_cmd)) != 0)) kw_args--;
13830 else {
13831 __Pyx_RaiseArgtupleInvalid("osd_command", 0, 3, 4, 1); {__pyx_filename = __pyx_f[0]; __pyx_lineno = 1167; __pyx_clineno = __LINE__; goto __pyx_L3_error;}
13832 }
>>> CID 1354441: Control flow issues (MISSING_BREAK)
>>> The above case falls through to this one.
13833 case 2:
13834 if (likely((values[2] = PyDict_GetItem(__pyx_kwds, __pyx_n_s_inbuf)) != 0)) kw_args--;
13835 else {
13836 __Pyx_RaiseArgtupleInvalid("osd_command", 0, 3, 4, 2); {__pyx_filename = __pyx_f[0]; __pyx_lineno = 1167; __pyx_clineno = __LINE__; goto __pyx_L3_error;}
13837 }
13838 case 3:
** CID 1354442: Control flow issues (MISSING_BREAK)
/build/rados.c: 13838 in __pyx_pw_5rados_5Rados_53osd_command()
________________________________________________________________________________________________________
*** CID 1354442: Control flow issues (MISSING_BREAK)
/build/rados.c: 13838 in __pyx_pw_5rados_5Rados_53osd_command()
13832 }
13833 case 2:
13834 if (likely((values[2] = PyDict_GetItem(__pyx_kwds, __pyx_n_s_inbuf)) != 0)) kw_args--;
13835 else {
13836 __Pyx_RaiseArgtupleInvalid("osd_command", 0, 3, 4, 2); {__pyx_filename = __pyx_f[0]; __pyx_lineno = 1167; __pyx_clineno = __LINE__; goto __pyx_L3_error;}
13837 }
>>> CID 1354442: Control flow issues (MISSING_BREAK)
>>> The above case falls through to this one.
13838 case 3:
13839 if (kw_args > 0) {
13840 PyObject* value = PyDict_GetItem(__pyx_kwds, __pyx_n_s_timeout);
13841 if (value) { values[3] = value; kw_args--; }
13842 }
13843 }
** CID 1354443: Control flow issues (MISSING_BREAK)
/build/rados.c: 14351 in __pyx_pw_5rados_5Rados_55pg_command()
________________________________________________________________________________________________________
*** CID 1354443: Control flow issues (MISSING_BREAK)
/build/rados.c: 14351 in __pyx_pw_5rados_5Rados_55pg_command()
14345 }
14346 kw_args = PyDict_Size(__pyx_kwds);
14347 switch (pos_args) {
14348 case 0:
14349 if (likely((values[0] = PyDict_GetItem(__pyx_kwds, __pyx_n_s_pgid)) != 0)) kw_args--;
14350 else goto __pyx_L5_argtuple_error;
>>> CID 1354443: Control flow issues (MISSING_BREAK)
>>> The above case falls through to this one.
14351 case 1:
14352 if (likely((values[1] = PyDict_GetItem(__pyx_kwds, __pyx_n_s_cmd)) != 0)) kw_args--;
14353 else {
14354 __Pyx_RaiseArgtupleInvalid("pg_command", 0, 3, 4, 1); {__pyx_filename = __pyx_f[0]; __pyx_lineno = 1210; __pyx_clineno = __LINE__; goto __pyx_L3_error;}
14355 }
14356 case 2:
** CID 1354444: Control flow issues (MISSING_BREAK)
/build/rados.c: 14356 in __pyx_pw_5rados_5Rados_55pg_command()
________________________________________________________________________________________________________
*** CID 1354444: Control flow issues (MISSING_BREAK)
/build/rados.c: 14356 in __pyx_pw_5rados_5Rados_55pg_command()
14350 else goto __pyx_L5_argtuple_error;
14351 case 1:
14352 if (likely((values[1] = PyDict_GetItem(__pyx_kwds, __pyx_n_s_cmd)) != 0)) kw_args--;
14353 else {
14354 __Pyx_RaiseArgtupleInvalid("pg_command", 0, 3, 4, 1); {__pyx_filename = __pyx_f[0]; __pyx_lineno = 1210; __pyx_clineno = __LINE__; goto __pyx_L3_error;}
14355 }
>>> CID 1354444: Control flow issues (MISSING_BREAK)
>>> The above case falls through to this one.
14356 case 2:
14357 if (likely((values[2] = PyDict_GetItem(__pyx_kwds, __pyx_n_s_inbuf)) != 0)) kw_args--;
14358 else {
14359 __Pyx_RaiseArgtupleInvalid("pg_command", 0, 3, 4, 2); {__pyx_filename = __pyx_f[0]; __pyx_lineno = 1210; __pyx_clineno = __LINE__; goto __pyx_L3_error;}
14360 }
14361 case 3:
** CID 1354445: Control flow issues (MISSING_BREAK)
/build/rados.c: 14361 in __pyx_pw_5rados_5Rados_55pg_command()
________________________________________________________________________________________________________
*** CID 1354445: Control flow issues (MISSING_BREAK)
/build/rados.c: 14361 in __pyx_pw_5rados_5Rados_55pg_command()
14355 }
14356 case 2:
14357 if (likely((values[2] = PyDict_GetItem(__pyx_kwds, __pyx_n_s_inbuf)) != 0)) kw_args--;
14358 else {
14359 __Pyx_RaiseArgtupleInvalid("pg_command", 0, 3, 4, 2); {__pyx_filename = __pyx_f[0]; __pyx_lineno = 1210; __pyx_clineno = __LINE__; goto __pyx_L3_error;}
14360 }
>>> CID 1354445: Control flow issues (MISSING_BREAK)
>>> The above case falls through to this one.
14361 case 3:
14362 if (kw_args > 0) {
14363 PyObject* value = PyDict_GetItem(__pyx_kwds, __pyx_n_s_timeout);
14364 if (value) { values[3] = value; kw_args--; }
14365 }
14366 }
** CID 1354446: Control flow issues (MISSING_BREAK)
/build/rados.c: 15034 in __pyx_pw_5rados_5Rados_59blacklist_add()
________________________________________________________________________________________________________
*** CID 1354446: Control flow issues (MISSING_BREAK)
/build/rados.c: 15034 in __pyx_pw_5rados_5Rados_59blacklist_add()
15028 }
15029 kw_args = PyDict_Size(__pyx_kwds);
15030 switch (pos_args) {
15031 case 0:
15032 if (likely((values[0] = PyDict_GetItem(__pyx_kwds, __pyx_n_s_client_address)) != 0)) kw_args--;
15033 else goto __pyx_L5_argtuple_error;
>>> CID 1354446: Control flow issues (MISSING_BREAK)
>>> The above case falls through to this one.
15034 case 1:
15035 if (kw_args > 0) {
15036 PyObject* value = PyDict_GetItem(__pyx_kwds, __pyx_n_s_expire_seconds);
15037 if (value) { values[1] = value; kw_args--; }
15038 }
15039 }
** CID 1354447: Control flow issues (MISSING_BREAK)
/build/rados.c: 15298 in __pyx_pw_5rados_5Rados_61monitor_log()
________________________________________________________________________________________________________
*** CID 1354447: Control flow issues (MISSING_BREAK)
/build/rados.c: 15298 in __pyx_pw_5rados_5Rados_61monitor_log()
15292 }
15293 kw_args = PyDict_Size(__pyx_kwds);
15294 switch (pos_args) {
15295 case 0:
15296 if (likely((values[0] = PyDict_GetItem(__pyx_kwds, __pyx_n_s_level)) != 0)) kw_args--;
15297 else goto __pyx_L5_argtuple_error;
>>> CID 1354447: Control flow issues (MISSING_BREAK)
>>> The above case falls through to this one.
15298 case 1:
15299 if (likely((values[1] = PyDict_GetItem(__pyx_kwds, __pyx_n_s_callback)) != 0)) kw_args--;
15300 else {
15301 __Pyx_RaiseArgtupleInvalid("monitor_log", 1, 3, 3, 1); {__pyx_filename = __pyx_f[0]; __pyx_lineno = 1282; __pyx_clineno = __LINE__; goto __pyx_L3_error;}
15302 }
15303 case 2:
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/ceph?tab=overview
To manage Coverity Scan email notifications for "ceph-devel@vger.kernel.org", click https://scan.coverity.com/subscriptions/edit?email=ceph-devel%40vger.kernel.org&token=018084d671e3cc89d00dd2ccb7eb849c
next reply other threads:[~2016-02-27 18:07 UTC|newest]
Thread overview: 124+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-27 18:07 scan-admin [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-08-20 12:22 New Defects reported by Coverity Scan for ceph scan-admin
2022-08-20 13:17 ` Jeff Layton
2022-08-22 3:54 ` Brad Hubbard
2022-08-23 12:52 ` Jeff Layton
2018-01-04 3:32 scan-admin
2017-12-28 1:57 scan-admin
2017-12-21 1:54 scan-admin
2017-12-21 3:34 ` Jos Collin
2017-12-21 4:03 ` Brad Hubbard
2017-12-14 6:49 scan-admin
2017-12-01 2:25 scan-admin
2017-11-23 0:19 scan-admin
2017-11-16 11:35 scan-admin
2017-11-09 11:36 scan-admin
2017-11-02 2:11 scan-admin
2017-10-27 0:31 scan-admin
2017-10-19 3:54 scan-admin
2017-10-12 5:54 scan-admin
2017-10-05 5:08 scan-admin
2017-09-28 5:09 scan-admin
2017-09-21 6:44 scan-admin
2017-09-14 7:19 scan-admin
2017-09-07 5:08 scan-admin
2017-08-31 6:39 scan-admin
2017-08-24 23:32 scan-admin
2017-08-17 3:29 scan-admin
2017-08-10 3:50 scan-admin
2017-08-03 4:57 scan-admin
2017-07-27 3:50 scan-admin
2017-07-28 18:42 ` Gregory Farnum
2017-07-28 22:22 ` Brad Hubbard
2017-07-20 4:08 scan-admin
2017-07-13 5:11 scan-admin
2017-07-06 5:03 scan-admin
2017-06-29 4:08 scan-admin
2017-06-22 4:27 scan-admin
2017-06-15 9:50 scan-admin
2017-06-11 23:46 scan-admin
2017-06-01 4:33 scan-admin
2017-05-25 6:22 scan-admin
2017-05-18 1:44 scan-admin
2017-05-11 5:32 scan-admin
2017-05-04 2:45 scan-admin
2017-04-27 2:22 scan-admin
2017-04-20 5:34 scan-admin
2017-04-13 6:25 scan-admin
2017-04-06 9:40 scan-admin
2017-03-31 1:25 scan-admin
2017-03-23 7:58 scan-admin
2017-03-16 7:37 scan-admin
2017-03-09 6:12 scan-admin
2017-03-02 7:44 scan-admin
2017-02-23 9:09 scan-admin
2017-02-17 2:29 scan-admin
[not found] ` <CAJE9aOMoxWjhq=g+25hfhMhxSCnHAOwAyNhXvkxS1wwBEd3j+A@mail.gmail.com>
2017-02-17 5:19 ` kefu chai
2017-02-05 10:08 scan-admin
2017-01-27 13:22 scan-admin
2017-01-17 3:01 scan-admin
2017-01-09 10:05 scan-admin
2016-12-30 8:33 scan-admin
2016-12-23 9:16 scan-admin
2016-12-16 8:54 scan-admin
2016-12-09 11:29 scan-admin
2016-12-02 11:08 scan-admin
2016-11-25 7:55 scan-admin
2016-03-19 17:58 scan-admin
2016-03-13 17:40 scan-admin
2016-03-12 18:04 scan-admin
2016-03-05 17:55 scan-admin
2016-03-07 20:59 ` Gregory Farnum
2016-02-20 18:26 scan-admin
2016-02-18 20:32 scan-admin
2016-02-13 17:47 scan-admin
2016-02-11 17:57 scan-admin
2016-02-11 22:01 ` Gregory Farnum
2016-02-12 16:36 ` Adam C. Emerson
2016-02-04 20:39 scan-admin
2016-02-03 20:40 scan-admin
2015-05-02 14:37 scan-admin
2015-01-21 1:41 scan-admin
2015-01-16 14:39 scan-admin
2015-01-16 15:17 ` Gregory Farnum
2015-01-16 16:00 ` John Spray
2015-01-16 16:08 ` Sage Weil
[not found] <54b528bef1f63_1b74f3532c63410@scan.coverity.com.mail>
2015-01-13 14:34 ` Sage Weil
2015-01-13 14:16 scan-admin
2015-01-10 14:36 scan-admin
2015-01-10 15:48 ` Haomai Wang
2015-01-09 14:30 scan-admin
2015-01-09 15:26 ` Sage Weil
2015-01-09 15:32 ` Danny Al-Gaaf
2015-01-04 14:14 scan-admin
2014-12-27 14:13 scan-admin
2014-12-28 6:03 ` Sage Weil
2014-12-26 14:19 scan-admin
2014-12-23 14:37 scan-admin
2014-12-21 14:13 scan-admin
2014-12-18 14:19 scan-admin
2014-12-14 14:17 scan-admin
2014-12-07 20:36 scan-admin
2014-12-05 14:11 scan-admin
2014-12-02 14:09 scan-admin
2014-11-25 14:09 scan-admin
2014-11-23 14:08 scan-admin
2014-11-20 14:20 scan-admin
2014-11-14 14:21 scan-admin
2014-11-13 14:21 scan-admin
2014-11-11 20:40 scan-admin
2014-11-09 14:12 scan-admin
2014-10-30 13:19 scan-admin
2014-10-30 16:08 ` Sage Weil
2014-10-28 13:16 scan-admin
2014-10-28 18:26 ` Danny Al-Gaaf
2014-10-26 13:17 scan-admin
2014-10-24 17:55 scan-admin
2014-10-24 17:59 ` Sage Weil
2014-10-17 13:27 scan-admin
2014-10-09 13:23 scan-admin
2014-10-02 13:21 scan-admin
2014-09-25 13:18 scan-admin
2014-09-16 21:40 scan-admin
2014-08-16 21:31 scan-admin
2014-08-09 15:30 scan-admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56d1e5d48e29d_6f0aabd330944fd@ss1435.mail \
--to=scan-admin@coverity.com \
--cc=ceph-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox