From: scan-admin@coverity.com
To: ceph-devel@vger.kernel.org
Subject: New Defects reported by Coverity Scan for ceph
Date: Sun, 05 Feb 2017 02:08:17 -0800 [thread overview]
Message-ID: <5896f9918a123_3aabc3f3343035f@ss1435.mail> (raw)
Hi,
Please find the latest report on new defect(s) introduced to ceph found with Coverity Scan.
32 new defect(s) introduced to ceph found with Coverity Scan.
33 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 20 of 32 defect(s)
** CID 1400089: Security best practices violations (DC.WEAK_CRYPTO)
/home/brad/working/src/ceph/src/osd/OSD.cc: 8735 in OSD::handle_op(boost::intrusive_ptr<OpRequest> &, std::shared_ptr<const OSDMap> &)()
________________________________________________________________________________________________________
*** CID 1400089: Security best practices violations (DC.WEAK_CRYPTO)
/home/brad/working/src/ceph/src/osd/OSD.cc: 8735 in OSD::handle_op(boost::intrusive_ptr<OpRequest> &, std::shared_ptr<const OSDMap> &)()
8729 if (client_session) {
8730 client_session->put();
8731 }
8732
8733 if (cct->_conf->osd_debug_drop_op_probability > 0 &&
8734 !m->get_source().is_mds()) {
>>> CID 1400089: Security best practices violations (DC.WEAK_CRYPTO)
>>> "rand" should not be used for security related applications, as linear congruential algorithms are too easy to break.
8735 if ((double)rand() / (double)RAND_MAX < cct->_conf->osd_debug_drop_op_probability) {
8736 dout(0) << "handle_op DEBUG artificially dropping op " << *m << dendl;
8737 return;
8738 }
8739 }
8740
** CID 1400090: Control flow issues (DEADCODE)
/home/brad/working/src/ceph/src/mon/LogMonitor.cc: 378 in LogMonitor::preprocess_command(boost::intrusive_ptr<MonOpRequest>)()
________________________________________________________________________________________________________
*** CID 1400090: Control flow issues (DEADCODE)
/home/brad/working/src/ceph/src/mon/LogMonitor.cc: 378 in LogMonitor::preprocess_command(boost::intrusive_ptr<MonOpRequest>)()
372 op->mark_logmon_event("preprocess_command");
373 int r = -1;
374 bufferlist rdata;
375 stringstream ss;
376
377 if (r != -1) {
>>> CID 1400090: Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "rs.basic_string();".
378 string rs;
379 getline(ss, rs);
380 mon->reply_command(op, r, rs, rdata, get_last_committed());
381 return true;
382 } else
383 return false;
** CID 1400091: (INVALIDATE_ITERATOR)
/home/brad/working/src/ceph/src/osd/PrimaryLogPG.cc: 1157 in PrimaryLogPG::do_pg_op(boost::intrusive_ptr<OpRequest>)()
/home/brad/working/src/ceph/src/osd/PrimaryLogPG.cc: 1162 in PrimaryLogPG::do_pg_op(boost::intrusive_ptr<OpRequest>)()
/home/brad/working/src/ceph/src/osd/PrimaryLogPG.cc: 1156 in PrimaryLogPG::do_pg_op(boost::intrusive_ptr<OpRequest>)()
/home/brad/working/src/ceph/src/osd/PrimaryLogPG.cc: 1166 in PrimaryLogPG::do_pg_op(boost::intrusive_ptr<OpRequest>)()
/home/brad/working/src/ceph/src/osd/PrimaryLogPG.cc: 1344 in PrimaryLogPG::do_pg_op(boost::intrusive_ptr<OpRequest>)()
/home/brad/working/src/ceph/src/osd/PrimaryLogPG.cc: 1349 in PrimaryLogPG::do_pg_op(boost::intrusive_ptr<OpRequest>)()
/home/brad/working/src/ceph/src/osd/PrimaryLogPG.cc: 1343 in PrimaryLogPG::do_pg_op(boost::intrusive_ptr<OpRequest>)()
/home/brad/working/src/ceph/src/osd/PrimaryLogPG.cc: 1353 in PrimaryLogPG::do_pg_op(boost::intrusive_ptr<OpRequest>)()
________________________________________________________________________________________________________
*** CID 1400091: (INVALIDATE_ITERATOR)
/home/brad/working/src/ceph/src/osd/PrimaryLogPG.cc: 1157 in PrimaryLogPG::do_pg_op(boost::intrusive_ptr<OpRequest>)()
1151
1152 hobject_t candidate;
1153 if (mcand == lcand) {
1154 candidate = mcand;
1155 if (!mcand.is_max()) {
1156 ++ls_iter;
>>> CID 1400091: (INVALIDATE_ITERATOR)
>>> Incrementing iterator "missing_iter" though it is already past the end of its container.
1157 ++missing_iter;
1158 }
1159 } else if (cmp(mcand, lcand, get_sort_bitwise()) < 0) {
1160 candidate = mcand;
1161 assert(!mcand.is_max());
1162 ++missing_iter;
/home/brad/working/src/ceph/src/osd/PrimaryLogPG.cc: 1162 in PrimaryLogPG::do_pg_op(boost::intrusive_ptr<OpRequest>)()
1156 ++ls_iter;
1157 ++missing_iter;
1158 }
1159 } else if (cmp(mcand, lcand, get_sort_bitwise()) < 0) {
1160 candidate = mcand;
1161 assert(!mcand.is_max());
>>> CID 1400091: (INVALIDATE_ITERATOR)
>>> Incrementing iterator "missing_iter" though it is already past the end of its container.
1162 ++missing_iter;
1163 } else {
1164 candidate = lcand;
1165 assert(!lcand.is_max());
1166 ++ls_iter;
1167 }
/home/brad/working/src/ceph/src/osd/PrimaryLogPG.cc: 1156 in PrimaryLogPG::do_pg_op(boost::intrusive_ptr<OpRequest>)()
1150 *ls_iter;
1151
1152 hobject_t candidate;
1153 if (mcand == lcand) {
1154 candidate = mcand;
1155 if (!mcand.is_max()) {
>>> CID 1400091: (INVALIDATE_ITERATOR)
>>> Incrementing iterator "ls_iter" though it is already past the end of its container.
1156 ++ls_iter;
1157 ++missing_iter;
1158 }
1159 } else if (cmp(mcand, lcand, get_sort_bitwise()) < 0) {
1160 candidate = mcand;
1161 assert(!mcand.is_max());
/home/brad/working/src/ceph/src/osd/PrimaryLogPG.cc: 1166 in PrimaryLogPG::do_pg_op(boost::intrusive_ptr<OpRequest>)()
1160 candidate = mcand;
1161 assert(!mcand.is_max());
1162 ++missing_iter;
1163 } else {
1164 candidate = lcand;
1165 assert(!lcand.is_max());
>>> CID 1400091: (INVALIDATE_ITERATOR)
>>> Incrementing iterator "ls_iter" though it is already past the end of its container.
1166 ++ls_iter;
1167 }
1168
1169 dout(10) << " pgnls candidate 0x" << std::hex << candidate.get_hash()
1170 << " vs lower bound 0x" << lower_bound.get_hash() << dendl;
1171
/home/brad/working/src/ceph/src/osd/PrimaryLogPG.cc: 1344 in PrimaryLogPG::do_pg_op(boost::intrusive_ptr<OpRequest>)()
1338
1339 hobject_t candidate;
1340 if (mcand == lcand) {
1341 candidate = mcand;
1342 if (!mcand.is_max()) {
1343 ++ls_iter;
>>> CID 1400091: (INVALIDATE_ITERATOR)
>>> Incrementing iterator "missing_iter" though it is already past the end of its container.
1344 ++missing_iter;
1345 }
1346 } else if (cmp(mcand, lcand, get_sort_bitwise()) < 0) {
1347 candidate = mcand;
1348 assert(!mcand.is_max());
1349 ++missing_iter;
/home/brad/working/src/ceph/src/osd/PrimaryLogPG.cc: 1349 in PrimaryLogPG::do_pg_op(boost::intrusive_ptr<OpRequest>)()
1343 ++ls_iter;
1344 ++missing_iter;
1345 }
1346 } else if (cmp(mcand, lcand, get_sort_bitwise()) < 0) {
1347 candidate = mcand;
1348 assert(!mcand.is_max());
>>> CID 1400091: (INVALIDATE_ITERATOR)
>>> Incrementing iterator "missing_iter" though it is already past the end of its container.
1349 ++missing_iter;
1350 } else {
1351 candidate = lcand;
1352 assert(!lcand.is_max());
1353 ++ls_iter;
1354 }
/home/brad/working/src/ceph/src/osd/PrimaryLogPG.cc: 1343 in PrimaryLogPG::do_pg_op(boost::intrusive_ptr<OpRequest>)()
1337 *ls_iter;
1338
1339 hobject_t candidate;
1340 if (mcand == lcand) {
1341 candidate = mcand;
1342 if (!mcand.is_max()) {
>>> CID 1400091: (INVALIDATE_ITERATOR)
>>> Incrementing iterator "ls_iter" though it is already past the end of its container.
1343 ++ls_iter;
1344 ++missing_iter;
1345 }
1346 } else if (cmp(mcand, lcand, get_sort_bitwise()) < 0) {
1347 candidate = mcand;
1348 assert(!mcand.is_max());
/home/brad/working/src/ceph/src/osd/PrimaryLogPG.cc: 1353 in PrimaryLogPG::do_pg_op(boost::intrusive_ptr<OpRequest>)()
1347 candidate = mcand;
1348 assert(!mcand.is_max());
1349 ++missing_iter;
1350 } else {
1351 candidate = lcand;
1352 assert(!lcand.is_max());
>>> CID 1400091: (INVALIDATE_ITERATOR)
>>> Incrementing iterator "ls_iter" though it is already past the end of its container.
1353 ++ls_iter;
1354 }
1355
1356 if (cmp(candidate, next, get_sort_bitwise()) >= 0) {
1357 break;
1358 }
** CID 1400092: (INVALIDATE_ITERATOR)
/home/brad/working/src/ceph/src/mds/Locker.cc: 474 in Locker::acquire_locks(boost::intrusive_ptr<MDRequestImpl> &, std::set<SimpleLock *, std::less<SimpleLock *>, std::allocator<SimpleLock *>> &, std::set<SimpleLock *, std::less<SimpleLock *>, std::allocator<SimpleLock *>> &, std::set<SimpleLock *, std::less<SimpleLock *>, std::allocator<SimpleLock *>> &, std::map<SimpleLock *, int, std::less<SimpleLock *>, std::allocator<std::pair<SimpleLock *const , int>>> *, CInode *, bool)()
/home/brad/working/src/ceph/src/mds/Locker.cc: 474 in Locker::acquire_locks(boost::intrusive_ptr<MDRequestImpl> &, std::set<SimpleLock *, std::less<SimpleLock *>, std::allocator<SimpleLock *>> &, std::set<SimpleLock *, std::less<SimpleLock *>, std::allocator<SimpleLock *>> &, std::set<SimpleLock *, std::less<SimpleLock *>, std::allocator<SimpleLock *>> &, std::map<SimpleLock *, int, std::less<SimpleLock *>, std::allocator<std::pair<SimpleLock *const , int>>> *, CInode *, bool)()
________________________________________________________________________________________________________
*** CID 1400092: (INVALIDATE_ITERATOR)
/home/brad/working/src/ceph/src/mds/Locker.cc: 474 in Locker::acquire_locks(boost::intrusive_ptr<MDRequestImpl> &, std::set<SimpleLock *, std::less<SimpleLock *>, std::allocator<SimpleLock *>> &, std::set<SimpleLock *, std::less<SimpleLock *>, std::allocator<SimpleLock *>> &, std::set<SimpleLock *, std::less<SimpleLock *>, std::allocator<SimpleLock *>> &, std::map<SimpleLock *, int, std::less<SimpleLock *>, std::allocator<std::pair<SimpleLock *const , int>>> *, CInode *, bool)()
468 dout(10) << " already rdlocked " << *have << " " << *have->get_parent() << dendl;
469 continue;
470 }
471 }
472
473 // hose any stray locks
>>> CID 1400092: (INVALIDATE_ITERATOR)
>>> Dereferencing iterator "existing" though it is already past the end of its container.
474 if (*existing == *p) {
475 assert(need_wrlock || need_remote_wrlock);
476 SimpleLock *lock = *existing;
477 if (mdr->wrlocks.count(lock)) {
478 if (!need_wrlock)
479 dout(10) << " unlocking extra " << *lock << " " << *lock->get_parent() << dendl;
/home/brad/working/src/ceph/src/mds/Locker.cc: 474 in Locker::acquire_locks(boost::intrusive_ptr<MDRequestImpl> &, std::set<SimpleLock *, std::less<SimpleLock *>, std::allocator<SimpleLock *>> &, std::set<SimpleLock *, std::less<SimpleLock *>, std::allocator<SimpleLock *>> &, std::set<SimpleLock *, std::less<SimpleLock *>, std::allocator<SimpleLock *>> &, std::map<SimpleLock *, int, std::less<SimpleLock *>, std::allocator<std::pair<SimpleLock *const , int>>> *, CInode *, bool)()
468 dout(10) << " already rdlocked " << *have << " " << *have->get_parent() << dendl;
469 continue;
470 }
471 }
472
473 // hose any stray locks
>>> CID 1400092: (INVALIDATE_ITERATOR)
>>> Dereferencing iterator "existing" though it is already past the end of its container.
474 if (*existing == *p) {
475 assert(need_wrlock || need_remote_wrlock);
476 SimpleLock *lock = *existing;
477 if (mdr->wrlocks.count(lock)) {
478 if (!need_wrlock)
479 dout(10) << " unlocking extra " << *lock << " " << *lock->get_parent() << dendl;
** CID 1400093: Control flow issues (MISSING_BREAK)
/src/pybind/rbd/rbd.c: 21967 in __pyx_pw_3rbd_5Image_99lock_break()
________________________________________________________________________________________________________
*** CID 1400093: Control flow issues (MISSING_BREAK)
/src/pybind/rbd/rbd.c: 21967 in __pyx_pw_3rbd_5Image_99lock_break()
21961 }
21962 kw_args = PyDict_Size(__pyx_kwds);
21963 switch (pos_args) {
21964 case 0:
21965 if (likely((values[0] = PyDict_GetItem(__pyx_kwds, __pyx_n_s_lock_mode)) != 0)) kw_args--;
21966 else goto __pyx_L5_argtuple_error;
>>> CID 1400093: Control flow issues (MISSING_BREAK)
>>> The above case falls through to this one.
21967 case 1:
21968 if (likely((values[1] = PyDict_GetItem(__pyx_kwds, __pyx_n_s_lock_owner)) != 0)) kw_args--;
21969 else {
21970 __Pyx_RaiseArgtupleInvalid("lock_break", 1, 2, 2, 1); __PYX_ERR(0, 2118, __pyx_L3_error)
21971 }
21972 }
** CID 1400094: Control flow issues (MISSING_BREAK)
/src/pybind/rbd/rbd.c: 25768 in __pyx_pw_3rbd_5Image_127aio_discard()
________________________________________________________________________________________________________
*** CID 1400094: Control flow issues (MISSING_BREAK)
/src/pybind/rbd/rbd.c: 25768 in __pyx_pw_3rbd_5Image_127aio_discard()
25762 }
25763 kw_args = PyDict_Size(__pyx_kwds);
25764 switch (pos_args) {
25765 case 0:
25766 if (likely((values[0] = PyDict_GetItem(__pyx_kwds, __pyx_n_s_offset)) != 0)) kw_args--;
25767 else goto __pyx_L5_argtuple_error;
>>> CID 1400094: Control flow issues (MISSING_BREAK)
>>> The above case falls through to this one.
25768 case 1:
25769 if (likely((values[1] = PyDict_GetItem(__pyx_kwds, __pyx_n_s_length)) != 0)) kw_args--;
25770 else {
25771 __Pyx_RaiseArgtupleInvalid("aio_discard", 1, 3, 3, 1); __PYX_ERR(0, 2417, __pyx_L3_error)
25772 }
25773 case 2:
** CID 1400095: Control flow issues (MISSING_BREAK)
/src/pybind/rbd/rbd.c: 22873 in __pyx_pw_3rbd_5Image_107break_lock()
________________________________________________________________________________________________________
*** CID 1400095: Control flow issues (MISSING_BREAK)
/src/pybind/rbd/rbd.c: 22873 in __pyx_pw_3rbd_5Image_107break_lock()
22867 }
22868 kw_args = PyDict_Size(__pyx_kwds);
22869 switch (pos_args) {
22870 case 0:
22871 if (likely((values[0] = PyDict_GetItem(__pyx_kwds, __pyx_n_s_client)) != 0)) kw_args--;
22872 else goto __pyx_L5_argtuple_error;
>>> CID 1400095: Control flow issues (MISSING_BREAK)
>>> The above case falls through to this one.
22873 case 1:
22874 if (likely((values[1] = PyDict_GetItem(__pyx_kwds, __pyx_n_s_cookie)) != 0)) kw_args--;
22875 else {
22876 __Pyx_RaiseArgtupleInvalid("break_lock", 1, 2, 2, 1); __PYX_ERR(0, 2177, __pyx_L3_error)
22877 }
22878 }
** CID 1400096: Control flow issues (MISSING_BREAK)
/src/pybind/rbd/rbd.c: 18714 in __pyx_pw_3rbd_5Image_71diff_iterate()
________________________________________________________________________________________________________
*** CID 1400096: Control flow issues (MISSING_BREAK)
/src/pybind/rbd/rbd.c: 18714 in __pyx_pw_3rbd_5Image_71diff_iterate()
18708 }
18709 kw_args = PyDict_Size(__pyx_kwds);
18710 switch (pos_args) {
18711 case 0:
18712 if (likely((values[0] = PyDict_GetItem(__pyx_kwds, __pyx_n_s_offset)) != 0)) kw_args--;
18713 else goto __pyx_L5_argtuple_error;
>>> CID 1400096: Control flow issues (MISSING_BREAK)
>>> The above case falls through to this one.
18714 case 1:
18715 if (likely((values[1] = PyDict_GetItem(__pyx_kwds, __pyx_n_s_length)) != 0)) kw_args--;
18716 else {
18717 __Pyx_RaiseArgtupleInvalid("diff_iterate", 0, 4, 6, 1); __PYX_ERR(0, 1837, __pyx_L3_error)
18718 }
18719 case 2:
** CID 1400097: Control flow issues (MISSING_BREAK)
/src/pybind/rbd/rbd.c: 19480 in __pyx_pw_3rbd_5Image_75discard()
________________________________________________________________________________________________________
*** CID 1400097: Control flow issues (MISSING_BREAK)
/src/pybind/rbd/rbd.c: 19480 in __pyx_pw_3rbd_5Image_75discard()
19474 }
19475 kw_args = PyDict_Size(__pyx_kwds);
19476 switch (pos_args) {
19477 case 0:
19478 if (likely((values[0] = PyDict_GetItem(__pyx_kwds, __pyx_n_s_offset)) != 0)) kw_args--;
19479 else goto __pyx_L5_argtuple_error;
>>> CID 1400097: Control flow issues (MISSING_BREAK)
>>> The above case falls through to this one.
19480 case 1:
19481 if (likely((values[1] = PyDict_GetItem(__pyx_kwds, __pyx_n_s_length)) != 0)) kw_args--;
19482 else {
19483 __Pyx_RaiseArgtupleInvalid("discard", 1, 2, 2, 1); __PYX_ERR(0, 1930, __pyx_L3_error)
19484 }
19485 }
** CID 1400098: Control flow issues (MISSING_BREAK)
/src/pybind/rbd/rbd.c: 19036 in __pyx_pw_3rbd_5Image_73write()
________________________________________________________________________________________________________
*** CID 1400098: Control flow issues (MISSING_BREAK)
/src/pybind/rbd/rbd.c: 19036 in __pyx_pw_3rbd_5Image_73write()
19030 }
19031 kw_args = PyDict_Size(__pyx_kwds);
19032 switch (pos_args) {
19033 case 0:
19034 if (likely((values[0] = PyDict_GetItem(__pyx_kwds, __pyx_n_s_data)) != 0)) kw_args--;
19035 else goto __pyx_L5_argtuple_error;
>>> CID 1400098: Control flow issues (MISSING_BREAK)
>>> The above case falls through to this one.
19036 case 1:
19037 if (likely((values[1] = PyDict_GetItem(__pyx_kwds, __pyx_n_s_offset)) != 0)) kw_args--;
19038 else {
19039 __Pyx_RaiseArgtupleInvalid("write", 0, 2, 3, 1); __PYX_ERR(0, 1895, __pyx_L3_error)
19040 }
19041 case 2:
** CID 1400099: Control flow issues (MISSING_BREAK)
/src/pybind/rbd/rbd.c: 24657 in __pyx_pw_3rbd_5Image_123aio_read()
________________________________________________________________________________________________________
*** CID 1400099: Control flow issues (MISSING_BREAK)
/src/pybind/rbd/rbd.c: 24657 in __pyx_pw_3rbd_5Image_123aio_read()
24651 }
24652 case 2:
24653 if (likely((values[2] = PyDict_GetItem(__pyx_kwds, __pyx_n_s_oncomplete)) != 0)) kw_args--;
24654 else {
24655 __Pyx_RaiseArgtupleInvalid("aio_read", 0, 3, 4, 2); __PYX_ERR(0, 2316, __pyx_L3_error)
24656 }
>>> CID 1400099: Control flow issues (MISSING_BREAK)
>>> The above case falls through to this one.
24657 case 3:
24658 if (kw_args > 0) {
24659 PyObject* value = PyDict_GetItem(__pyx_kwds, __pyx_n_s_fadvise_flags);
24660 if (value) { values[3] = value; kw_args--; }
24661 }
24662 }
** CID 1400100: Control flow issues (MISSING_BREAK)
/src/pybind/rbd/rbd.c: 25334 in __pyx_pw_3rbd_5Image_125aio_write()
________________________________________________________________________________________________________
*** CID 1400100: Control flow issues (MISSING_BREAK)
/src/pybind/rbd/rbd.c: 25334 in __pyx_pw_3rbd_5Image_125aio_write()
25328 }
25329 kw_args = PyDict_Size(__pyx_kwds);
25330 switch (pos_args) {
25331 case 0:
25332 if (likely((values[0] = PyDict_GetItem(__pyx_kwds, __pyx_n_s_data)) != 0)) kw_args--;
25333 else goto __pyx_L5_argtuple_error;
>>> CID 1400100: Control flow issues (MISSING_BREAK)
>>> The above case falls through to this one.
25334 case 1:
25335 if (likely((values[1] = PyDict_GetItem(__pyx_kwds, __pyx_n_s_offset)) != 0)) kw_args--;
25336 else {
25337 __Pyx_RaiseArgtupleInvalid("aio_write", 0, 3, 4, 1); __PYX_ERR(0, 2371, __pyx_L3_error)
25338 }
25339 case 2:
** CID 1400101: Control flow issues (MISSING_BREAK)
/src/pybind/rbd/rbd.c: 25773 in __pyx_pw_3rbd_5Image_127aio_discard()
________________________________________________________________________________________________________
*** CID 1400101: Control flow issues (MISSING_BREAK)
/src/pybind/rbd/rbd.c: 25773 in __pyx_pw_3rbd_5Image_127aio_discard()
25767 else goto __pyx_L5_argtuple_error;
25768 case 1:
25769 if (likely((values[1] = PyDict_GetItem(__pyx_kwds, __pyx_n_s_length)) != 0)) kw_args--;
25770 else {
25771 __Pyx_RaiseArgtupleInvalid("aio_discard", 1, 3, 3, 1); __PYX_ERR(0, 2417, __pyx_L3_error)
25772 }
>>> CID 1400101: Control flow issues (MISSING_BREAK)
>>> The above case falls through to this one.
25773 case 2:
25774 if (likely((values[2] = PyDict_GetItem(__pyx_kwds, __pyx_n_s_oncomplete)) != 0)) kw_args--;
25775 else {
25776 __Pyx_RaiseArgtupleInvalid("aio_discard", 1, 3, 3, 2); __PYX_ERR(0, 2417, __pyx_L3_error)
25777 }
25778 }
** CID 1400102: Control flow issues (MISSING_BREAK)
/src/pybind/rbd/rbd.c: 18734 in __pyx_pw_3rbd_5Image_71diff_iterate()
________________________________________________________________________________________________________
*** CID 1400102: Control flow issues (MISSING_BREAK)
/src/pybind/rbd/rbd.c: 18734 in __pyx_pw_3rbd_5Image_71diff_iterate()
18728 }
18729 case 4:
18730 if (kw_args > 0) {
18731 PyObject* value = PyDict_GetItem(__pyx_kwds, __pyx_n_s_include_parent);
18732 if (value) { values[4] = value; kw_args--; }
18733 }
>>> CID 1400102: Control flow issues (MISSING_BREAK)
>>> The above case falls through to this one.
18734 case 5:
18735 if (kw_args > 0) {
18736 PyObject* value = PyDict_GetItem(__pyx_kwds, __pyx_n_s_whole_object);
18737 if (value) { values[5] = value; kw_args--; }
18738 }
18739 }
** CID 1400103: Control flow issues (MISSING_BREAK)
/src/pybind/rbd/rbd.c: 19041 in __pyx_pw_3rbd_5Image_73write()
________________________________________________________________________________________________________
*** CID 1400103: Control flow issues (MISSING_BREAK)
/src/pybind/rbd/rbd.c: 19041 in __pyx_pw_3rbd_5Image_73write()
19035 else goto __pyx_L5_argtuple_error;
19036 case 1:
19037 if (likely((values[1] = PyDict_GetItem(__pyx_kwds, __pyx_n_s_offset)) != 0)) kw_args--;
19038 else {
19039 __Pyx_RaiseArgtupleInvalid("write", 0, 2, 3, 1); __PYX_ERR(0, 1895, __pyx_L3_error)
19040 }
>>> CID 1400103: Control flow issues (MISSING_BREAK)
>>> The above case falls through to this one.
19041 case 2:
19042 if (kw_args > 0) {
19043 PyObject* value = PyDict_GetItem(__pyx_kwds, __pyx_n_s_fadvise_flags);
19044 if (value) { values[2] = value; kw_args--; }
19045 }
19046 }
** CID 1400104: Control flow issues (MISSING_BREAK)
/src/pybind/rbd/rbd.c: 18729 in __pyx_pw_3rbd_5Image_71diff_iterate()
________________________________________________________________________________________________________
*** CID 1400104: Control flow issues (MISSING_BREAK)
/src/pybind/rbd/rbd.c: 18729 in __pyx_pw_3rbd_5Image_71diff_iterate()
18723 }
18724 case 3:
18725 if (likely((values[3] = PyDict_GetItem(__pyx_kwds, __pyx_n_s_iterate_cb)) != 0)) kw_args--;
18726 else {
18727 __Pyx_RaiseArgtupleInvalid("diff_iterate", 0, 4, 6, 3); __PYX_ERR(0, 1837, __pyx_L3_error)
18728 }
>>> CID 1400104: Control flow issues (MISSING_BREAK)
>>> The above case falls through to this one.
18729 case 4:
18730 if (kw_args > 0) {
18731 PyObject* value = PyDict_GetItem(__pyx_kwds, __pyx_n_s_include_parent);
18732 if (value) { values[4] = value; kw_args--; }
18733 }
18734 case 5:
** CID 1400105: Control flow issues (MISSING_BREAK)
/src/pybind/rbd/rbd.c: 24647 in __pyx_pw_3rbd_5Image_123aio_read()
________________________________________________________________________________________________________
*** CID 1400105: Control flow issues (MISSING_BREAK)
/src/pybind/rbd/rbd.c: 24647 in __pyx_pw_3rbd_5Image_123aio_read()
24641 }
24642 kw_args = PyDict_Size(__pyx_kwds);
24643 switch (pos_args) {
24644 case 0:
24645 if (likely((values[0] = PyDict_GetItem(__pyx_kwds, __pyx_n_s_offset)) != 0)) kw_args--;
24646 else goto __pyx_L5_argtuple_error;
>>> CID 1400105: Control flow issues (MISSING_BREAK)
>>> The above case falls through to this one.
24647 case 1:
24648 if (likely((values[1] = PyDict_GetItem(__pyx_kwds, __pyx_n_s_length)) != 0)) kw_args--;
24649 else {
24650 __Pyx_RaiseArgtupleInvalid("aio_read", 0, 3, 4, 1); __PYX_ERR(0, 2316, __pyx_L3_error)
24651 }
24652 case 2:
** CID 1400106: Control flow issues (MISSING_BREAK)
/src/pybind/rbd/rbd.c: 18318 in __pyx_pw_3rbd_5Image_69read()
________________________________________________________________________________________________________
*** CID 1400106: Control flow issues (MISSING_BREAK)
/src/pybind/rbd/rbd.c: 18318 in __pyx_pw_3rbd_5Image_69read()
18312 else goto __pyx_L5_argtuple_error;
18313 case 1:
18314 if (likely((values[1] = PyDict_GetItem(__pyx_kwds, __pyx_n_s_length)) != 0)) kw_args--;
18315 else {
18316 __Pyx_RaiseArgtupleInvalid("read", 0, 2, 3, 1); __PYX_ERR(0, 1792, __pyx_L3_error)
18317 }
>>> CID 1400106: Control flow issues (MISSING_BREAK)
>>> The above case falls through to this one.
18318 case 2:
18319 if (kw_args > 0) {
18320 PyObject* value = PyDict_GetItem(__pyx_kwds, __pyx_n_s_fadvise_flags);
18321 if (value) { values[2] = value; kw_args--; }
18322 }
18323 }
** CID 1400107: Control flow issues (MISSING_BREAK)
/src/pybind/rbd/rbd.c: 24652 in __pyx_pw_3rbd_5Image_123aio_read()
________________________________________________________________________________________________________
*** CID 1400107: Control flow issues (MISSING_BREAK)
/src/pybind/rbd/rbd.c: 24652 in __pyx_pw_3rbd_5Image_123aio_read()
24646 else goto __pyx_L5_argtuple_error;
24647 case 1:
24648 if (likely((values[1] = PyDict_GetItem(__pyx_kwds, __pyx_n_s_length)) != 0)) kw_args--;
24649 else {
24650 __Pyx_RaiseArgtupleInvalid("aio_read", 0, 3, 4, 1); __PYX_ERR(0, 2316, __pyx_L3_error)
24651 }
>>> CID 1400107: Control flow issues (MISSING_BREAK)
>>> The above case falls through to this one.
24652 case 2:
24653 if (likely((values[2] = PyDict_GetItem(__pyx_kwds, __pyx_n_s_oncomplete)) != 0)) kw_args--;
24654 else {
24655 __Pyx_RaiseArgtupleInvalid("aio_read", 0, 3, 4, 2); __PYX_ERR(0, 2316, __pyx_L3_error)
24656 }
24657 case 3:
** CID 1400108: Control flow issues (MISSING_BREAK)
/src/pybind/rbd/rbd.c: 25344 in __pyx_pw_3rbd_5Image_125aio_write()
________________________________________________________________________________________________________
*** CID 1400108: Control flow issues (MISSING_BREAK)
/src/pybind/rbd/rbd.c: 25344 in __pyx_pw_3rbd_5Image_125aio_write()
25338 }
25339 case 2:
25340 if (likely((values[2] = PyDict_GetItem(__pyx_kwds, __pyx_n_s_oncomplete)) != 0)) kw_args--;
25341 else {
25342 __Pyx_RaiseArgtupleInvalid("aio_write", 0, 3, 4, 2); __PYX_ERR(0, 2371, __pyx_L3_error)
25343 }
>>> CID 1400108: Control flow issues (MISSING_BREAK)
>>> The above case falls through to this one.
25344 case 3:
25345 if (kw_args > 0) {
25346 PyObject* value = PyDict_GetItem(__pyx_kwds, __pyx_n_s_fadvise_flags);
25347 if (value) { values[3] = value; kw_args--; }
25348 }
25349 }
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRaGCnxtQO9E3gxlB2GxVsWFENryh7bC5hIb-2FQBVM85YLQ-3D-3D_2sw0G7ICm9mxCh1lYW1t9y1lfDrIerWzLwB67LZ-2Bn8G4SfPGNSD3RvuUtY7CjQxWAKKd4QPmcbrq2J59s0UdIDHqWajxEGzhGhsaMdSuD-2FVjfkcDDG8SEmjXlcbu8v85WFGgN5Z7AjKrr7OB-2FQBZH7WNTcLiDxZJdCMr-2FUhyOt-2FWIbOSmmYJBc31VbudKj9OR65I-2BXPWr6IkBtbGdU6ntJv3j68DFXHlW-2Fb3GTb-2B484-3D
To manage Coverity Scan email notifications for "ceph-devel@vger.kernel.org", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4Bco8jcmzhh7FSyvoR0E3-2BDgRcBCQ6OuthHBtaTCGNq9zoLsiw8NWrIF2zsdhfTt-2FbHjZ2ToL3Et9v1-2BrDLungAOjHpQtOY-2BsyLiTVCQEUCU-3D_2sw0G7ICm9mxCh1lYW1t9y1lfDrIerWzLwB67LZ-2Bn8G4SfPGNSD3RvuUtY7CjQxWAKKd4QPmcbrq2J59s0UdIGa4K-2Bq51d-2BhzkdCcM3W0q744vfLK5cnnjh4CJ8DDEdRUDbZrBxlxHtAJ0zThSDmi2v0i2c7-2FcE2y0g8vs-2BVLuM1Lnqr2CuWU-2BTzou7CSEZQZk3xdiycCHA-2BD6armhqWP9CNPR-2FNi1uSk1sfm2k8jww-3D
next reply other threads:[~2017-02-05 10:08 UTC|newest]
Thread overview: 124+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-05 10:08 scan-admin [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-08-20 12:22 New Defects reported by Coverity Scan for ceph scan-admin
2022-08-20 13:17 ` Jeff Layton
2022-08-22 3:54 ` Brad Hubbard
2022-08-23 12:52 ` Jeff Layton
2018-01-04 3:32 scan-admin
2017-12-28 1:57 scan-admin
2017-12-21 1:54 scan-admin
2017-12-21 3:34 ` Jos Collin
2017-12-21 4:03 ` Brad Hubbard
2017-12-14 6:49 scan-admin
2017-12-01 2:25 scan-admin
2017-11-23 0:19 scan-admin
2017-11-16 11:35 scan-admin
2017-11-09 11:36 scan-admin
2017-11-02 2:11 scan-admin
2017-10-27 0:31 scan-admin
2017-10-19 3:54 scan-admin
2017-10-12 5:54 scan-admin
2017-10-05 5:08 scan-admin
2017-09-28 5:09 scan-admin
2017-09-21 6:44 scan-admin
2017-09-14 7:19 scan-admin
2017-09-07 5:08 scan-admin
2017-08-31 6:39 scan-admin
2017-08-24 23:32 scan-admin
2017-08-17 3:29 scan-admin
2017-08-10 3:50 scan-admin
2017-08-03 4:57 scan-admin
2017-07-27 3:50 scan-admin
2017-07-28 18:42 ` Gregory Farnum
2017-07-28 22:22 ` Brad Hubbard
2017-07-20 4:08 scan-admin
2017-07-13 5:11 scan-admin
2017-07-06 5:03 scan-admin
2017-06-29 4:08 scan-admin
2017-06-22 4:27 scan-admin
2017-06-15 9:50 scan-admin
2017-06-11 23:46 scan-admin
2017-06-01 4:33 scan-admin
2017-05-25 6:22 scan-admin
2017-05-18 1:44 scan-admin
2017-05-11 5:32 scan-admin
2017-05-04 2:45 scan-admin
2017-04-27 2:22 scan-admin
2017-04-20 5:34 scan-admin
2017-04-13 6:25 scan-admin
2017-04-06 9:40 scan-admin
2017-03-31 1:25 scan-admin
2017-03-23 7:58 scan-admin
2017-03-16 7:37 scan-admin
2017-03-09 6:12 scan-admin
2017-03-02 7:44 scan-admin
2017-02-23 9:09 scan-admin
2017-02-17 2:29 scan-admin
[not found] ` <CAJE9aOMoxWjhq=g+25hfhMhxSCnHAOwAyNhXvkxS1wwBEd3j+A@mail.gmail.com>
2017-02-17 5:19 ` kefu chai
2017-01-27 13:22 scan-admin
2017-01-17 3:01 scan-admin
2017-01-09 10:05 scan-admin
2016-12-30 8:33 scan-admin
2016-12-23 9:16 scan-admin
2016-12-16 8:54 scan-admin
2016-12-09 11:29 scan-admin
2016-12-02 11:08 scan-admin
2016-11-25 7:55 scan-admin
2016-03-19 17:58 scan-admin
2016-03-13 17:40 scan-admin
2016-03-12 18:04 scan-admin
2016-03-05 17:55 scan-admin
2016-03-07 20:59 ` Gregory Farnum
2016-02-27 18:07 scan-admin
2016-02-20 18:26 scan-admin
2016-02-18 20:32 scan-admin
2016-02-13 17:47 scan-admin
2016-02-11 17:57 scan-admin
2016-02-11 22:01 ` Gregory Farnum
2016-02-12 16:36 ` Adam C. Emerson
2016-02-04 20:39 scan-admin
2016-02-03 20:40 scan-admin
2015-05-02 14:37 scan-admin
2015-01-21 1:41 scan-admin
2015-01-16 14:39 scan-admin
2015-01-16 15:17 ` Gregory Farnum
2015-01-16 16:00 ` John Spray
2015-01-16 16:08 ` Sage Weil
[not found] <54b528bef1f63_1b74f3532c63410@scan.coverity.com.mail>
2015-01-13 14:34 ` Sage Weil
2015-01-13 14:16 scan-admin
2015-01-10 14:36 scan-admin
2015-01-10 15:48 ` Haomai Wang
2015-01-09 14:30 scan-admin
2015-01-09 15:26 ` Sage Weil
2015-01-09 15:32 ` Danny Al-Gaaf
2015-01-04 14:14 scan-admin
2014-12-27 14:13 scan-admin
2014-12-28 6:03 ` Sage Weil
2014-12-26 14:19 scan-admin
2014-12-23 14:37 scan-admin
2014-12-21 14:13 scan-admin
2014-12-18 14:19 scan-admin
2014-12-14 14:17 scan-admin
2014-12-07 20:36 scan-admin
2014-12-05 14:11 scan-admin
2014-12-02 14:09 scan-admin
2014-11-25 14:09 scan-admin
2014-11-23 14:08 scan-admin
2014-11-20 14:20 scan-admin
2014-11-14 14:21 scan-admin
2014-11-13 14:21 scan-admin
2014-11-11 20:40 scan-admin
2014-11-09 14:12 scan-admin
2014-10-30 13:19 scan-admin
2014-10-30 16:08 ` Sage Weil
2014-10-28 13:16 scan-admin
2014-10-28 18:26 ` Danny Al-Gaaf
2014-10-26 13:17 scan-admin
2014-10-24 17:55 scan-admin
2014-10-24 17:59 ` Sage Weil
2014-10-17 13:27 scan-admin
2014-10-09 13:23 scan-admin
2014-10-02 13:21 scan-admin
2014-09-25 13:18 scan-admin
2014-09-16 21:40 scan-admin
2014-08-16 21:31 scan-admin
2014-08-09 15:30 scan-admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5896f9918a123_3aabc3f3343035f@ss1435.mail \
--to=scan-admin@coverity.com \
--cc=ceph-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox