CEPH filesystem development
 help / color / mirror / Atom feed
From: "Bartłomiej Święcki" <bartlomiej.swiecki@corp.ovh.com>
To: Ceph Development <ceph-devel@vger.kernel.org>
Subject: RBD image name constraints
Date: Fri, 8 Apr 2016 14:23:32 +0200	[thread overview]
Message-ID: <5707A2C4.3030102@corp.ovh.com> (raw)

Hi,

What are constraints regarding names of RBD images? I tried to look it 
up but without success.

My tests show that maximum length is about 4089 bytes and the only 
forbidden characters are '\0' and '@' but didn't get deep enough into 
the code to figure out the length limit. Are my findings correct?

I also think I've found a regression introduced in v10.0.1 regarding 
pool / image name constraints (introduced in 
fa4e00f8c85603ed202bfef2f3be6086482fbbb2).

In newer versions there's regex that's parsing image name passed to rbd 
command (in src/tools/rbd/Utils.cc, function: extract_spec):

     "^(?:([^/@]+)/)?([^/@]+)(?:@([^/@]+))?$"

It won't parse pool name with '@', image name with '/' nor snapshot name 
with '/', which was allowed in previous implementation based on strchr.

Kind regards
Bartłomiej Święcki
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2016-04-08 14:53 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-08 12:23 Bartłomiej Święcki [this message]
2016-04-08 16:13 ` RBD image name constraints Ilya Dryomov
2016-04-08 17:36   ` Alex Elder
2016-04-08 18:12     ` Ilya Dryomov
2016-04-11  8:45   ` Bartłomiej Święcki
2016-04-08 20:29 ` Mykola Golub
2016-04-11  8:45   ` Bartłomiej Święcki
2016-04-11  9:37     ` Mykola Golub
2016-04-11 14:29       ` Jason Dillaman
2016-04-11 15:08         ` Ilya Dryomov
2016-04-12 12:32           ` Bartłomiej Święcki
2016-04-12 12:47             ` Wido den Hollander
2016-04-12 13:01               ` Jason Dillaman
2016-04-12 13:23                 ` Ilya Dryomov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5707A2C4.3030102@corp.ovh.com \
    --to=bartlomiej.swiecki@corp.ovh.com \
    --cc=ceph-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox