From: Jason Dillaman <dillaman@redhat.com>
To: Wido den Hollander <wido@42on.com>
Cc: "Ilya Dryomov" <idryomov@gmail.com>,
"Bartłomiej Święcki" <bartlomiej.swiecki@corp.ovh.com>,
"Mykola Golub" <mgolub@mirantis.com>,
"Josh Durgin" <jdurgin@redhat.com>,
"Ceph Development" <ceph-devel@vger.kernel.org>
Subject: Re: RBD image name constraints
Date: Tue, 12 Apr 2016 09:01:53 -0400 (EDT) [thread overview]
Message-ID: <842665427.50033069.1460466113899.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <1738732185.2918.160e133c-ee3f-4c6e-9b8b-e4d468651d78.open-xchange@ox.pcextreme.nl>
> > Op 12 april 2016 om 14:32 schreef Bartłomiej Święcki
> > <bartlomiej.swiecki@corp.ovh.com>:
> >
> >
> >
> > On 04/11/2016 05:08 PM, Ilya Dryomov wrote:
> > > On Mon, Apr 11, 2016 at 4:29 PM, Jason Dillaman <dillaman@redhat.com>
> > > wrote:
> > >
> > >> It would probably make sense to relax it for non-create operations and
> > >> use
> > >> a strict regex for create/clone/import/rename operations.
> > > I think it would also make sense to start enforcing a limit on the
> > > length of the image name on create/clone/etc. I'm not pushing for it
> > > to be 96 chars (although I do believe it'd be sensible), just that we
> > > don't want it to be RADOS - strlen("rbd_id.").
> > >
> > > Thanks,
> > >
> > > Ilya
> > Sounds like a good plan to me, maybe we should also consider allowed
> > character set? Non-ascii or control characters make little sense here too.
> >
>
> Seems like a sane thing to me:
>
> a-z, A-Z, 0-9, -, _ and . are the characters you want to allow in a image's
> name. I can't think of anything more.
>
> Wido
>
> > Regards,
> > Bartek
> > --
> > To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
All of this sounds good to me -- we should circulate a proposal in ceph-users before making any change. Assuming we can reach a plan that doesn't break someone's Ceph deployment, this could be included as part of the Kraken-release.
Ilya -- just so that I am clear, is the current kernel limitation 96 characters minus the "rbd_id."-prefix (format 2) or ".rbd"-suffix (format 1)?
--
Jason Dillaman
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-04-12 13:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-08 12:23 RBD image name constraints Bartłomiej Święcki
2016-04-08 16:13 ` Ilya Dryomov
2016-04-08 17:36 ` Alex Elder
2016-04-08 18:12 ` Ilya Dryomov
2016-04-11 8:45 ` Bartłomiej Święcki
2016-04-08 20:29 ` Mykola Golub
2016-04-11 8:45 ` Bartłomiej Święcki
2016-04-11 9:37 ` Mykola Golub
2016-04-11 14:29 ` Jason Dillaman
2016-04-11 15:08 ` Ilya Dryomov
2016-04-12 12:32 ` Bartłomiej Święcki
2016-04-12 12:47 ` Wido den Hollander
2016-04-12 13:01 ` Jason Dillaman [this message]
2016-04-12 13:23 ` Ilya Dryomov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=842665427.50033069.1460466113899.JavaMail.zimbra@redhat.com \
--to=dillaman@redhat.com \
--cc=bartlomiej.swiecki@corp.ovh.com \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=jdurgin@redhat.com \
--cc=mgolub@mirantis.com \
--cc=wido@42on.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox