From: Jeff Layton <jlayton@kernel.org>
To: Ilya Dryomov <idryomov@gmail.com>
Cc: "Liu, Changcheng" <changcheng.liu@intel.com>,
Ceph Development <ceph-devel@vger.kernel.org>
Subject: Re: [PATCH] libceph: remove unused defined macro for port
Date: Tue, 10 Nov 2020 11:23:41 -0500 [thread overview]
Message-ID: <d1448816b4acd559bce60dbc3cbec5378d796910.camel@kernel.org> (raw)
In-Reply-To: <CAOi1vP9h96K+HFdWUun69pZjwXC9bkbYAELUED1ixaXiA2LzTw@mail.gmail.com>
On Tue, 2020-11-10 at 17:10 +0100, Ilya Dryomov wrote:
> On Tue, Nov 10, 2020 at 3:00 PM Jeff Layton <jlayton@kernel.org> wrote:
> >
> > On Tue, 2020-11-10 at 21:52 +0800, changcheng.liu@intel.com wrote:
> > > 1. monitor's default port is defined by CEPH_MON_PORT
> > > 2. CEPH_PORT_START & CEPH_PORT_LAST are not needed.
> > >
> > > Signed-off-by: Changcheng Liu <changcheng.liu@aliyun.com>
> > >
> > > diff --git a/include/linux/ceph/msgr.h b/include/linux/ceph/msgr.h
> > > index 1c1887206ffa..feff5a2dc33e 100644
> > > --- a/include/linux/ceph/msgr.h
> > > +++ b/include/linux/ceph/msgr.h
> > > @@ -7,15 +7,6 @@
> > >
> > >
> > > #define CEPH_MON_PORT 6789 /* default monitor port */
> > >
> > >
> > > -/*
> > > - * client-side processes will try to bind to ports in this
> > > - * range, simply for the benefit of tools like nmap or wireshark
> > > - * that would like to identify the protocol.
> > > - */
> > > -#define CEPH_PORT_FIRST 6789
> > > -#define CEPH_PORT_START 6800 /* non-monitors start here */
> > > -#define CEPH_PORT_LAST 6900
> > > -
> > > /*
> > > * tcp connection banner. include a protocol version. and adjust
> > > * whenever the wire protocol changes. try to keep this string length
> >
> > Thanks! Merged into testing branch.
>
> Jeff, the From address doesn't match the SOB address here. A few
> weeks ago I asked Changcheng to resend because of this and it looks
> like he sent two copies of the same patch today. The other one seems
> to be in order -- please drop this one.
>
Ok, dropped.
--
Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2020-11-10 16:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 13:52 [PATCH] libceph: remove unused defined macro for port changcheng.liu
2020-11-10 14:00 ` Jeff Layton
2020-11-10 16:10 ` Ilya Dryomov
2020-11-10 16:23 ` Jeff Layton [this message]
[not found] <20201110132008.GA90192@nstpc>
2020-11-10 16:51 ` Ilya Dryomov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1448816b4acd559bce60dbc3cbec5378d796910.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=changcheng.liu@intel.com \
--cc=idryomov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox