* [PATCH] libceph: remove unused defined macro for port
@ 2020-11-10 13:52 changcheng.liu
2020-11-10 14:00 ` Jeff Layton
0 siblings, 1 reply; 5+ messages in thread
From: changcheng.liu @ 2020-11-10 13:52 UTC (permalink / raw)
To: jlayton, idryomov; +Cc: ceph-devel
1. monitor's default port is defined by CEPH_MON_PORT
2. CEPH_PORT_START & CEPH_PORT_LAST are not needed.
Signed-off-by: Changcheng Liu <changcheng.liu@aliyun.com>
diff --git a/include/linux/ceph/msgr.h b/include/linux/ceph/msgr.h
index 1c1887206ffa..feff5a2dc33e 100644
--- a/include/linux/ceph/msgr.h
+++ b/include/linux/ceph/msgr.h
@@ -7,15 +7,6 @@
#define CEPH_MON_PORT 6789 /* default monitor port */
-/*
- * client-side processes will try to bind to ports in this
- * range, simply for the benefit of tools like nmap or wireshark
- * that would like to identify the protocol.
- */
-#define CEPH_PORT_FIRST 6789
-#define CEPH_PORT_START 6800 /* non-monitors start here */
-#define CEPH_PORT_LAST 6900
-
/*
* tcp connection banner. include a protocol version. and adjust
* whenever the wire protocol changes. try to keep this string length
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] libceph: remove unused defined macro for port
2020-11-10 13:52 [PATCH] libceph: remove unused defined macro for port changcheng.liu
@ 2020-11-10 14:00 ` Jeff Layton
2020-11-10 16:10 ` Ilya Dryomov
0 siblings, 1 reply; 5+ messages in thread
From: Jeff Layton @ 2020-11-10 14:00 UTC (permalink / raw)
To: changcheng.liu, idryomov; +Cc: ceph-devel
On Tue, 2020-11-10 at 21:52 +0800, changcheng.liu@intel.com wrote:
> 1. monitor's default port is defined by CEPH_MON_PORT
> 2. CEPH_PORT_START & CEPH_PORT_LAST are not needed.
>
> Signed-off-by: Changcheng Liu <changcheng.liu@aliyun.com>
>
> diff --git a/include/linux/ceph/msgr.h b/include/linux/ceph/msgr.h
> index 1c1887206ffa..feff5a2dc33e 100644
> --- a/include/linux/ceph/msgr.h
> +++ b/include/linux/ceph/msgr.h
> @@ -7,15 +7,6 @@
>
>
> #define CEPH_MON_PORT 6789 /* default monitor port */
>
>
> -/*
> - * client-side processes will try to bind to ports in this
> - * range, simply for the benefit of tools like nmap or wireshark
> - * that would like to identify the protocol.
> - */
> -#define CEPH_PORT_FIRST 6789
> -#define CEPH_PORT_START 6800 /* non-monitors start here */
> -#define CEPH_PORT_LAST 6900
> -
> /*
> * tcp connection banner. include a protocol version. and adjust
> * whenever the wire protocol changes. try to keep this string length
Thanks! Merged into testing branch.
Cheers,
--
Jeff Layton <jlayton@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] libceph: remove unused defined macro for port
2020-11-10 14:00 ` Jeff Layton
@ 2020-11-10 16:10 ` Ilya Dryomov
2020-11-10 16:23 ` Jeff Layton
0 siblings, 1 reply; 5+ messages in thread
From: Ilya Dryomov @ 2020-11-10 16:10 UTC (permalink / raw)
To: Jeff Layton; +Cc: Liu, Changcheng, Ceph Development
On Tue, Nov 10, 2020 at 3:00 PM Jeff Layton <jlayton@kernel.org> wrote:
>
> On Tue, 2020-11-10 at 21:52 +0800, changcheng.liu@intel.com wrote:
> > 1. monitor's default port is defined by CEPH_MON_PORT
> > 2. CEPH_PORT_START & CEPH_PORT_LAST are not needed.
> >
> > Signed-off-by: Changcheng Liu <changcheng.liu@aliyun.com>
> >
> > diff --git a/include/linux/ceph/msgr.h b/include/linux/ceph/msgr.h
> > index 1c1887206ffa..feff5a2dc33e 100644
> > --- a/include/linux/ceph/msgr.h
> > +++ b/include/linux/ceph/msgr.h
> > @@ -7,15 +7,6 @@
> >
> >
> > #define CEPH_MON_PORT 6789 /* default monitor port */
> >
> >
> > -/*
> > - * client-side processes will try to bind to ports in this
> > - * range, simply for the benefit of tools like nmap or wireshark
> > - * that would like to identify the protocol.
> > - */
> > -#define CEPH_PORT_FIRST 6789
> > -#define CEPH_PORT_START 6800 /* non-monitors start here */
> > -#define CEPH_PORT_LAST 6900
> > -
> > /*
> > * tcp connection banner. include a protocol version. and adjust
> > * whenever the wire protocol changes. try to keep this string length
>
> Thanks! Merged into testing branch.
Jeff, the From address doesn't match the SOB address here. A few
weeks ago I asked Changcheng to resend because of this and it looks
like he sent two copies of the same patch today. The other one seems
to be in order -- please drop this one.
Thanks,
Ilya
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] libceph: remove unused defined macro for port
2020-11-10 16:10 ` Ilya Dryomov
@ 2020-11-10 16:23 ` Jeff Layton
0 siblings, 0 replies; 5+ messages in thread
From: Jeff Layton @ 2020-11-10 16:23 UTC (permalink / raw)
To: Ilya Dryomov; +Cc: Liu, Changcheng, Ceph Development
On Tue, 2020-11-10 at 17:10 +0100, Ilya Dryomov wrote:
> On Tue, Nov 10, 2020 at 3:00 PM Jeff Layton <jlayton@kernel.org> wrote:
> >
> > On Tue, 2020-11-10 at 21:52 +0800, changcheng.liu@intel.com wrote:
> > > 1. monitor's default port is defined by CEPH_MON_PORT
> > > 2. CEPH_PORT_START & CEPH_PORT_LAST are not needed.
> > >
> > > Signed-off-by: Changcheng Liu <changcheng.liu@aliyun.com>
> > >
> > > diff --git a/include/linux/ceph/msgr.h b/include/linux/ceph/msgr.h
> > > index 1c1887206ffa..feff5a2dc33e 100644
> > > --- a/include/linux/ceph/msgr.h
> > > +++ b/include/linux/ceph/msgr.h
> > > @@ -7,15 +7,6 @@
> > >
> > >
> > > #define CEPH_MON_PORT 6789 /* default monitor port */
> > >
> > >
> > > -/*
> > > - * client-side processes will try to bind to ports in this
> > > - * range, simply for the benefit of tools like nmap or wireshark
> > > - * that would like to identify the protocol.
> > > - */
> > > -#define CEPH_PORT_FIRST 6789
> > > -#define CEPH_PORT_START 6800 /* non-monitors start here */
> > > -#define CEPH_PORT_LAST 6900
> > > -
> > > /*
> > > * tcp connection banner. include a protocol version. and adjust
> > > * whenever the wire protocol changes. try to keep this string length
> >
> > Thanks! Merged into testing branch.
>
> Jeff, the From address doesn't match the SOB address here. A few
> weeks ago I asked Changcheng to resend because of this and it looks
> like he sent two copies of the same patch today. The other one seems
> to be in order -- please drop this one.
>
Ok, dropped.
--
Jeff Layton <jlayton@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <20201110132008.GA90192@nstpc>]
* Re: [PATCH] libceph: remove unused defined macro for port
[not found] <20201110132008.GA90192@nstpc>
@ 2020-11-10 16:51 ` Ilya Dryomov
0 siblings, 0 replies; 5+ messages in thread
From: Ilya Dryomov @ 2020-11-10 16:51 UTC (permalink / raw)
To: Liu, Changcheng; +Cc: Jeff Layton, Ceph Development
On Tue, Nov 10, 2020 at 2:20 PM Liu, Changcheng
<changcheng.liu@aliyun.com> wrote:
>
> 1. monitor's default port is defined by CEPH_MON_PORT
> 2. CEPH_PORT_START & CEPH_PORT_LAST are not needed.
>
> Signed-off-by: Changcheng Liu <changcheng.liu@aliyun.com>
>
> diff --git a/include/linux/ceph/msgr.h b/include/linux/ceph/msgr.h
> index 1c1887206ffa..feff5a2dc33e 100644
> --- a/include/linux/ceph/msgr.h
> +++ b/include/linux/ceph/msgr.h
> @@ -7,15 +7,6 @@
>
> #define CEPH_MON_PORT 6789 /* default monitor port */
>
> -/*
> - * client-side processes will try to bind to ports in this
> - * range, simply for the benefit of tools like nmap or wireshark
> - * that would like to identify the protocol.
> - */
> -#define CEPH_PORT_FIRST 6789
> -#define CEPH_PORT_START 6800 /* non-monitors start here */
> -#define CEPH_PORT_LAST 6900
> -
> /*
> * tcp connection banner. include a protocol version. and adjust
> * whenever the wire protocol changes. try to keep this string length
> --
> 2.25.1
>
Applied.
Thanks,
Ilya
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-11-10 16:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-10 13:52 [PATCH] libceph: remove unused defined macro for port changcheng.liu
2020-11-10 14:00 ` Jeff Layton
2020-11-10 16:10 ` Ilya Dryomov
2020-11-10 16:23 ` Jeff Layton
[not found] <20201110132008.GA90192@nstpc>
2020-11-10 16:51 ` Ilya Dryomov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox