* [PATCH] ceph: disable sending metrics thoroughly when it's disabled
@ 2023-07-20 3:38 xiubli
2023-07-20 3:46 ` Venky Shankar
2023-07-20 10:25 ` Jeff Layton
0 siblings, 2 replies; 3+ messages in thread
From: xiubli @ 2023-07-20 3:38 UTC (permalink / raw)
To: idryomov, ceph-devel; +Cc: jlayton, vshankar, mchangir, Xiubo Li, stable
From: Xiubo Li <xiubli@redhat.com>
Even the 'disable_send_metrics' is true so when the session is
being opened it will always trigger to send the metric for the
first time.
Cc: stable@vger.kernel.org
Signed-off-by: Xiubo Li <xiubli@redhat.com>
---
fs/ceph/metric.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ceph/metric.c b/fs/ceph/metric.c
index cce78d769f55..6d3584f16f9a 100644
--- a/fs/ceph/metric.c
+++ b/fs/ceph/metric.c
@@ -216,7 +216,7 @@ static void metric_delayed_work(struct work_struct *work)
struct ceph_mds_client *mdsc =
container_of(m, struct ceph_mds_client, metric);
- if (mdsc->stopping)
+ if (mdsc->stopping || disable_send_metrics)
return;
if (!m->session || !check_session_state(m->session)) {
--
2.40.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ceph: disable sending metrics thoroughly when it's disabled
2023-07-20 3:38 [PATCH] ceph: disable sending metrics thoroughly when it's disabled xiubli
@ 2023-07-20 3:46 ` Venky Shankar
2023-07-20 10:25 ` Jeff Layton
1 sibling, 0 replies; 3+ messages in thread
From: Venky Shankar @ 2023-07-20 3:46 UTC (permalink / raw)
To: xiubli; +Cc: idryomov, ceph-devel, jlayton, mchangir, stable
On Thu, Jul 20, 2023 at 9:09 AM <xiubli@redhat.com> wrote:
>
> From: Xiubo Li <xiubli@redhat.com>
>
> Even the 'disable_send_metrics' is true so when the session is
> being opened it will always trigger to send the metric for the
> first time.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Xiubo Li <xiubli@redhat.com>
> ---
> fs/ceph/metric.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ceph/metric.c b/fs/ceph/metric.c
> index cce78d769f55..6d3584f16f9a 100644
> --- a/fs/ceph/metric.c
> +++ b/fs/ceph/metric.c
> @@ -216,7 +216,7 @@ static void metric_delayed_work(struct work_struct *work)
> struct ceph_mds_client *mdsc =
> container_of(m, struct ceph_mds_client, metric);
>
> - if (mdsc->stopping)
> + if (mdsc->stopping || disable_send_metrics)
> return;
>
> if (!m->session || !check_session_state(m->session)) {
> --
> 2.40.1
>
LGTM.
Reviewed-by: Venky Shankar <vshankar@redhat.com>
--
Cheers,
Venky
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ceph: disable sending metrics thoroughly when it's disabled
2023-07-20 3:38 [PATCH] ceph: disable sending metrics thoroughly when it's disabled xiubli
2023-07-20 3:46 ` Venky Shankar
@ 2023-07-20 10:25 ` Jeff Layton
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Layton @ 2023-07-20 10:25 UTC (permalink / raw)
To: xiubli, idryomov, ceph-devel; +Cc: vshankar, mchangir, stable
On Thu, 2023-07-20 at 11:38 +0800, xiubli@redhat.com wrote:
> From: Xiubo Li <xiubli@redhat.com>
>
> Even the 'disable_send_metrics' is true so when the session is
> being opened it will always trigger to send the metric for the
> first time.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Xiubo Li <xiubli@redhat.com>
> ---
> fs/ceph/metric.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ceph/metric.c b/fs/ceph/metric.c
> index cce78d769f55..6d3584f16f9a 100644
> --- a/fs/ceph/metric.c
> +++ b/fs/ceph/metric.c
> @@ -216,7 +216,7 @@ static void metric_delayed_work(struct work_struct *work)
> struct ceph_mds_client *mdsc =
> container_of(m, struct ceph_mds_client, metric);
>
> - if (mdsc->stopping)
> + if (mdsc->stopping || disable_send_metrics)
> return;
>
> if (!m->session || !check_session_state(m->session)) {
Reviewed-by: Jeff Layton <jlayton@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-20 10:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-20 3:38 [PATCH] ceph: disable sending metrics thoroughly when it's disabled xiubli
2023-07-20 3:46 ` Venky Shankar
2023-07-20 10:25 ` Jeff Layton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox