public inbox for cgroups@vger.kernel.org
 help / color / mirror / Atom feed
From: Aleksa Sarai <cyphar@cyphar.com>
To: tj@kernel.org
Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
	Aleksa Sarai <cyphar@cyphar.com>
Subject: [PATCH 0/2] cgroup: pids: fix invalid reference semantics
Date: Sun, 23 Aug 2015 23:10:30 +1000	[thread overview]
Message-ID: <1440335432-4202-1-git-send-email-cyphar@cyphar.com> (raw)
In-Reply-To: <CAOviyag1ZOgjtNWmnpfMm=fDgkhDn9UGKoJXy6HLWQMGb-tQAg@mail.gmail.com>

I've discovered a bug in the PIDs cgroup. We aren't properly dealing
with css references (we grab a reference to a css in ->can_attach() and
then drop a reference to a *different* css in ->{cancel_,}attach(). This
is a quick patch I wrote which I believe fixes the problem by getting
cgroup_migrate() to grab a reference before ->can_attach() and once the
attach has failed or succeded.

Aleksa Sarai (2):
  cgroup: get a ref to source csses when migrating
  cgroup: pids: fix invalid get/put usage

 kernel/cgroup.c      | 21 +++++++++++++++++++--
 kernel/cgroup_pids.c | 13 +------------
 2 files changed, 20 insertions(+), 14 deletions(-)

-- 
2.5.0

  reply	other threads:[~2015-08-23 13:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-23 12:24 Bad Reference Semantics in PIDs Controller Aleksa Sarai
2015-08-23 13:10 ` Aleksa Sarai [this message]
     [not found]   ` <1440335432-4202-1-git-send-email-cyphar-gVpy/LI/lHzQT0dZR+AlfA@public.gmane.org>
2015-08-23 13:10     ` [PATCH 1/2] cgroup: get a ref to source csses when migrating Aleksa Sarai
     [not found]       ` <1440335432-4202-2-git-send-email-cyphar-gVpy/LI/lHzQT0dZR+AlfA@public.gmane.org>
2015-08-24 18:45         ` Tejun Heo
     [not found]           ` <20150824184507.GB28944-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2015-08-25  2:00             ` Aleksa Sarai
2015-08-25 18:14               ` Tejun Heo
2015-08-23 13:10   ` [PATCH 2/2] cgroup: pids: fix invalid get/put usage Aleksa Sarai
2015-08-24 19:00     ` Tejun Heo
2015-08-23 13:13   ` [PATCH 0/2] cgroup: pids: fix invalid reference semantics Aleksa Sarai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1440335432-4202-1-git-send-email-cyphar@cyphar.com \
    --to=cyphar@cyphar.com \
    --cc=cgroups@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox