From: Tejun Heo <tj@kernel.org>
To: Aleksa Sarai <cyphar@cyphar.com>
Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org
Subject: Re: [PATCH 1/2] cgroup: get a ref to source csses when migrating
Date: Tue, 25 Aug 2015 14:14:45 -0400 [thread overview]
Message-ID: <20150825181445.GB26785@mtj.duckdns.org> (raw)
In-Reply-To: <CAOviyagYytw2t20c4a-GaFJDRArtF67CHFPN127CRpnzr0Y9kA@mail.gmail.com>
Hello, Aleksa.
On Tue, Aug 25, 2015 at 12:00:54PM +1000, Aleksa Sarai wrote:
> You also mentioned that depending on the css_set's ref being bumped to
> protect the contained csses is "sort of implementation detail. It can
> be implemented in different ways." Which made me think that depending
> on that is not a good idea.
>
> But if it's safe to depend on the cgroup_migrate_add_src() pinning the
> ref on the css_set, I'll drop this patch and fix up the other one
> accordingly.
Yeah, let's go w/o the explicit refcnting.
Thanks.
--
tejun
next prev parent reply other threads:[~2015-08-25 18:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-23 12:24 Bad Reference Semantics in PIDs Controller Aleksa Sarai
2015-08-23 13:10 ` [PATCH 0/2] cgroup: pids: fix invalid reference semantics Aleksa Sarai
[not found] ` <1440335432-4202-1-git-send-email-cyphar-gVpy/LI/lHzQT0dZR+AlfA@public.gmane.org>
2015-08-23 13:10 ` [PATCH 1/2] cgroup: get a ref to source csses when migrating Aleksa Sarai
[not found] ` <1440335432-4202-2-git-send-email-cyphar-gVpy/LI/lHzQT0dZR+AlfA@public.gmane.org>
2015-08-24 18:45 ` Tejun Heo
[not found] ` <20150824184507.GB28944-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2015-08-25 2:00 ` Aleksa Sarai
2015-08-25 18:14 ` Tejun Heo [this message]
2015-08-23 13:10 ` [PATCH 2/2] cgroup: pids: fix invalid get/put usage Aleksa Sarai
2015-08-24 19:00 ` Tejun Heo
2015-08-23 13:13 ` [PATCH 0/2] cgroup: pids: fix invalid reference semantics Aleksa Sarai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150825181445.GB26785@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=cyphar@cyphar.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox