From: Yafang Shao <laoar.shao@gmail.com>
To: tj@kernel.org, guro@fb.com, davem@davemloft.net,
longman@redhat.com, lizefan@huawei.com, hannes@cmpxchg.org
Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
Yafang Shao <laoar.shao@gmail.com>
Subject: [PATCH bpf-next] cgroup: support attaching eBPF programs to net_prio cgroup
Date: Thu, 25 Jan 2018 23:50:25 +0800 [thread overview]
Message-ID: <1516895425-2311-1-git-send-email-laoar.shao@gmail.com> (raw)
If net_prio is used, we could also use eBPF programs to attach it,
because the net_prio cgroup could be got with prioidx in struct
sock_cgroup_data.
Hence it should not only be limited to cgroup2.
Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
---
include/linux/cgroup.h | 16 +++++++++++++++-
kernel/cgroup/cgroup.c | 6 +-----
2 files changed, 16 insertions(+), 6 deletions(-)
diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h
index 473e0c0..c0cb46b 100644
--- a/include/linux/cgroup.h
+++ b/include/linux/cgroup.h
@@ -772,8 +772,22 @@ static inline struct cgroup *sock_cgroup_ptr(struct sock_cgroup_data *skcd)
*/
v = READ_ONCE(skcd->val);
- if (v & 1)
+ /* either net_prio or net_cls or both being used. */
+ if (v & 1) {
+ if (skcd->prioidx != 1) {
+ struct cgroup_subsys_state *css;
+ struct cgroup *cg;
+
+ rcu_read_lock();
+ css = css_from_id(skcd->prioidx, &net_prio_cgrp_subsys);
+ cg = css->cgroup;
+ rcu_read_unlock();
+
+ return cg;
+ }
+
return &cgrp_dfl_root.cgrp;
+ }
return (struct cgroup *)(unsigned long)v ?: &cgrp_dfl_root.cgrp;
#else
diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
index 7e4c445..59610f5 100644
--- a/kernel/cgroup/cgroup.c
+++ b/kernel/cgroup/cgroup.c
@@ -5735,7 +5735,7 @@ struct cgroup *cgroup_get_from_path(const char *path)
/**
* cgroup_get_from_fd - get a cgroup pointer from a fd
- * @fd: fd obtained by open(cgroup2_dir)
+ * @fd: fd obtained by open(cgroup2_dir or net_prio_dir)
*
* Find the cgroup from a fd which should be obtained
* by opening a cgroup directory. Returns a pointer to the
@@ -5758,10 +5758,6 @@ struct cgroup *cgroup_get_from_fd(int fd)
return ERR_CAST(css);
cgrp = css->cgroup;
- if (!cgroup_on_dfl(cgrp)) {
- cgroup_put(cgrp);
- return ERR_PTR(-EBADF);
- }
return cgrp;
}
--
1.8.3.1
next reply other threads:[~2018-01-25 15:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-25 15:50 Yafang Shao [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-01-25 15:38 [PATCH bpf-next] cgroup: support attaching eBPF programs to net_prio cgroup Yafang Shao
2018-01-25 15:50 ` Tejun Heo
2018-01-25 15:56 ` Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516895425-2311-1-git-send-email-laoar.shao@gmail.com \
--to=laoar.shao@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=longman@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox