From: Tejun Heo <tj@kernel.org>
To: Yafang Shao <laoar.shao@gmail.com>
Cc: guro@fb.com, davem@davemloft.net, longman@redhat.com,
lizefan@huawei.com, hannes@cmpxchg.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf-next] cgroup: support attaching eBPF programs to net_prio cgroup
Date: Thu, 25 Jan 2018 07:50:29 -0800 [thread overview]
Message-ID: <20180125155029.GG17457@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <1516894728-2061-1-git-send-email-laoar.shao@gmail.com>
On Thu, Jan 25, 2018 at 11:38:48PM +0800, Yafang Shao wrote:
> If net_prio is used, we could also use eBPF programs to attach it,
> because the net_prio cgroup could be got with prioidx in struct
> sock_cgroup_data.
> Hence it should not only be limited to cgroup2.
I really don't wanna do this. This comes with all sorts of reverse
lookup and naming issues. In addition, cgroup1 and 2 aren't mutually
exclusive. If the use case is on cgroup1 and wants to use cgroup bpf
programs, just replicate the cgroup2 hierarchy for bpf. Hierarchy
replication across different controllers is how most use cgroup1 after
all. With recent versions of systemd which defaults to using cgroup2
for process management, you get the replication for free too.
Thanks.
--
tejun
next prev parent reply other threads:[~2018-01-25 15:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-25 15:38 [PATCH bpf-next] cgroup: support attaching eBPF programs to net_prio cgroup Yafang Shao
2018-01-25 15:50 ` Tejun Heo [this message]
2018-01-25 15:56 ` Yafang Shao
-- strict thread matches above, loose matches on Subject: below --
2018-01-25 15:50 Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180125155029.GG17457@devbig577.frc2.facebook.com \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=laoar.shao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=longman@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox