[patch] cgroup: move assignement out of condition in cgroup_attach_proc()

[patch] cgroup: move assignement out of condition in cgroup_attach_proc()

[Dan Carpenter]

Gcc complains about this: "kernel/cgroup.c:2179:4: warning: suggest
parentheses around assignment used as truth value [-Wparentheses]"

Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
---
I feel like the original developer may have left the parens out on
deliberately to stop checkpatch.pl complaining about long lines.  I so
much hate the long line warning...

diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index cb3c131..6a057fe 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -2175,9 +2175,12 @@ static int cgroup_attach_proc(struct cgroup *cgrp, struct task_struct *leader)
 		oldcg = tc->task->cgroups;
 
 		/* if we don't already have it in the list get a new one */
-		if (!css_set_check_fetched(cgrp, tc->task, oldcg, &newcg_list))
-			if (retval = css_set_prefetch(cgrp, oldcg, &newcg_list))
+		if (!css_set_check_fetched(cgrp, tc->task, oldcg,
+					&newcg_list)) {
+			retval = css_set_prefetch(cgrp, oldcg, &newcg_list);
+			if (retval)
 				goto out_list_teardown;
+		}
 	}
 
 	/*

Re: [patch] cgroup: move assignement out of condition in cgroup_attach_proc()

[Tejun Heo]

On Wed, Jan 04, 2012 at 10:24:29AM +0300, Dan Carpenter wrote:
> Gcc complains about this: "kernel/cgroup.c:2179:4: warning: suggest
> parentheses around assignment used as truth value [-Wparentheses]"
> 
> Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>

Applied to cgroup/for-3.3.  Li, applied w/o your ack as it's trivial.

Thanks.

-- 
tejun