From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Roman Gushchin <guro-b10kYP2dOMg@public.gmane.org>
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Zefan Li <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
Waiman Long <longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
kernel-team-b10kYP2dOMg@public.gmane.org,
linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [RFC 2/4] cgroup: implement hierarchy limits
Date: Wed, 2 Aug 2017 11:44:17 -0700 [thread overview]
Message-ID: <20170802184416.GK2311718@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <20170802165532.22277-3-guro-b10kYP2dOMg@public.gmane.org>
Hello, Roman.
Generally looks good to me. One minor nit.
On Wed, Aug 02, 2017 at 05:55:30PM +0100, Roman Gushchin wrote:
> +static ssize_t cgroup_max_descendants_write(struct kernfs_open_file *of,
> + char *buf, size_t nbytes, loff_t off)
> +{
> + struct cgroup *cgrp;
> + int descendants;
> + ssize_t ret;
> +
> + buf = strstrip(buf);
> + if (!strcmp(buf, "max")) {
> + descendants = INT_MAX;
> + } else {
> + ret = kstrtouint(buf, 0, &descendants);
^^^^^^^^^^^
shouldn't this be kstrtoint?
Thanks.
--
tejun
next prev parent reply other threads:[~2017-08-02 18:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 16:55 [RFC 0/4] cgroup hierarchy controls and stats Roman Gushchin
2017-08-02 16:55 ` [RFC 1/4] cgroup: keep track of number of descent cgroups Roman Gushchin
2017-08-02 16:55 ` [RFC 2/4] cgroup: implement hierarchy limits Roman Gushchin
[not found] ` <20170802165532.22277-3-guro-b10kYP2dOMg@public.gmane.org>
2017-08-02 18:44 ` Tejun Heo [this message]
2017-08-02 18:55 ` Roman Gushchin
2017-08-02 16:55 ` [RFC 3/4] cgroup: add cgroup.stat interface with basic hierarchy stats Roman Gushchin
2017-08-02 16:55 ` [RFC 4/4] cgroup: re-use the parent pointer in cgroup_destroy_locked() Roman Gushchin
2017-08-02 18:50 ` Tejun Heo
[not found] ` <20170802165532.22277-1-guro-b10kYP2dOMg@public.gmane.org>
2017-08-02 19:06 ` [RFC 0/4] cgroup hierarchy controls and stats Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170802184416.GK2311718@devbig577.frc2.facebook.com \
--to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=guro-b10kYP2dOMg@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=kernel-team-b10kYP2dOMg@public.gmane.org \
--cc=linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox