From: Tejun Heo <tj@kernel.org>
To: Roman Gushchin <guro@fb.com>
Cc: cgroups@vger.kernel.org, Zefan Li <lizefan@huawei.com>,
Waiman Long <longman@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
kernel-team@fb.com, linux-kernel@vger.kernel.org
Subject: Re: [RFC 4/4] cgroup: re-use the parent pointer in cgroup_destroy_locked()
Date: Wed, 2 Aug 2017 11:50:24 -0700 [thread overview]
Message-ID: <20170802185023.GL2311718@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <20170802165532.22277-5-guro@fb.com>
On Wed, Aug 02, 2017 at 05:55:32PM +0100, Roman Gushchin wrote:
> As we already have a pointer to the parent cgroup in
> cgroup_destroy_locked(), we don't need to calculate it again
> to pass as an argument for cgroup1_check_for_release().
Except for the minor nit earlier, everything in the series looks good
to me.
Thanks.
--
tejun
next prev parent reply other threads:[~2017-08-02 18:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 16:55 [RFC 0/4] cgroup hierarchy controls and stats Roman Gushchin
2017-08-02 16:55 ` [RFC 1/4] cgroup: keep track of number of descent cgroups Roman Gushchin
2017-08-02 16:55 ` [RFC 2/4] cgroup: implement hierarchy limits Roman Gushchin
[not found] ` <20170802165532.22277-3-guro-b10kYP2dOMg@public.gmane.org>
2017-08-02 18:44 ` Tejun Heo
2017-08-02 18:55 ` Roman Gushchin
2017-08-02 16:55 ` [RFC 3/4] cgroup: add cgroup.stat interface with basic hierarchy stats Roman Gushchin
2017-08-02 16:55 ` [RFC 4/4] cgroup: re-use the parent pointer in cgroup_destroy_locked() Roman Gushchin
2017-08-02 18:50 ` Tejun Heo [this message]
[not found] ` <20170802165532.22277-1-guro-b10kYP2dOMg@public.gmane.org>
2017-08-02 19:06 ` [RFC 0/4] cgroup hierarchy controls and stats Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170802185023.GL2311718@devbig577.frc2.facebook.com \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=longman@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox