From: Jing Wu <realwujing@gmail.com>
To: "Paul E. McKenney" <paulmck@kernel.org>,
Frederic Weisbecker <frederic@kernel.org>
Cc: Jing Wu <realwujing@gmail.com>, Thomas Gleixner <tglx@kernel.org>,
Waiman Long <longman@redhat.com>,
linux-kernel@vger.kernel.org, rcu@vger.kernel.org,
cgroups@vger.kernel.org, Qiliang Yuan <yuanql9@chinatelecom.cn>
Subject: Re: [PATCH-next 00/23] cgroup/cpuset: Enable runtime update of nohz_full and managed_irq CPUs
Date: Fri, 3 Jul 2026 14:11:42 +0800 [thread overview]
Message-ID: <20260703061143.1658605-1-realwujing@gmail.com> (raw)
In-Reply-To: <4b9bfc1b-2724-4507-b2b2-81d71eb79841@paulmck-laptop>
On Thu, Jul 02 2026 at 16:07, Paul E. McKenney wrote:
> wouldn't it work better to just leave all CPUs in RCU-callbacks-offloaded
> state? Then you can adjust the nohz_full state of arbitrary CPUs without
> messing with RCU.
[...]
> a continuous stream of race-condition bugs inspired the current state,
> which is to allow this state to change only for offline CPUs.
Thanks Paul. That is appealing, and we would much rather not wade into
the online offload-switching races you describe.
Let me lay out the one tension it creates on our side and ask how you and
Frederic would like it resolved.
DHM's aim is to enable kernel-noise isolation purely at runtime, on
machines that did not pass nohz_full= / rcu_nocbs= at boot. "Leave all
CPUs offloaded" needs the candidate CPUs to be in rcu_nocb_mask, which is
only populated at boot. So the RCU part seems to come down to two options:
(a) Accept a boot hint: require rcu_nocbs= (or nohz_full=) to cover the
set of CPUs that may later be isolated. RCU is then never touched at
runtime, exactly as you suggest. tick / timer / managed_irq /
watchdog stay fully runtime-adjustable, so the "no boot parameter"
property holds for everything except RCU offloading.
(b) Change the offload state at runtime with no boot hint, which is
precisely the online-switching problem you and Frederic hit, and what
Thomas's lightweight-offloaded + CPUHP_AP_RCU_SYNC sketch would need
to make cheap and race-free.
We would lean towards (a) as the pragmatic first step: it keeps RCU out of
the runtime path entirely, per your recommendation, and only asks the admin
who wants runtime RCU-noise isolation to declare the candidate CPUs at boot.
(b) / Thomas's mechanism could be a separate, later effort if a truly
boot-parameter-free RCU story turns out to be wanted.
Does scoping the RCU part to (a) sound acceptable to you and Frederic? If
so, we will drop runtime nocb toggling from DHM entirely and just document
the rcu_nocbs= expectation, leaving the other housekeeping types runtime
adjustable.
Thanks,
Jing Wu
Qiliang Yuan
prev parent reply other threads:[~2026-07-03 6:11 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 3:03 [PATCH-next 00/23] cgroup/cpuset: Enable runtime update of nohz_full and managed_irq CPUs Waiman Long
2026-04-21 3:03 ` [PATCH 01/23] sched/isolation: Add HK_TYPE_KERNEL_NOISE_BOOT & HK_TYPE_MANAGED_IRQ_BOOT Waiman Long
2026-04-21 3:03 ` [PATCH 02/23] sched/isolation: Enhance housekeeping_update() to support updating more than one HK cpumask Waiman Long
2026-04-22 6:39 ` Chen Ridong
2026-04-21 3:03 ` [PATCH 03/23] tick/nohz: Make nohz_full parameter optional Waiman Long
2026-04-21 8:32 ` Thomas Gleixner
2026-04-21 14:14 ` Waiman Long
2026-04-24 15:57 ` Frederic Weisbecker
2026-04-21 3:03 ` [PATCH 04/23] tick/nohz: Allow runtime changes in full dynticks CPUs Waiman Long
2026-04-21 8:50 ` Thomas Gleixner
2026-04-21 14:24 ` Waiman Long
2026-05-13 13:04 ` Frederic Weisbecker
2026-04-21 3:03 ` [PATCH 05/23] tick: Pass timer tick job to an online HK CPU in tick_cpu_dying() Waiman Long
2026-04-21 8:55 ` Thomas Gleixner
2026-04-21 14:22 ` Waiman Long
2026-04-21 3:03 ` [PATCH 06/23] rcu/nocbs: Allow runtime changes in RCU NOCBS cpumask Waiman Long
2026-04-21 3:03 ` [PATCH 07/23] watchdog: Sync up with runtime change of isolated CPUs Waiman Long
2026-04-21 3:03 ` [PATCH 08/23] arm64: topology: Use RCU to protect access to HK_TYPE_TICK cpumask Waiman Long
2026-04-22 9:34 ` Chen Ridong
2026-05-13 16:19 ` Frederic Weisbecker
2026-04-21 3:03 ` [PATCH 09/23] workqueue: Use RCU to protect access of HK_TYPE_TIMER cpumask Waiman Long
2026-04-21 3:03 ` [PATCH 10/23] cpu: " Waiman Long
2026-04-21 8:57 ` Thomas Gleixner
2026-04-21 14:25 ` Waiman Long
2026-04-21 3:03 ` [PATCH 11/23] hrtimer: " Waiman Long
2026-04-21 8:59 ` Thomas Gleixner
2026-04-21 3:03 ` [PATCH 12/23] net: Use boot time housekeeping cpumask settings for now Waiman Long
2026-04-21 3:03 ` [PATCH 13/23] sched/core: Use RCU to protect access of HK_TYPE_KERNEL_NOISE cpumask Waiman Long
2026-04-21 3:03 ` [PATCH 14/23] hwmon/coretemp: Use RCU to protect access of HK_TYPE_MISC cpumask Waiman Long
2026-04-21 3:03 ` [PATCH 15/23] Drivers: hv: Use RCU to protect access of HK_TYPE_MANAGED_IRQ cpumask Waiman Long
2026-04-21 3:03 ` [PATCH 16/23] genirq/cpuhotplug: " Waiman Long
2026-04-21 9:02 ` Thomas Gleixner
2026-04-21 14:29 ` Waiman Long
2026-04-21 3:03 ` [PATCH 17/23] sched/isolation: Extend housekeeping_dereference_check() to cover changes in nohz_full or manged_irqs cpumasks Waiman Long
2026-04-21 3:03 ` [PATCH 18/23] cpu/hotplug: Add a new cpuhp_offline_cb() API Waiman Long
2026-04-21 16:17 ` Thomas Gleixner
2026-04-21 17:29 ` Waiman Long
2026-04-21 18:43 ` Thomas Gleixner
2026-04-21 3:03 ` [PATCH 19/23] cgroup/cpuset: Improve check for calling housekeeping_update() Waiman Long
2026-04-23 1:10 ` Chen Ridong
2026-04-24 18:32 ` Waiman Long
2026-04-21 3:03 ` [PATCH 20/23] cgroup/cpuset: Enable runtime update of HK_TYPE_{KERNEL_NOISE,MANAGED_IRQ} cpumasks Waiman Long
2026-04-21 3:03 ` [PATCH 21/23] cgroup/cpuset: Limit the side effect of using CPU hotplug on isolated partition Waiman Long
2026-04-21 3:03 ` [PATCH 22/23] cgroup/cpuset: Prevent offline_disabled CPUs from being used in " Waiman Long
2026-04-21 3:03 ` [PATCH 23/23] cgroup/cpuset: Documentation and kselftest updates Waiman Long
2026-06-24 6:34 ` [PATCH-next 00/23] cgroup/cpuset: Enable runtime update of nohz_full and managed_irq CPUs Jing Wu
2026-06-25 5:27 ` Waiman Long
2026-07-01 14:22 ` Frederic Weisbecker
2026-07-01 18:56 ` Waiman Long
2026-07-02 3:39 ` Jing Wu
2026-07-02 15:00 ` Thomas Gleixner
2026-07-02 23:07 ` Paul E. McKenney
2026-07-03 6:11 ` Jing Wu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260703061143.1658605-1-realwujing@gmail.com \
--to=realwujing@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=tglx@kernel.org \
--cc=yuanql9@chinatelecom.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox