[PATCH] blk-throttle: remove dead field last_check_time from throtl_grp

[PATCH] blk-throttle: remove dead field last_check_time from throtl_grp

[Tao Cui]

From: Tao Cui <cuitao@kylinos.cn>

The last_check_time field in throtl_grp was used by the
CONFIG_BLK_DEV_THROTTLING_LOW mechanism (in throtl_upgrade_check() and
the downgrade logic) to timestamp the last upgrade/downgrade check.

Commit bf20ab538c81 ("blk-throttle: remove CONFIG_BLK_DEV_THROTTLING_LOW")
removed all five of its uses in blk-throttle.c and the surrounding LOW
fields (latency_target, last_finish_time, checked_last_finish_time,
avg_idletime, idletime_threshold, bio_cnt, bad_bio_cnt,
bio_cnt_reset_time), but missed the field definition itself.

It has been a dead field since then: zero references in blk-throttle.c
and the whole tree.  Remove it.

Signed-off-by: Tao Cui <cuitao@kylinos.cn>
---
 block/blk-throttle.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/block/blk-throttle.h b/block/blk-throttle.h
index 9d7a42c039a1..1b5775771e07 100644
--- a/block/blk-throttle.h
+++ b/block/blk-throttle.h
@@ -120,8 +120,6 @@ struct throtl_grp {
 	int64_t bytes_disp[2];
 	int io_disp[2];
 
-	unsigned long last_check_time;
-
 	/* When did we start a new slice */
 	unsigned long slice_start[2];
 	unsigned long slice_end[2];
-- 
2.43.0

Re: [PATCH] blk-throttle: remove dead field last_check_time from throtl_grp

[Tang Yizhou]

On 17/7/26 1:48 pm, Tao Cui wrote:
> From: Tao Cui <cuitao@kylinos.cn>
> 
> The last_check_time field in throtl_grp was used by the
> CONFIG_BLK_DEV_THROTTLING_LOW mechanism (in throtl_upgrade_check() and
> the downgrade logic) to timestamp the last upgrade/downgrade check.
> 
> Commit bf20ab538c81 ("blk-throttle: remove CONFIG_BLK_DEV_THROTTLING_LOW")
> removed all five of its uses in blk-throttle.c and the surrounding LOW
> fields (latency_target, last_finish_time, checked_last_finish_time,
> avg_idletime, idletime_threshold, bio_cnt, bad_bio_cnt,
> bio_cnt_reset_time), but missed the field definition itself.
> 
> It has been a dead field since then: zero references in blk-throttle.c
> and the whole tree.  Remove it.
> 
> Signed-off-by: Tao Cui <cuitao@kylinos.cn>
> ---
>  block/blk-throttle.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/block/blk-throttle.h b/block/blk-throttle.h
> index 9d7a42c039a1..1b5775771e07 100644
> --- a/block/blk-throttle.h
> +++ b/block/blk-throttle.h
> @@ -120,8 +120,6 @@ struct throtl_grp {
>  	int64_t bytes_disp[2];
>  	int io_disp[2];
>  
> -	unsigned long last_check_time;
> -
>  	/* When did we start a new slice */
>  	unsigned long slice_start[2];
>  	unsigned long slice_end[2];

Reviewed-by: Tang Yizhou <yizhou.tang@shopee.com>

-- 
Best Regards,
Yi