Linux cgroups development
 help / color / mirror / Atom feed
From: "Reshetova, Elena" <elena.reshetova-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
	Peter Zijlstra <peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Cc: "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-audit-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
	<linux-audit-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	"linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org"
	<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
	"viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org"
	<viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org>,
	"tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
	<tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
	<mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	"hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org"
	<hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
	"lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org"
	<lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
	"acme-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
	<acme-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"alexander.shishkin-VuQAYsv1563Yd54FQh9/CA@public.gmane.org"
	<alexander.shishkin-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	"eparis-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
	<eparis-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	"akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org"
	<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
	"arnd-r2nGTMty4D4@public.gmane.org"
	<arnd-r2nGTMty4D4@public.gmane.org>,
	"luto-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" <lut>
Subject: RE: [PATCH 14/15] kernel: convert futex_pi_state.refcount from atomic_t to refcount_t
Date: Fri, 7 Jul 2017 10:27:27 +0000	[thread overview]
Message-ID: <2236FBA76BA1254E88B949DDB74E612B6FF21DCD@IRSMSX102.ger.corp.intel.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1707071149500.1871@nanos>

> On Fri, 7 Jul 2017, Peter Zijlstra wrote:
> 
> > On Fri, Jul 07, 2017 at 12:04:28PM +0300, Elena Reshetova wrote:
> > > refcount_t type and corresponding API should be
> > > used instead of atomic_t when the variable is used as
> > > a reference counter. This allows to avoid accidental
> > > refcounter overflows that might lead to use-after-free
> > > situations.
> > >
> > > Signed-off-by: Elena Reshetova <elena.reshetova-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > > Signed-off-by: Hans Liljestrand <ishkamiel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > > Signed-off-by: Kees Cook <keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> > > Signed-off-by: David Windsor <dwindsor-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >
> > I'll let tglx comment on the SoB chain, I know he likes those :-) You
> > did Cc him right, seeing how he's the maintainer of this stuff..
> 
> Right, that SOB chain is crap. It suggests that the patch was written by
> Elena and then carried on by Hans, handed over to Kees and from there to
> David. And now it's resent by Elena. Circular dependencies or what?

I will fix SOB on all patches and resend. 

Best Regards,
Elena

  reply	other threads:[~2017-07-07 10:27 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-07  9:04 [PATCH 00/15] v2 kernel core refcount conversions Elena Reshetova
2017-07-07  9:04 ` [PATCH 01/15] kernel: convert sighand_struct.count from atomic_t to refcount_t Elena Reshetova
2017-07-07  9:04 ` [PATCH 02/15] kernel: convert signal_struct.sigcnt " Elena Reshetova
     [not found] ` <1499418269-3686-1-git-send-email-elena.reshetova-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-07-07  9:04   ` [PATCH 03/15] kernel: convert user_struct.__count " Elena Reshetova
2017-07-07  9:04   ` [PATCH 04/15] kernel: convert task_struct.usage " Elena Reshetova
2017-07-07  9:04 ` [PATCH 05/15] kernel: convert task_struct.stack_refcount " Elena Reshetova
2017-07-07  9:04 ` [PATCH 06/15] kernel: convert perf_event_context.refcount " Elena Reshetova
2017-07-07  9:27   ` Peter Zijlstra
     [not found]     ` <20170707092745.3bxg3omd5pbly6rd-Nxj+rRp3nVydTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org>
2017-07-07 10:18       ` Reshetova, Elena
2017-07-07  9:04 ` [PATCH 07/15] kernel: convert ring_buffer.refcount " Elena Reshetova
2017-07-07  9:04 ` [PATCH 08/15] kernel: convert ring_buffer.aux_refcount " Elena Reshetova
2017-07-07  9:04 ` [PATCH 09/15] kernel: convert uprobe.ref " Elena Reshetova
2017-07-07  9:04 ` [PATCH 10/15] kernel: convert nsproxy.count " Elena Reshetova
2017-07-07  9:04 ` [PATCH 11/15] kernel: convert group_info.usage " Elena Reshetova
2017-07-07  9:04 ` [PATCH 12/15] kernel: convert cred.usage " Elena Reshetova
2017-07-07  9:04 ` [PATCH 13/15] kernel: convert numa_group.refcount " Elena Reshetova
2017-07-07  9:29   ` Peter Zijlstra
     [not found]     ` <20170707092942.r2juhqprjo4petib-Nxj+rRp3nVydTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org>
2017-07-07 10:19       ` Reshetova, Elena
2017-07-07  9:04 ` [PATCH 14/15] kernel: convert futex_pi_state.refcount " Elena Reshetova
2017-07-07  9:26   ` Peter Zijlstra
2017-07-07  9:52     ` Thomas Gleixner
2017-07-07 10:27       ` Reshetova, Elena [this message]
2017-07-07 10:35         ` Ingo Molnar
2017-07-07 13:22           ` gregkh
2017-07-07 10:24     ` Reshetova, Elena
     [not found]       ` <2236FBA76BA1254E88B949DDB74E612B6FF21DBE-kPTMFJFq+rFP9JyJpTNKArfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2017-07-07 11:11         ` Peter Zijlstra
2017-07-07  9:04 ` [PATCH 15/15] kernel: convert kcov.refcount " Elena Reshetova
  -- strict thread matches above, loose matches on Subject: below --
2017-07-17 10:43 [PATCH 00/15] v3 kernel core pieces refcount conversions Elena Reshetova
2017-07-17 10:43 ` [PATCH 14/15] kernel: convert futex_pi_state.refcount from atomic_t to refcount_t Elena Reshetova
2017-07-17 14:25   ` Thomas Gleixner
2017-07-17 16:51     ` Reshetova, Elena
2017-07-17 17:57       ` Thomas Gleixner
2017-07-18  9:39         ` Reshetova, Elena

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2236FBA76BA1254E88B949DDB74E612B6FF21DCD@IRSMSX102.ger.corp.intel.com \
    --to=elena.reshetova-ral2jqcrhueavxtiumwx3w@public.gmane.org \
    --cc=acme-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=alexander.shishkin-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=arnd-r2nGTMty4D4@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=eparis-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
    --cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
    --cc=linux-audit-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
    --cc=mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
    --cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox