From: Thomas Gleixner <tglx@linutronix.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Elena Reshetova <elena.reshetova@intel.com>,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
linux-audit@redhat.com, linux-fsdevel@vger.kernel.org,
gregkh@linuxfoundation.org, viro@zeniv.linux.org.uk,
tj@kernel.org, mingo@redhat.com, hannes@cmpxchg.org,
lizefan@huawei.com, acme@kernel.org,
alexander.shishkin@linux.intel.com, eparis@redhat.com,
akpm@linux-foundation.org, arnd@arndb.de, luto@kernel.org,
keescook@chromium.org, Hans Liljestrand <ishkamiel@gmail.com>,
David Windsor <dwindsor@gmail.com>
Subject: Re: [PATCH 14/15] kernel: convert futex_pi_state.refcount from atomic_t to refcount_t
Date: Fri, 7 Jul 2017 11:52:57 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1707071149500.1871@nanos> (raw)
In-Reply-To: <20170707092603.rmt4ne4c75k5qg56@hirez.programming.kicks-ass.net>
On Fri, 7 Jul 2017, Peter Zijlstra wrote:
> On Fri, Jul 07, 2017 at 12:04:28PM +0300, Elena Reshetova wrote:
> > refcount_t type and corresponding API should be
> > used instead of atomic_t when the variable is used as
> > a reference counter. This allows to avoid accidental
> > refcounter overflows that might lead to use-after-free
> > situations.
> >
> > Signed-off-by: Elena Reshetova <elena.reshetova@intel.com>
> > Signed-off-by: Hans Liljestrand <ishkamiel@gmail.com>
> > Signed-off-by: Kees Cook <keescook@chromium.org>
> > Signed-off-by: David Windsor <dwindsor@gmail.com>
>
> I'll let tglx comment on the SoB chain, I know he likes those :-) You
> did Cc him right, seeing how he's the maintainer of this stuff..
Right, that SOB chain is crap. It suggests that the patch was written by
Elena and then carried on by Hans, handed over to Kees and from there to
David. And now it's resent by Elena. Circular dependencies or what?
Thanks,
tglx
next prev parent reply other threads:[~2017-07-07 9:52 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-07 9:04 [PATCH 00/15] v2 kernel core refcount conversions Elena Reshetova
2017-07-07 9:04 ` [PATCH 01/15] kernel: convert sighand_struct.count from atomic_t to refcount_t Elena Reshetova
2017-07-07 9:04 ` [PATCH 02/15] kernel: convert signal_struct.sigcnt " Elena Reshetova
[not found] ` <1499418269-3686-1-git-send-email-elena.reshetova-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-07-07 9:04 ` [PATCH 03/15] kernel: convert user_struct.__count " Elena Reshetova
2017-07-07 9:04 ` [PATCH 04/15] kernel: convert task_struct.usage " Elena Reshetova
2017-07-07 9:04 ` [PATCH 05/15] kernel: convert task_struct.stack_refcount " Elena Reshetova
2017-07-07 9:04 ` [PATCH 06/15] kernel: convert perf_event_context.refcount " Elena Reshetova
2017-07-07 9:27 ` Peter Zijlstra
[not found] ` <20170707092745.3bxg3omd5pbly6rd-Nxj+rRp3nVydTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org>
2017-07-07 10:18 ` Reshetova, Elena
2017-07-07 9:04 ` [PATCH 07/15] kernel: convert ring_buffer.refcount " Elena Reshetova
2017-07-07 9:04 ` [PATCH 08/15] kernel: convert ring_buffer.aux_refcount " Elena Reshetova
2017-07-07 9:04 ` [PATCH 09/15] kernel: convert uprobe.ref " Elena Reshetova
2017-07-07 9:04 ` [PATCH 10/15] kernel: convert nsproxy.count " Elena Reshetova
2017-07-07 9:04 ` [PATCH 11/15] kernel: convert group_info.usage " Elena Reshetova
2017-07-07 9:04 ` [PATCH 12/15] kernel: convert cred.usage " Elena Reshetova
2017-07-07 9:04 ` [PATCH 13/15] kernel: convert numa_group.refcount " Elena Reshetova
2017-07-07 9:29 ` Peter Zijlstra
[not found] ` <20170707092942.r2juhqprjo4petib-Nxj+rRp3nVydTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org>
2017-07-07 10:19 ` Reshetova, Elena
2017-07-07 9:04 ` [PATCH 14/15] kernel: convert futex_pi_state.refcount " Elena Reshetova
2017-07-07 9:26 ` Peter Zijlstra
2017-07-07 9:52 ` Thomas Gleixner [this message]
2017-07-07 10:27 ` Reshetova, Elena
2017-07-07 10:35 ` Ingo Molnar
2017-07-07 13:22 ` gregkh
2017-07-07 10:24 ` Reshetova, Elena
[not found] ` <2236FBA76BA1254E88B949DDB74E612B6FF21DBE-kPTMFJFq+rFP9JyJpTNKArfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2017-07-07 11:11 ` Peter Zijlstra
2017-07-07 9:04 ` [PATCH 15/15] kernel: convert kcov.refcount " Elena Reshetova
-- strict thread matches above, loose matches on Subject: below --
2017-07-17 10:43 [PATCH 00/15] v3 kernel core pieces refcount conversions Elena Reshetova
2017-07-17 10:43 ` [PATCH 14/15] kernel: convert futex_pi_state.refcount from atomic_t to refcount_t Elena Reshetova
2017-07-17 14:25 ` Thomas Gleixner
2017-07-17 16:51 ` Reshetova, Elena
2017-07-17 17:57 ` Thomas Gleixner
2017-07-18 9:39 ` Reshetova, Elena
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1707071149500.1871@nanos \
--to=tglx@linutronix.de \
--cc=acme@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=arnd@arndb.de \
--cc=cgroups@vger.kernel.org \
--cc=dwindsor@gmail.com \
--cc=elena.reshetova@intel.com \
--cc=eparis@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=ishkamiel@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-audit@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tj@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox