From: Ridong Chen <ridong.chen@linux.dev>
To: Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Shakeel Butt <shakeel.butt@linux.dev>,
Andrew Morton <akpm@linux-foundation.org>,
Chris Li <chrisl@kernel.org>, Kairui Song <kasong@tencent.com>
Cc: Muchun Song <muchun.song@linux.dev>,
Kemeng Shi <shikemeng@huaweicloud.com>,
Nhat Pham <nphamcs@gmail.com>, Baoquan He <baoquan.he@linux.dev>,
Barry Song <baohua@kernel.org>,
Youngjun Park <youngjun.park@lge.com>,
David Hildenbrand <david@kernel.org>,
Qi Zheng <qi.zheng@linux.dev>, Lorenzo Stoakes <ljs@kernel.org>,
Axel Rasmussen <axelrasmussen@google.com>,
Yuanchu Xie <yuanchu@google.com>, Wei Xu <weixugc@google.com>,
Davidlohr Bueso <dave@stgolabs.net>,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Ridong <chenridong@xiaomi.com>
Subject: Re: [PATCH v2 0/2] mm: fix node reclaim swappiness handling
Date: Thu, 23 Jul 2026 09:13:27 +0800 [thread overview]
Message-ID: <56fcb7bf-5e0b-46ad-84e5-12b2d00b7a34@linux.dev> (raw)
In-Reply-To: <20260716031729.1064007-1-ridong.chen@linux.dev>
On 7/16/2026 11:17 AM, Ridong wrote:
> From: Ridong <chenridong@xiaomi.com>
>
> The per-node proactive reclaim interface
> (/sys/devices/system/node/nodeX/reclaim) accepts a swappiness parameter,
> but it is silently ignored when CONFIG_MEMCG is disabled. The root cause
> is that sc_swappiness() has separate implementations for CONFIG_MEMCG and
> !CONFIG_MEMCG, and the latter never checks proactive_swappiness.
>
> Patch 1 moves mem_cgroup_swappiness() and vm_swappiness out of the public
> include/linux/swap.h into the mm-private mm/swap.h, and makes the helper
> handle both CONFIG_MEMCG and !CONFIG_MEMCG in a single inline function.
> This is a prerequisite for unifying sc_swappiness().
>
> Patch 2 consolidates sc_swappiness() into a single definition that works
> regardless of CONFIG_MEMCG, fixing the node reclaim swappiness bug.
>
> ---
>
> v1 -> v2:
> - Move mem_cgroup_swappiness() and vm_swappiness to mm/swap.h instead of
> include/linux/memcontrol.h. Suggested by Barry Song.
> - Correct fix tag for patch 2.
>
> v1: https://lore.kernel.org/all/20260711091157.306070-1-ridong.chen@linux.dev/
>
> Ridong Chen (2):
> memcg: move mem_cgroup_swappiness and vm_swappiness to mm/swap.h
> mm: vmscan: fix node reclaim ignoring swappiness parameter
>
> include/linux/memcontrol.h | 4 ++--
> include/linux/swap.h | 19 -------------------
> mm/memcontrol.c | 4 ++--
> mm/swap.h | 20 ++++++++++++++++++++
> mm/vmscan.c | 19 +++++++------------
> 5 files changed, 31 insertions(+), 35 deletions(-)
>
Hello all,
Can this series be applied?
Just a reminder in case this gets buried.
--
Best regards
Ridong
next prev parent reply other threads:[~2026-07-23 1:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-16 3:17 [PATCH v2 0/2] mm: fix node reclaim swappiness handling Ridong
2026-07-16 3:17 ` [PATCH v2 1/2] memcg: move mem_cgroup_swappiness and vm_swappiness to mm/swap.h Ridong
2026-07-16 6:06 ` Tao Cui
2026-07-16 7:14 ` Barry Song
2026-07-23 1:59 ` Johannes Weiner
2026-07-23 2:14 ` Ridong Chen
2026-07-16 3:17 ` [PATCH v2 2/2] mm: vmscan: fix node reclaim ignoring swappiness parameter Ridong
2026-07-16 3:25 ` Qi Zheng
2026-07-16 3:58 ` Qi Zheng
2026-07-16 8:21 ` Ridong Chen
2026-07-16 8:42 ` Qi Zheng
2026-07-16 11:17 ` Ridong Chen
2026-07-17 2:27 ` Qi Zheng
2026-07-16 6:06 ` Tao Cui
2026-07-16 8:23 ` Ridong Chen
2026-07-23 1:13 ` Ridong Chen [this message]
2026-07-23 1:54 ` [PATCH v2 0/2] mm: fix node reclaim swappiness handling Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56fcb7bf-5e0b-46ad-84e5-12b2d00b7a34@linux.dev \
--to=ridong.chen@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=baohua@kernel.org \
--cc=baoquan.he@linux.dev \
--cc=cgroups@vger.kernel.org \
--cc=chenridong@xiaomi.com \
--cc=chrisl@kernel.org \
--cc=dave@stgolabs.net \
--cc=david@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kasong@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=nphamcs@gmail.com \
--cc=qi.zheng@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=shikemeng@huaweicloud.com \
--cc=weixugc@google.com \
--cc=youngjun.park@lge.com \
--cc=yuanchu@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox