From: Johannes Weiner <hannes@cmpxchg.org>
To: Ridong <ridong.chen@linux.dev>
Cc: Michal Hocko <mhocko@kernel.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Shakeel Butt <shakeel.butt@linux.dev>,
Andrew Morton <akpm@linux-foundation.org>,
Chris Li <chrisl@kernel.org>, Kairui Song <kasong@tencent.com>,
Muchun Song <muchun.song@linux.dev>,
Kemeng Shi <shikemeng@huaweicloud.com>,
Nhat Pham <nphamcs@gmail.com>, Baoquan He <baoquan.he@linux.dev>,
Barry Song <baohua@kernel.org>,
Youngjun Park <youngjun.park@lge.com>,
David Hildenbrand <david@kernel.org>,
Qi Zheng <qi.zheng@linux.dev>, Lorenzo Stoakes <ljs@kernel.org>,
Axel Rasmussen <axelrasmussen@google.com>,
Yuanchu Xie <yuanchu@google.com>, Wei Xu <weixugc@google.com>,
Davidlohr Bueso <dave@stgolabs.net>,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Ridong Chen <chenridong@xiaomi.com>
Subject: Re: [PATCH v2 1/2] memcg: move mem_cgroup_swappiness and vm_swappiness to mm/swap.h
Date: Wed, 22 Jul 2026 21:59:38 -0400 [thread overview]
Message-ID: <amF1ii74RlzKiepO@cmpxchg.org> (raw)
In-Reply-To: <20260716031729.1064007-2-ridong.chen@linux.dev>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
One small suggestion:
On Thu, Jul 16, 2026 at 11:17:28AM +0800, Ridong wrote:
> @@ -76,6 +77,25 @@ enum swap_cluster_flags {
> CLUSTER_FLAG_MAX,
> };
>
> +extern int vm_swappiness;
> +
> +static inline int mem_cgroup_swappiness(struct mem_cgroup *memcg)
> +{
> +#ifdef CONFIG_MEMCG_V1
> + /* Cgroup2 doesn't have per-cgroup swappiness */
> + if (cgroup_subsys_on_dfl(memory_cgrp_subsys))
> + return READ_ONCE(vm_swappiness);
> +
> + /* root ? */
> + if (mem_cgroup_disabled() || mem_cgroup_is_root(memcg))
> + return READ_ONCE(vm_swappiness);
> +
> + return READ_ONCE(memcg->swappiness);
> +#else
> + return READ_ONCE(vm_swappiness);
> +#endif
How about:
#ifdef CONFIG_MEMCG_V1
if (!cgroup_subsys_on_dfl(memory_cgrp_subsys) &&
!mem_cgroup_disabled() && !mem_cgroup_is_root(memcg))
return memcg->swappiness;
#endif
return READ_ONCE(vm_swappiness);
next prev parent reply other threads:[~2026-07-23 1:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-16 3:17 [PATCH v2 0/2] mm: fix node reclaim swappiness handling Ridong
2026-07-16 3:17 ` [PATCH v2 1/2] memcg: move mem_cgroup_swappiness and vm_swappiness to mm/swap.h Ridong
2026-07-16 6:06 ` Tao Cui
2026-07-16 7:14 ` Barry Song
2026-07-23 1:59 ` Johannes Weiner [this message]
2026-07-23 2:14 ` Ridong Chen
2026-07-16 3:17 ` [PATCH v2 2/2] mm: vmscan: fix node reclaim ignoring swappiness parameter Ridong
2026-07-16 3:25 ` Qi Zheng
2026-07-16 3:58 ` Qi Zheng
2026-07-16 8:21 ` Ridong Chen
2026-07-16 8:42 ` Qi Zheng
2026-07-16 11:17 ` Ridong Chen
2026-07-17 2:27 ` Qi Zheng
2026-07-16 6:06 ` Tao Cui
2026-07-16 8:23 ` Ridong Chen
2026-07-23 1:13 ` [PATCH v2 0/2] mm: fix node reclaim swappiness handling Ridong Chen
2026-07-23 1:54 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amF1ii74RlzKiepO@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=baohua@kernel.org \
--cc=baoquan.he@linux.dev \
--cc=cgroups@vger.kernel.org \
--cc=chenridong@xiaomi.com \
--cc=chrisl@kernel.org \
--cc=dave@stgolabs.net \
--cc=david@kernel.org \
--cc=kasong@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=nphamcs@gmail.com \
--cc=qi.zheng@linux.dev \
--cc=ridong.chen@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=shikemeng@huaweicloud.com \
--cc=weixugc@google.com \
--cc=youngjun.park@lge.com \
--cc=yuanchu@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox