* [PATCH v3 1/2] cgroup/cpuset: export cpuset_cpus_allowed() [not found] <20240606151017.41623-1-fgriffo@amazon.co.uk> @ 2024-06-06 15:10 ` Fred Griffoul 2024-06-06 15:45 ` Waiman Long 0 siblings, 1 reply; 4+ messages in thread From: Fred Griffoul @ 2024-06-06 15:10 UTC (permalink / raw) To: griffoul Cc: Fred Griffoul, kernel test robot, Alex Williamson, Waiman Long, Zefan Li, Tejun Heo, Johannes Weiner, Jason Gunthorpe, Yi Liu, Kevin Tian, Eric Auger, Stefan Hajnoczi, Christian Brauner, Ankit Agrawal, Reinette Chatre, Ye Bin, kvm, linux-kernel, cgroups A subsequent patch calls cpuset_cpus_allowed() in the vfio driver pci code. Export the symbol to be able to build the vfio driver as a kernel module. Signed-off-by: Fred Griffoul <fgriffo@amazon.co.uk> Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202406060731.L3NSR1Hy-lkp@intel.com/ --- kernel/cgroup/cpuset.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c index 4237c8748715..9fd56222aa4b 100644 --- a/kernel/cgroup/cpuset.c +++ b/kernel/cgroup/cpuset.c @@ -4764,6 +4764,7 @@ void cpuset_cpus_allowed(struct task_struct *tsk, struct cpumask *pmask) rcu_read_unlock(); spin_unlock_irqrestore(&callback_lock, flags); } +EXPORT_SYMBOL_GPL(cpuset_cpus_allowed); /** * cpuset_cpus_allowed_fallback - final fallback before complete catastrophe. -- 2.40.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3 1/2] cgroup/cpuset: export cpuset_cpus_allowed() 2024-06-06 15:10 ` [PATCH v3 1/2] cgroup/cpuset: export cpuset_cpus_allowed() Fred Griffoul @ 2024-06-06 15:45 ` Waiman Long 2024-06-07 16:28 ` Tejun Heo 0 siblings, 1 reply; 4+ messages in thread From: Waiman Long @ 2024-06-06 15:45 UTC (permalink / raw) To: Fred Griffoul, griffoul Cc: kernel test robot, Alex Williamson, Zefan Li, Tejun Heo, Johannes Weiner, Jason Gunthorpe, Yi Liu, Kevin Tian, Eric Auger, Stefan Hajnoczi, Christian Brauner, Ankit Agrawal, Reinette Chatre, Ye Bin, kvm, linux-kernel, cgroups On 6/6/24 11:10, Fred Griffoul wrote: > A subsequent patch calls cpuset_cpus_allowed() in the vfio driver pci > code. Export the symbol to be able to build the vfio driver as a kernel > module. > > Signed-off-by: Fred Griffoul <fgriffo@amazon.co.uk> > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202406060731.L3NSR1Hy-lkp@intel.com/ > --- > kernel/cgroup/cpuset.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c > index 4237c8748715..9fd56222aa4b 100644 > --- a/kernel/cgroup/cpuset.c > +++ b/kernel/cgroup/cpuset.c > @@ -4764,6 +4764,7 @@ void cpuset_cpus_allowed(struct task_struct *tsk, struct cpumask *pmask) > rcu_read_unlock(); > spin_unlock_irqrestore(&callback_lock, flags); > } > +EXPORT_SYMBOL_GPL(cpuset_cpus_allowed); > > /** > * cpuset_cpus_allowed_fallback - final fallback before complete catastrophe. LGTM Acked-by: Waiman Long <longman@redhat.com> ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3 1/2] cgroup/cpuset: export cpuset_cpus_allowed() 2024-06-06 15:45 ` Waiman Long @ 2024-06-07 16:28 ` Tejun Heo 2024-06-07 18:18 ` Frederic Griffoul 0 siblings, 1 reply; 4+ messages in thread From: Tejun Heo @ 2024-06-07 16:28 UTC (permalink / raw) To: Waiman Long Cc: Fred Griffoul, griffoul, kernel test robot, Alex Williamson, Zefan Li, Johannes Weiner, Jason Gunthorpe, Yi Liu, Kevin Tian, Eric Auger, Stefan Hajnoczi, Christian Brauner, Ankit Agrawal, Reinette Chatre, Ye Bin, kvm, linux-kernel, cgroups On Thu, Jun 06, 2024 at 11:45:37AM -0400, Waiman Long wrote: > > On 6/6/24 11:10, Fred Griffoul wrote: > > A subsequent patch calls cpuset_cpus_allowed() in the vfio driver pci > > code. Export the symbol to be able to build the vfio driver as a kernel > > module. > > > > Signed-off-by: Fred Griffoul <fgriffo@amazon.co.uk> > > Reported-by: kernel test robot <lkp@intel.com> > > Closes: https://lore.kernel.org/oe-kbuild-all/202406060731.L3NSR1Hy-lkp@intel.com/ > > --- > > kernel/cgroup/cpuset.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c > > index 4237c8748715..9fd56222aa4b 100644 > > --- a/kernel/cgroup/cpuset.c > > +++ b/kernel/cgroup/cpuset.c > > @@ -4764,6 +4764,7 @@ void cpuset_cpus_allowed(struct task_struct *tsk, struct cpumask *pmask) > > rcu_read_unlock(); > > spin_unlock_irqrestore(&callback_lock, flags); > > } > > +EXPORT_SYMBOL_GPL(cpuset_cpus_allowed); > > /** > > * cpuset_cpus_allowed_fallback - final fallback before complete catastrophe. > > LGTM > > Acked-by: Waiman Long <longman@redhat.com> Acked-by: Tejun Heo <tj@kernel.org> If more convenient, please feel free to route the patch with the rest of the series. If you want it applied to the cgroup tree, please let me know. Thanks. -- tejun ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3 1/2] cgroup/cpuset: export cpuset_cpus_allowed() 2024-06-07 16:28 ` Tejun Heo @ 2024-06-07 18:18 ` Frederic Griffoul 0 siblings, 0 replies; 4+ messages in thread From: Frederic Griffoul @ 2024-06-07 18:18 UTC (permalink / raw) To: Tejun Heo Cc: Waiman Long, Fred Griffoul, kernel test robot, Alex Williamson, Zefan Li, Johannes Weiner, Jason Gunthorpe, Yi Liu, Kevin Tian, Eric Auger, Stefan Hajnoczi, Christian Brauner, Ankit Agrawal, Reinette Chatre, Ye Bin, kvm, linux-kernel, cgroups Thanks. Unfortunately exporting cpuset_cpus_allowed() is not enough. When CONFIG_CPUSETS is _not_ defined, the function is inline to return task_cpu_possible_mask(). On arm64 the latter checks the static key arm64_mismatched_32bit_el0, and thus this symbol must be exported too. I wonder whether it would be better to avoid inlining cpuset_cpus_allowed() in this case. Br, Fred On Fri, Jun 7, 2024 at 5:29 PM Tejun Heo <tj@kernel.org> wrote: > > On Thu, Jun 06, 2024 at 11:45:37AM -0400, Waiman Long wrote: > > > > On 6/6/24 11:10, Fred Griffoul wrote: > > > A subsequent patch calls cpuset_cpus_allowed() in the vfio driver pci > > > code. Export the symbol to be able to build the vfio driver as a kernel > > > module. > > > > > > Signed-off-by: Fred Griffoul <fgriffo@amazon.co.uk> > > > Reported-by: kernel test robot <lkp@intel.com> > > > Closes: https://lore.kernel.org/oe-kbuild-all/202406060731.L3NSR1Hy-lkp@intel.com/ > > > --- > > > kernel/cgroup/cpuset.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c > > > index 4237c8748715..9fd56222aa4b 100644 > > > --- a/kernel/cgroup/cpuset.c > > > +++ b/kernel/cgroup/cpuset.c > > > @@ -4764,6 +4764,7 @@ void cpuset_cpus_allowed(struct task_struct *tsk, struct cpumask *pmask) > > > rcu_read_unlock(); > > > spin_unlock_irqrestore(&callback_lock, flags); > > > } > > > +EXPORT_SYMBOL_GPL(cpuset_cpus_allowed); > > > /** > > > * cpuset_cpus_allowed_fallback - final fallback before complete catastrophe. > > > > LGTM > > > > Acked-by: Waiman Long <longman@redhat.com> > > Acked-by: Tejun Heo <tj@kernel.org> > > If more convenient, please feel free to route the patch with the rest of the > series. If you want it applied to the cgroup tree, please let me know. > > Thanks. > > -- > tejun ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-06-07 18:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20240606151017.41623-1-fgriffo@amazon.co.uk>
2024-06-06 15:10 ` [PATCH v3 1/2] cgroup/cpuset: export cpuset_cpus_allowed() Fred Griffoul
2024-06-06 15:45 ` Waiman Long
2024-06-07 16:28 ` Tejun Heo
2024-06-07 18:18 ` Frederic Griffoul
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox