From: Tejun Heo <tj@kernel.org>
To: Waiman Long <longman@redhat.com>
Cc: Lai Jiangshan <jiangshanlai@gmail.com>,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH-cgroup] workqueue: Move workqueue_set_unbound_cpumask() and its helpers inside CONFIG_SYSFS
Date: Tue, 21 Nov 2023 06:20:08 -1000 [thread overview]
Message-ID: <ZVzYuHLvWfgIn5qP@slm.duckdns.org> (raw)
In-Reply-To: <20231121021840.10937-1-longman@redhat.com>
On Mon, Nov 20, 2023 at 09:18:40PM -0500, Waiman Long wrote:
> Commit fe28f631fa94 ("workqueue: Add workqueue_unbound_exclude_cpumask()
> to exclude CPUs from wq_unbound_cpumask") makes
> workqueue_set_unbound_cpumask() static as it is not used elsewhere in
> the kernel. However, this triggers a kernel test robot warning about
> 'workqueue_set_unbound_cpumask' defined but not used when CONFIG_SYS
> isn't defined. It happens that workqueue_set_unbound_cpumask() is only
> called when CONFIG_SYS is defined.
>
> Move workqueue_set_unbound_cpumask() and its helpers inside the
> CONFIG_SYSFS compilation block to avoid the warning. There is no
> functional change.
>
> Fixes: fe28f631fa94 ("workqueue: Add workqueue_unbound_exclude_cpumask() to exclude CPUs from wq_unbound_cpumask")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202311130831.uh0AoCd1-lkp@intel.com/
> Signed-off-by: Waiman Long <longman@redhat.com>
Applied to cgroup/for-6.8.
Thanks.
--
tejun
prev parent reply other threads:[~2023-11-21 16:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 2:18 [PATCH-cgroup] workqueue: Move workqueue_set_unbound_cpumask() and its helpers inside CONFIG_SYSFS Waiman Long
2023-11-21 16:20 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVzYuHLvWfgIn5qP@slm.duckdns.org \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=longman@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox