Linux cgroups development
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Waiman Long <longman@redhat.com>
Cc: Zefan Li <lizefan.x@bytedance.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH-cgroup 1/2] cgroup: Show # of subsystem CSSes in /proc/cgroups
Date: Mon, 8 Jul 2024 09:05:08 -1000	[thread overview]
Message-ID: <Zow4ZJFa6Kwz4BlO@slm.duckdns.org> (raw)
In-Reply-To: <b505c15b-8fd2-44f2-8e33-46ae29c2696e@redhat.com>

Hello,

On Mon, Jul 08, 2024 at 03:01:39PM -0400, Waiman Long wrote:
> That information is certainly useful to display to cgroup.stat which
> currently only shows nr_descendants and nr_dying_descendants. So does
> "nr_<subsys_name> <cnt>" for each cgroup subsystems look good to you or do
> you have other suggestion?

Yeah, something like that. Johannes, what do you think?

> The reason for this patch is because I got a bug report about leaking blkio
> cgroup due to the information shown in /proc/cgroups. I know you want do
> deprecate it for cgroup v2. How about adding a iine like "# Deprecated for
> cgroup v2, use cgroup.stats file for cgroup counts" at the top of
> /proc/cgroups when cgroup v2 is active?

I wonder whether that would break some parsers but we can try that and see
what happens.

Thanks.

-- 
tejun

  reply	other threads:[~2024-07-08 19:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-06  0:56 [PATCH-cgroup 1/2] cgroup: Show # of subsystem CSSes in /proc/cgroups Waiman Long
2024-07-06  0:56 ` [PATCH-cgroup 2/2] cgroup: Remove nr_cgrps Waiman Long
2024-07-08 18:45 ` [PATCH-cgroup 1/2] cgroup: Show # of subsystem CSSes in /proc/cgroups Tejun Heo
2024-07-08 19:01   ` Waiman Long
2024-07-08 19:05     ` Tejun Heo [this message]
2024-07-08 19:18       ` Waiman Long

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zow4ZJFa6Kwz4BlO@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan.x@bytedance.com \
    --cc=longman@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox