From: Tejun Heo <tj@kernel.org>
To: Waiman Long <longman@redhat.com>
Cc: Zefan Li <lizefan.x@bytedance.com>,
Johannes Weiner <hannes@cmpxchg.org>,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH-cgroup 1/2] cgroup: Show # of subsystem CSSes in /proc/cgroups
Date: Mon, 8 Jul 2024 08:45:17 -1000 [thread overview]
Message-ID: <Zowzvf2NEOzgXYr3@slm.duckdns.org> (raw)
In-Reply-To: <20240706005622.2003606-1-longman@redhat.com>
Hello, Waiman.
On Fri, Jul 05, 2024 at 08:56:21PM -0400, Waiman Long wrote:
> The /proc/cgroups file shows the number of cgroups for each of the
> subsystems. With cgroup v1, the number of CSSes is the same as the
> number of cgroups. That is not the case anymore with cgroup v2. The
> /proc/cgroups file cannot show the actual number of CSSes for the
> subsystems that are bound to cgroup v2.
>
> So if a v2 cgroup subsystem is leaking cgroups (typically memory
> cgroup), we can't tell by looking at /proc/cgroups which cgroup
> subsystems may be responsible. This patch adds a css counter in the
> cgroup_subsys structure to keep track of the number of CSSes for each
> of the cgroup subsystems.
The count sounds useful to me but can we add it in cgroup.stats instead?
Thanks.
--
tejun
next prev parent reply other threads:[~2024-07-08 18:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-06 0:56 [PATCH-cgroup 1/2] cgroup: Show # of subsystem CSSes in /proc/cgroups Waiman Long
2024-07-06 0:56 ` [PATCH-cgroup 2/2] cgroup: Remove nr_cgrps Waiman Long
2024-07-08 18:45 ` Tejun Heo [this message]
2024-07-08 19:01 ` [PATCH-cgroup 1/2] cgroup: Show # of subsystem CSSes in /proc/cgroups Waiman Long
2024-07-08 19:05 ` Tejun Heo
2024-07-08 19:18 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zowzvf2NEOzgXYr3@slm.duckdns.org \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=longman@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox