* [PATCH] mm: memcg: remove stray text from obj_stock_pcp comment @ 2026-06-23 8:26 Guopeng Zhang 2026-06-23 8:42 ` Harry Yoo 0 siblings, 1 reply; 4+ messages in thread From: Guopeng Zhang @ 2026-06-23 8:26 UTC (permalink / raw) To: Johannes Weiner, Michal Hocko, Roman Gushchin, Shakeel Butt, Muchun Song, Andrew Morton Cc: cgroups, linux-mm, linux-kernel, Guopeng Zhang From: Guopeng Zhang <zhangguopeng@kylinos.cn> A patch filename was accidentally inserted into the comment describing the nr_bytes field of struct obj_stock_pcp. Remove it. No functional change. Signed-off-by: Guopeng Zhang <zhangguopeng@kylinos.cn> --- mm/memcontrol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 6dc4888a90f3..3eedfc4e84a0 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -2039,7 +2039,7 @@ struct obj_stock_pcp { /* * On rare archs with 256KiB base page size (hexagon and powerpc 44x) * keep nr_bytes to unsigned int as uint16_t cannot represent the full -e patches/memcg-uint16_t-for-nr_bytes-in-obj_stock_pcp.patch * sub-page remainder. Such archs are not cacheline optimization target. + * sub-page remainder. Such archs are not cacheline optimization targets. */ unsigned int nr_bytes[NR_OBJ_STOCK]; #else -- 2.25.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] mm: memcg: remove stray text from obj_stock_pcp comment 2026-06-23 8:26 [PATCH] mm: memcg: remove stray text from obj_stock_pcp comment Guopeng Zhang @ 2026-06-23 8:42 ` Harry Yoo 2026-06-23 9:02 ` Guopeng Zhang 0 siblings, 1 reply; 4+ messages in thread From: Harry Yoo @ 2026-06-23 8:42 UTC (permalink / raw) To: Guopeng Zhang, Johannes Weiner, Michal Hocko, Roman Gushchin, Shakeel Butt, Muchun Song, Andrew Morton Cc: cgroups, linux-mm, linux-kernel, Guopeng Zhang [-- Attachment #1.1: Type: text/plain, Size: 1227 bytes --] On 6/23/26 5:26 PM, Guopeng Zhang wrote: > From: Guopeng Zhang <zhangguopeng@kylinos.cn> > > A patch filename was accidentally inserted into the comment describing > the nr_bytes field of struct obj_stock_pcp. Remove it. nit: perhaps add something like "Fix a typo in the comment (target -> targets)"? > No functional change. > > Signed-off-by: Guopeng Zhang <zhangguopeng@kylinos.cn> > --- FWIW, Acked-by: Harry Yoo (Oracle) <harry@kernel.org> Thanks! > mm/memcontrol.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 6dc4888a90f3..3eedfc4e84a0 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -2039,7 +2039,7 @@ struct obj_stock_pcp { > /* > * On rare archs with 256KiB base page size (hexagon and powerpc 44x) > * keep nr_bytes to unsigned int as uint16_t cannot represent the full > -e patches/memcg-uint16_t-for-nr_bytes-in-obj_stock_pcp.patch * sub-page remainder. Such archs are not cacheline optimization target. > + * sub-page remainder. Such archs are not cacheline optimization targets. > */ > unsigned int nr_bytes[NR_OBJ_STOCK]; > #else -- Cheers, Harry / Hyeonggon [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mm: memcg: remove stray text from obj_stock_pcp comment 2026-06-23 8:42 ` Harry Yoo @ 2026-06-23 9:02 ` Guopeng Zhang 2026-06-24 4:32 ` Harry Yoo 0 siblings, 1 reply; 4+ messages in thread From: Guopeng Zhang @ 2026-06-23 9:02 UTC (permalink / raw) To: Harry Yoo, Guopeng Zhang, Johannes Weiner, Michal Hocko, Roman Gushchin, Shakeel Butt, Muchun Song, Andrew Morton Cc: cgroups, linux-mm, linux-kernel 在 2026/6/23 16:42, Harry Yoo 写道: > > On 6/23/26 5:26 PM, Guopeng Zhang wrote: >> From: Guopeng Zhang <zhangguopeng@kylinos.cn> >> >> A patch filename was accidentally inserted into the comment describing >> the nr_bytes field of struct obj_stock_pcp. Remove it. > nit: perhaps add something like > "Fix a typo in the comment (target -> targets)"? Hi Harry, Thanks for the review and the Ack. Yes, I also fixed the "target -> targets" typo, but missed mentioning it in the commit message. I'll be more careful about describing all changes clearly next time. If a respin is needed, I'll add it to the commit message and carry your Acked-by. Thanks, Guopeng >> No functional change. >> >> Signed-off-by: Guopeng Zhang <zhangguopeng@kylinos.cn> >> --- > FWIW, > Acked-by: Harry Yoo (Oracle) <harry@kernel.org> > > Thanks! > >> mm/memcontrol.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/mm/memcontrol.c b/mm/memcontrol.c >> index 6dc4888a90f3..3eedfc4e84a0 100644 >> --- a/mm/memcontrol.c >> +++ b/mm/memcontrol.c >> @@ -2039,7 +2039,7 @@ struct obj_stock_pcp { >> /* >> * On rare archs with 256KiB base page size (hexagon and powerpc 44x) >> * keep nr_bytes to unsigned int as uint16_t cannot represent the full >> -e patches/memcg-uint16_t-for-nr_bytes-in-obj_stock_pcp.patch * sub-page remainder. Such archs are not cacheline optimization target. >> + * sub-page remainder. Such archs are not cacheline optimization targets. >> */ >> unsigned int nr_bytes[NR_OBJ_STOCK]; >> #else ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mm: memcg: remove stray text from obj_stock_pcp comment 2026-06-23 9:02 ` Guopeng Zhang @ 2026-06-24 4:32 ` Harry Yoo 0 siblings, 0 replies; 4+ messages in thread From: Harry Yoo @ 2026-06-24 4:32 UTC (permalink / raw) To: Guopeng Zhang, Guopeng Zhang, Johannes Weiner, Michal Hocko, Roman Gushchin, Shakeel Butt, Muchun Song, Andrew Morton Cc: cgroups, linux-mm, linux-kernel [-- Attachment #1.1: Type: text/plain, Size: 1875 bytes --] On 6/23/26 6:02 PM, Guopeng Zhang wrote: > 在 2026/6/23 16:42, Harry Yoo 写道: >> >> On 6/23/26 5:26 PM, Guopeng Zhang wrote: >>> From: Guopeng Zhang <zhangguopeng@kylinos.cn> >>> >>> A patch filename was accidentally inserted into the comment describing >>> the nr_bytes field of struct obj_stock_pcp. Remove it. >> nit: perhaps add something like >> "Fix a typo in the comment (target -> targets)"? > Hi Harry, Hi Guopeng, > Thanks for the review and the Ack. > > Yes, I also fixed the "target -> targets" typo, but missed mentioning it > in the commit message. No worries :) It's not a big deal, just wanted to mention. > I'll be more careful about describing all changes > clearly next time. Thanks! > If a respin is needed, I'll add it to the commit > message and carry your Acked-by. I guess it's okay to not respin for this. Thanks! > Thanks, > Guopeng > >>> No functional change. >>> >>> Signed-off-by: Guopeng Zhang <zhangguopeng@kylinos.cn> >>> --- >> FWIW, >> Acked-by: Harry Yoo (Oracle) <harry@kernel.org> >> >> Thanks! >> >>> mm/memcontrol.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/mm/memcontrol.c b/mm/memcontrol.c >>> index 6dc4888a90f3..3eedfc4e84a0 100644 >>> --- a/mm/memcontrol.c >>> +++ b/mm/memcontrol.c >>> @@ -2039,7 +2039,7 @@ struct obj_stock_pcp { >>> /* >>> * On rare archs with 256KiB base page size (hexagon and powerpc 44x) >>> * keep nr_bytes to unsigned int as uint16_t cannot represent the full >>> -e patches/memcg-uint16_t-for-nr_bytes-in-obj_stock_pcp.patch * sub-page remainder. Such archs are not cacheline optimization target. >>> + * sub-page remainder. Such archs are not cacheline optimization targets. >>> */ >>> unsigned int nr_bytes[NR_OBJ_STOCK]; >>> #else -- Cheers, Harry / Hyeonggon [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-06-24 4:32 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-06-23 8:26 [PATCH] mm: memcg: remove stray text from obj_stock_pcp comment Guopeng Zhang 2026-06-23 8:42 ` Harry Yoo 2026-06-23 9:02 ` Guopeng Zhang 2026-06-24 4:32 ` Harry Yoo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox