Linux cgroups development
 help / color / mirror / Atom feed
From: "Michal Koutný" <mkoutny@suse.com>
To: Li Wang <li.wang@linux.dev>
Cc: akpm@linux-foundation.org, tj@kernel.org, longman@redhat.com,
	 roman.gushchin@linux.dev, hannes@cmpxchg.org, yosry@kernel.org,
	jiayuan.chen@linux.dev,  nphamcs@gmail.com,
	chengming.zhou@linux.dev, shuah@kernel.org, linux-mm@kvack.org,
	 cgroups@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org,  Michal Hocko <mhocko@kernel.org>,
	Muchun Song <muchun.song@linux.dev>,
	 Shakeel Butt <shakeel.butt@linux.dev>
Subject: Re: [PATCH v7 2/8] selftests/cgroup: avoid OOM in test_swapin_nozswap
Date: Wed, 17 Jun 2026 14:26:01 +0200	[thread overview]
Message-ID: <ajKRLmEoR3P2QTNW@localhost.localdomain> (raw)
In-Reply-To: <20260424040059.12940-3-li.wang@linux.dev>

[-- Attachment #1: Type: text/plain, Size: 957 bytes --]

On Fri, Apr 24, 2026 at 12:00:53PM +0800, Li Wang <li.wang@linux.dev> wrote:
> test_swapin_nozswap can hit OOM before reaching its assertions on some
> setups.

Is it because of differences in available IO or what does it depend on?

> The test currently sets memory.max=8M and then allocates/reads
> 32M with memory.zswap.max=0, which may over-constrain reclaim and kill
> the workload process.
> 
> Replace hardcoded sizes with PAGE_SIZE-based values:
>   - control_allocation_size = PAGE_SIZE * 512
>   - memory.max = control_allocation_size * 3 / 4
>   - minimum expected swap = control_allocation_size / 4
> 
> This keeps the test pressure model intact (allocate/read beyond memory.max to
> force swap-in/out) while making it more robust across different environments.

I see you used allocation value that is preserve absolute values from 64k systems
test is differnt on 4k ones. Any specific reason for that?


Thanks,
Michal

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 265 bytes --]

  reply	other threads:[~2026-06-17 12:26 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-24  4:00 [PATCH v7 0/8] selftests/cgroup: improve zswap tests robustness and support large page sizes Li Wang
2026-04-24  4:00 ` [PATCH v7 1/8] selftests/cgroup: skip test_zswap if zswap is globally disabled Li Wang
2026-06-17 12:25   ` Michal Koutný
2026-04-24  4:00 ` [PATCH v7 2/8] selftests/cgroup: avoid OOM in test_swapin_nozswap Li Wang
2026-06-17 12:26   ` Michal Koutný [this message]
2026-04-24  4:00 ` [PATCH v7 3/8] selftests/cgroup: use runtime page size for zswpin check Li Wang
2026-06-17 12:25   ` Michal Koutný
2026-04-24  4:00 ` [PATCH v7 4/8] selftests/cgroup: rename PAGE_SIZE to BUF_SIZE in cgroup_util Li Wang
2026-06-17 12:26   ` Michal Koutný
2026-04-24  4:00 ` [PATCH v7 5/8] selftests/cgroup: replace hardcoded page size values in test_zswap Li Wang
2026-04-24  5:20   ` Jiayuan Chen
2026-06-17 12:26   ` Michal Koutný
2026-04-24  4:00 ` [PATCH v7 6/8] selftest/cgroup: fix zswap test_no_invasive_cgroup_shrink on large pagesize system Li Wang
2026-06-17 12:27   ` Michal Koutný
2026-04-24  4:00 ` [PATCH v7 7/8] selftest/cgroup: fix zswap attempt_writeback() on 64K " Li Wang
2026-06-17 12:26   ` Michal Koutný
2026-04-24  4:00 ` [PATCH v7 8/8] selftests/cgroup: test_zswap: wait for asynchronous writeback Li Wang
2026-06-17 12:26   ` Michal Koutný
2026-04-24 10:06 ` [PATCH v7 0/8] selftests/cgroup: improve zswap tests robustness and support large page sizes Andrew Morton
2026-04-24 11:14   ` Li Wang
2026-04-24 13:31 ` Andrew Morton
2026-06-17 12:28 ` Michal Koutný

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ajKRLmEoR3P2QTNW@localhost.localdomain \
    --to=mkoutny@suse.com \
    --cc=akpm@linux-foundation.org \
    --cc=cgroups@vger.kernel.org \
    --cc=chengming.zhou@linux.dev \
    --cc=hannes@cmpxchg.org \
    --cc=jiayuan.chen@linux.dev \
    --cc=li.wang@linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=longman@redhat.com \
    --cc=mhocko@kernel.org \
    --cc=muchun.song@linux.dev \
    --cc=nphamcs@gmail.com \
    --cc=roman.gushchin@linux.dev \
    --cc=shakeel.butt@linux.dev \
    --cc=shuah@kernel.org \
    --cc=tj@kernel.org \
    --cc=yosry@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox