From: Julia Lawall <julia.lawall@lip6.fr>
To: dennisszhou@gmail.com
Cc: Jens Axboe <axboe@kernel.dk>, Tejun Heo <tj@kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Josef Bacik <josef@toxicpanda.com>,
kernel-team@fb.com, linux-block@vger.kernel.org,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
"Dennis Zhou (Facebook)" <dennisszhou@gmail.com>
Subject: [PATCH] blkcg: fix call_kern.cocci warnings
Date: Fri, 31 Aug 2018 12:01:38 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.1808311158220.2328@hadrien> (raw)
From: kbuild test robot <fengguang.wu@intel.com>
block/blk-cgroup.c:243:57-67: ERROR: function blkg_create called on line 1260 inside lock on line 1259 but uses GFP_KERNEL
block/blk-cgroup.c:243:57-67: ERROR: function blkg_create called on line 922 inside lock on line 911 but uses GFP_KERNEL
Generated by: scripts/coccinelle/locks/call_kern.cocci
Fixes: 6ef69a3a0b4a ("blkcg: change blkg reference counting to use percpu_ref")
CC: Dennis Zhou (Facebook) <dennisszhou@gmail.com>
Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
---
url: https://github.com/0day-ci/linux/commits/Dennis-Zhou/blkcg-ref-count-refactor-cleanup-blkcg-avg_lat/20180831-161742
base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
:::::: branch date: 10 hours ago
:::::: commit date: 10 hours ago
The kbuild report doesn't include enough context to check this. Please
check whether this is appropriate and whether another approach would be
better.
blk-cgroup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/block/blk-cgroup.c
+++ b/block/blk-cgroup.c
@@ -240,7 +240,7 @@ static struct blkcg_gq *blkg_create(stru
blkg_get(blkg->parent);
}
- ret = percpu_ref_init(&blkg->refcnt, __blkg_release, 0, GFP_KERNEL);
+ ret = percpu_ref_init(&blkg->refcnt, __blkg_release, 0, GFP_ATOMIC);
if (ret)
goto err_cancel_ref;
reply other threads:[~2018-08-31 19:01 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1808311158220.2328@hadrien \
--to=julia.lawall@lip6.fr \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=dennisszhou@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox