From: "Michal Koutný" <mkoutny@suse.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: cgroups@vger.kernel.org, Tejun Heo <tj@kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH] cgroup: Use %p for pointer formatting
Date: Fri, 18 Sep 2026 14:59:00 +0200 [thread overview]
Message-ID: <aq0z3hEYggA_TuUD@localhost.localdomain> (raw)
In-Reply-To: <20260918104852.1p2fz_-_@linutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1023 bytes --]
On Fri, Sep 18, 2026 at 12:48:52PM +0200, Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
> Since commit ad67b74d2469d ("printk: hash addresses printed with
> %p") pointers are hashed by default and the behaviour can be controller
> by `hash_pointers' boot argument.
> The policy on %p is to not introduce new ones.
%pK should be here?
I assume it based on:
| This is because %pK checks are done at read() time rather than open()
| ...
| The correct long-term solution is to do the permission checks at
| open() time.
of Documentation/admin-guide/sysctl/kernel.rst-time
<snip>
> Removing %pK makes it possible to remove its handling from the library.
This is also a good sell.
But I see there are a few of them still here and there.
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
> kernel/cgroup/debug.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
Nevertheless,
Acked-by: Michal Koutný <mkoutny@suse.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 265 bytes --]
next prev parent reply other threads:[~2026-09-18 12:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 10:48 [PATCH] cgroup: Use %p for pointer formatting Sebastian Andrzej Siewior
2026-09-18 12:59 ` Michal Koutný [this message]
2026-09-18 16:56 ` Sebastian Andrzej Siewior
2026-09-19 0:12 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aq0z3hEYggA_TuUD@localhost.localdomain \
--to=mkoutny@suse.com \
--cc=bigeasy@linutronix.de \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox