* [PATCH] platform/chrome: kunit: initialize lock for fake ec_dev
@ 2023-10-03 8:05 Tzung-Bi Shih
2023-10-05 2:14 ` Guenter Roeck
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Tzung-Bi Shih @ 2023-10-03 8:05 UTC (permalink / raw)
To: bleung, groeck; +Cc: tzungbi, chrome-platform
cros_ec_cmd_xfer() uses ec_dev->lock. Initialize it.
Otherwise, dmesg shows the following:
> DEBUG_LOCKS_WARN_ON(lock->magic != lock)
> ...
> Call Trace:
> ? __mutex_lock
> ? __warn
> ? __mutex_lock
> ...
> ? cros_ec_cmd_xfer
Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
---
drivers/platform/chrome/cros_ec_proto_test.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/chrome/cros_ec_proto_test.c b/drivers/platform/chrome/cros_ec_proto_test.c
index 28f722396fc1..b6169d6f2467 100644
--- a/drivers/platform/chrome/cros_ec_proto_test.c
+++ b/drivers/platform/chrome/cros_ec_proto_test.c
@@ -2668,6 +2668,7 @@ static int cros_ec_proto_test_init(struct kunit *test)
ec_dev->dev->release = cros_ec_proto_test_release;
ec_dev->cmd_xfer = cros_kunit_ec_xfer_mock;
ec_dev->pkt_xfer = cros_kunit_ec_xfer_mock;
+ mutex_init(&ec_dev->lock);
priv->msg = (struct cros_ec_command *)priv->_msg;
--
2.42.0.582.g8ccd20d70d-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] platform/chrome: kunit: initialize lock for fake ec_dev
2023-10-03 8:05 [PATCH] platform/chrome: kunit: initialize lock for fake ec_dev Tzung-Bi Shih
@ 2023-10-05 2:14 ` Guenter Roeck
2023-10-05 10:20 ` patchwork-bot+chrome-platform
2023-10-11 2:20 ` patchwork-bot+chrome-platform
2 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2023-10-05 2:14 UTC (permalink / raw)
To: Tzung-Bi Shih; +Cc: bleung, groeck, chrome-platform
On Tue, Oct 3, 2023 at 1:05 AM Tzung-Bi Shih <tzungbi@kernel.org> wrote:
>
> cros_ec_cmd_xfer() uses ec_dev->lock. Initialize it.
>
> Otherwise, dmesg shows the following:
> > DEBUG_LOCKS_WARN_ON(lock->magic != lock)
> > ...
> > Call Trace:
> > ? __mutex_lock
> > ? __warn
> > ? __mutex_lock
> > ...
> > ? cros_ec_cmd_xfer
>
> Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
> ---
> drivers/platform/chrome/cros_ec_proto_test.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/chrome/cros_ec_proto_test.c b/drivers/platform/chrome/cros_ec_proto_test.c
> index 28f722396fc1..b6169d6f2467 100644
> --- a/drivers/platform/chrome/cros_ec_proto_test.c
> +++ b/drivers/platform/chrome/cros_ec_proto_test.c
> @@ -2668,6 +2668,7 @@ static int cros_ec_proto_test_init(struct kunit *test)
> ec_dev->dev->release = cros_ec_proto_test_release;
> ec_dev->cmd_xfer = cros_kunit_ec_xfer_mock;
> ec_dev->pkt_xfer = cros_kunit_ec_xfer_mock;
> + mutex_init(&ec_dev->lock);
>
> priv->msg = (struct cros_ec_command *)priv->_msg;
>
> --
> 2.42.0.582.g8ccd20d70d-goog
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] platform/chrome: kunit: initialize lock for fake ec_dev
2023-10-03 8:05 [PATCH] platform/chrome: kunit: initialize lock for fake ec_dev Tzung-Bi Shih
2023-10-05 2:14 ` Guenter Roeck
@ 2023-10-05 10:20 ` patchwork-bot+chrome-platform
2023-10-11 2:20 ` patchwork-bot+chrome-platform
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+chrome-platform @ 2023-10-05 10:20 UTC (permalink / raw)
To: Tzung-Bi Shih; +Cc: bleung, groeck, chrome-platform
Hello:
This patch was applied to chrome-platform/linux.git (for-kernelci)
by Tzung-Bi Shih <tzungbi@kernel.org>:
On Tue, 3 Oct 2023 08:05:04 +0000 you wrote:
> cros_ec_cmd_xfer() uses ec_dev->lock. Initialize it.
>
> Otherwise, dmesg shows the following:
> > DEBUG_LOCKS_WARN_ON(lock->magic != lock)
> > ...
> > Call Trace:
> > ? __mutex_lock
> > ? __warn
> > ? __mutex_lock
> > ...
> > ? cros_ec_cmd_xfer
>
> [...]
Here is the summary with links:
- platform/chrome: kunit: initialize lock for fake ec_dev
https://git.kernel.org/chrome-platform/c/e410b4ade83d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] platform/chrome: kunit: initialize lock for fake ec_dev
2023-10-03 8:05 [PATCH] platform/chrome: kunit: initialize lock for fake ec_dev Tzung-Bi Shih
2023-10-05 2:14 ` Guenter Roeck
2023-10-05 10:20 ` patchwork-bot+chrome-platform
@ 2023-10-11 2:20 ` patchwork-bot+chrome-platform
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+chrome-platform @ 2023-10-11 2:20 UTC (permalink / raw)
To: Tzung-Bi Shih; +Cc: bleung, groeck, chrome-platform
Hello:
This patch was applied to chrome-platform/linux.git (for-next)
by Tzung-Bi Shih <tzungbi@kernel.org>:
On Tue, 3 Oct 2023 08:05:04 +0000 you wrote:
> cros_ec_cmd_xfer() uses ec_dev->lock. Initialize it.
>
> Otherwise, dmesg shows the following:
> > DEBUG_LOCKS_WARN_ON(lock->magic != lock)
> > ...
> > Call Trace:
> > ? __mutex_lock
> > ? __warn
> > ? __mutex_lock
> > ...
> > ? cros_ec_cmd_xfer
>
> [...]
Here is the summary with links:
- platform/chrome: kunit: initialize lock for fake ec_dev
https://git.kernel.org/chrome-platform/c/e410b4ade83d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-10-11 2:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-03 8:05 [PATCH] platform/chrome: kunit: initialize lock for fake ec_dev Tzung-Bi Shih
2023-10-05 2:14 ` Guenter Roeck
2023-10-05 10:20 ` patchwork-bot+chrome-platform
2023-10-11 2:20 ` patchwork-bot+chrome-platform
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox