* [PATCH v2] media: cros-ec-cec: Add Constitution to the match table
@ 2023-09-11 8:19 Stefan Adolfsson
2023-09-11 8:22 ` Hans Verkuil
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Stefan Adolfsson @ 2023-09-11 8:19 UTC (permalink / raw)
To: Hans Verkuil
Cc: Mauro Carvalho Chehab, Benson Leung, Guenter Roeck, Reka Norman,
linux-media, chrome-platform, linux-kernel, Stefan Adolfsson
From: Stefan Adolfsson <sadolfsson@chromium.org>
Constitution has two HDMI ports which support CEC:
Port B is EC port 0
Port A is EC port 1
This patch depends on "media: cros-ec-cec: Add Dibbi to the match
table".
Signed-off-by: Stefan Adolfsson <sadolfsson@chromium.org>
---
Changes in v2:
Use a NULL-terminated conns array for the match table entry
drivers/media/cec/platform/cros-ec/cros-ec-cec.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
index 21361eff50ff..85431af65224 100644
--- a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
+++ b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
@@ -296,6 +296,7 @@ struct cec_dmi_match {
static const char *const fizz_conns[] = { "Port B", NULL };
static const char *const dibbi_conns[] = { "Port D", "Port B", NULL };
+static const char *const constitution_conns[] = { "Port B", "Port A", NULL };
static const struct cec_dmi_match cec_dmi_match_table[] = {
/* Google Fizz */
@@ -316,6 +317,8 @@ static const struct cec_dmi_match cec_dmi_match_table[] = {
{ "Google", "Lisbon", "0000:00:02.0", fizz_conns },
/* Google Dibbi */
{ "Google", "Dibbi", "0000:00:02.0", dibbi_conns },
+ /* Google Constitution */
+ { "Google", "Constitution", "0000:00:02.0", constitution_conns },
};
static struct device *cros_ec_cec_find_hdmi_dev(struct device *dev,
--
2.42.0.283.g2d96d420d3-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] media: cros-ec-cec: Add Constitution to the match table
2023-09-11 8:19 [PATCH v2] media: cros-ec-cec: Add Constitution to the match table Stefan Adolfsson
@ 2023-09-11 8:22 ` Hans Verkuil
2023-11-13 3:23 ` patchwork-bot+chrome-platform
2023-11-13 3:42 ` patchwork-bot+chrome-platform
2 siblings, 0 replies; 4+ messages in thread
From: Hans Verkuil @ 2023-09-11 8:22 UTC (permalink / raw)
To: Stefan Adolfsson
Cc: Mauro Carvalho Chehab, Benson Leung, Guenter Roeck, Reka Norman,
linux-media, chrome-platform, linux-kernel
On 11/09/2023 10:19, Stefan Adolfsson wrote:
> From: Stefan Adolfsson <sadolfsson@chromium.org>
>
> Constitution has two HDMI ports which support CEC:
> Port B is EC port 0
> Port A is EC port 1
>
> This patch depends on "media: cros-ec-cec: Add Dibbi to the match
> table".
>
> Signed-off-by: Stefan Adolfsson <sadolfsson@chromium.org>
> ---
> Changes in v2:
> Use a NULL-terminated conns array for the match table entry
>
> drivers/media/cec/platform/cros-ec/cros-ec-cec.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
> index 21361eff50ff..85431af65224 100644
> --- a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
> +++ b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
> @@ -296,6 +296,7 @@ struct cec_dmi_match {
>
> static const char *const fizz_conns[] = { "Port B", NULL };
> static const char *const dibbi_conns[] = { "Port D", "Port B", NULL };
> +static const char *const constitution_conns[] = { "Port B", "Port A", NULL };
>
> static const struct cec_dmi_match cec_dmi_match_table[] = {
> /* Google Fizz */
> @@ -316,6 +317,8 @@ static const struct cec_dmi_match cec_dmi_match_table[] = {
> { "Google", "Lisbon", "0000:00:02.0", fizz_conns },
> /* Google Dibbi */
> { "Google", "Dibbi", "0000:00:02.0", dibbi_conns },
> + /* Google Constitution */
> + { "Google", "Constitution", "0000:00:02.0", constitution_conns },
> };
>
> static struct device *cros_ec_cec_find_hdmi_dev(struct device *dev,
I made that change myself when I merged your v1 patch. So I just mark this
v2 as Obsolete in patchwork.
Regards,
Hans
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] media: cros-ec-cec: Add Constitution to the match table
2023-09-11 8:19 [PATCH v2] media: cros-ec-cec: Add Constitution to the match table Stefan Adolfsson
2023-09-11 8:22 ` Hans Verkuil
@ 2023-11-13 3:23 ` patchwork-bot+chrome-platform
2023-11-13 3:42 ` patchwork-bot+chrome-platform
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+chrome-platform @ 2023-11-13 3:23 UTC (permalink / raw)
To: Stefan Adolfsson
Cc: hverkuil-cisco, mchehab, bleung, groeck, rekanorman, linux-media,
chrome-platform, linux-kernel
Hello:
This patch was applied to chrome-platform/linux.git (for-kernelci)
by Hans Verkuil <hverkuil-cisco@xs4all.nl>:
On Mon, 11 Sep 2023 10:19:21 +0200 you wrote:
> From: Stefan Adolfsson <sadolfsson@chromium.org>
>
> Constitution has two HDMI ports which support CEC:
> Port B is EC port 0
> Port A is EC port 1
>
> This patch depends on "media: cros-ec-cec: Add Dibbi to the match
> table".
>
> [...]
Here is the summary with links:
- [v2] media: cros-ec-cec: Add Constitution to the match table
https://git.kernel.org/chrome-platform/c/5bc2de5f517d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] media: cros-ec-cec: Add Constitution to the match table
2023-09-11 8:19 [PATCH v2] media: cros-ec-cec: Add Constitution to the match table Stefan Adolfsson
2023-09-11 8:22 ` Hans Verkuil
2023-11-13 3:23 ` patchwork-bot+chrome-platform
@ 2023-11-13 3:42 ` patchwork-bot+chrome-platform
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+chrome-platform @ 2023-11-13 3:42 UTC (permalink / raw)
To: Stefan Adolfsson
Cc: hverkuil-cisco, mchehab, bleung, groeck, rekanorman, linux-media,
chrome-platform, linux-kernel
Hello:
This patch was applied to chrome-platform/linux.git (for-next)
by Hans Verkuil <hverkuil-cisco@xs4all.nl>:
On Mon, 11 Sep 2023 10:19:21 +0200 you wrote:
> From: Stefan Adolfsson <sadolfsson@chromium.org>
>
> Constitution has two HDMI ports which support CEC:
> Port B is EC port 0
> Port A is EC port 1
>
> This patch depends on "media: cros-ec-cec: Add Dibbi to the match
> table".
>
> [...]
Here is the summary with links:
- [v2] media: cros-ec-cec: Add Constitution to the match table
https://git.kernel.org/chrome-platform/c/5bc2de5f517d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-11-13 3:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-11 8:19 [PATCH v2] media: cros-ec-cec: Add Constitution to the match table Stefan Adolfsson
2023-09-11 8:22 ` Hans Verkuil
2023-11-13 3:23 ` patchwork-bot+chrome-platform
2023-11-13 3:42 ` patchwork-bot+chrome-platform
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox