[1/2] media: platform: cros-ec: Rename conns array for the match table

[1/2] media: platform: cros-ec: Rename conns array for the match table

[Ken Lin]

Rename conns array to port_**_conns, ** is the ports which support cec.
ex: dibbi_conns support Port D and B will be renamed to port_db_conns.
Make it much cleaner and readable.

Signed-off-by: Ken Lin <ken_lin5@hotmail.com>
---

 .../media/cec/platform/cros-ec/cros-ec-cec.c  | 30 +++++++++----------
 1 file changed, 15 insertions(+), 15 deletions(-)

diff --git a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
index 920aed0d1929..dbee25b138ff 100644
--- a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
+++ b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
@@ -294,34 +294,34 @@ struct cec_dmi_match {
 	const char *const *conns;
 };
 
-static const char *const fizz_conns[] = { "Port B", NULL };
-static const char *const dibbi_conns[] = { "Port D", "Port B", NULL };
-static const char *const constitution_conns[] = { "Port B", "Port A", NULL };
-static const char *const boxy_conns[] = { "Port D", NULL };
+static const char *const port_b_conns[] = { "Port B", NULL };
+static const char *const port_db_conns[] = { "Port D", "Port B", NULL };
+static const char *const port_ba_conns[] = { "Port B", "Port A", NULL };
+static const char *const port_d_conns[] = { "Port D", NULL };
 
 static const struct cec_dmi_match cec_dmi_match_table[] = {
 	/* Google Fizz */
-	{ "Google", "Fizz", "0000:00:02.0", fizz_conns },
+	{ "Google", "Fizz", "0000:00:02.0", port_b_conns },
 	/* Google Brask */
-	{ "Google", "Brask", "0000:00:02.0", fizz_conns },
+	{ "Google", "Brask", "0000:00:02.0", port_b_conns },
 	/* Google Moli */
-	{ "Google", "Moli", "0000:00:02.0", fizz_conns },
+	{ "Google", "Moli", "0000:00:02.0", port_b_conns },
 	/* Google Kinox */
-	{ "Google", "Kinox", "0000:00:02.0", fizz_conns },
+	{ "Google", "Kinox", "0000:00:02.0", port_b_conns },
 	/* Google Kuldax */
-	{ "Google", "Kuldax", "0000:00:02.0", fizz_conns },
+	{ "Google", "Kuldax", "0000:00:02.0", port_b_conns },
 	/* Google Aurash */
-	{ "Google", "Aurash", "0000:00:02.0", fizz_conns },
+	{ "Google", "Aurash", "0000:00:02.0", port_b_conns },
 	/* Google Gladios */
-	{ "Google", "Gladios", "0000:00:02.0", fizz_conns },
+	{ "Google", "Gladios", "0000:00:02.0", port_b_conns },
 	/* Google Lisbon */
-	{ "Google", "Lisbon", "0000:00:02.0", fizz_conns },
+	{ "Google", "Lisbon", "0000:00:02.0", port_b_conns },
 	/* Google Dibbi */
-	{ "Google", "Dibbi", "0000:00:02.0", dibbi_conns },
+	{ "Google", "Dibbi", "0000:00:02.0", port_db_conns },
 	/* Google Constitution */
-	{ "Google", "Constitution", "0000:00:02.0", constitution_conns },
+	{ "Google", "Constitution", "0000:00:02.0", port_ba_conns },
 	/* Google Boxy */
-	{ "Google", "Boxy", "0000:00:02.0", boxy_conns },
+	{ "Google", "Boxy", "0000:00:02.0", port_d_conns },
 };
 
 static struct device *cros_ec_cec_find_hdmi_dev(struct device *dev,
-- 
2.25.1

Re: [1/2] media: platform: cros-ec: Rename conns array for the match table

[Uwe Kleine-König]

[-- Attachment #1: Type: text/plain, Size: 946 bytes --]

Hello,

On Thu, Oct 05, 2023 at 09:38:40AM +0800, Ken Lin wrote:
> Rename conns array to port_**_conns, ** is the ports which support cec.
> ex: dibbi_conns support Port D and B will be renamed to port_db_conns.
> Make it much cleaner and readable.
> 
> Signed-off-by: Ken Lin <ken_lin5@hotmail.com>
> ---

Two procedural hints:

Please send patch series in a way that they form a thread. git
send-email should get this right. Patch 2/2 is completely separate
from this patch which might make it harder for maintainers to apply
your patches

This patch doesn't fit on current mainline. It's a good idea to use
the --base parameter for git format-patch or to explicitly mention the
tree you based your patches on. (Ok, found it, it fits on next.)

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [1/2] media: platform: cros-ec: Rename conns array for the match table

[patchwork-bot+chrome-platform]

Hello:

This series was applied to chrome-platform/linux.git (for-kernelci)
by Hans Verkuil <hverkuil-cisco@xs4all.nl>:

On Thu,  5 Oct 2023 09:38:40 +0800 you wrote:
> Rename conns array to port_**_conns, ** is the ports which support cec.
> ex: dibbi_conns support Port D and B will be renamed to port_db_conns.
> Make it much cleaner and readable.
> 
> Signed-off-by: Ken Lin <ken_lin5@hotmail.com>
> ---
> 
> [...]

Here is the summary with links:
  - [1/2] media: platform: cros-ec: Rename conns array for the match table
    https://git.kernel.org/chrome-platform/c/678e8d804149
  - [2/2] media: platform: cros-ec: Add Taranza to the match table
    https://git.kernel.org/chrome-platform/c/cd5c11d5aacd

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Re: [1/2] media: platform: cros-ec: Rename conns array for the match table

[patchwork-bot+chrome-platform]

Hello:

This series was applied to chrome-platform/linux.git (for-next)
by Hans Verkuil <hverkuil-cisco@xs4all.nl>:

On Thu,  5 Oct 2023 09:38:40 +0800 you wrote:
> Rename conns array to port_**_conns, ** is the ports which support cec.
> ex: dibbi_conns support Port D and B will be renamed to port_db_conns.
> Make it much cleaner and readable.
> 
> Signed-off-by: Ken Lin <ken_lin5@hotmail.com>
> ---
> 
> [...]

Here is the summary with links:
  - [1/2] media: platform: cros-ec: Rename conns array for the match table
    https://git.kernel.org/chrome-platform/c/678e8d804149
  - [2/2] media: platform: cros-ec: Add Taranza to the match table
    https://git.kernel.org/chrome-platform/c/cd5c11d5aacd

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html