* [PATCH] platform/chrome: cros_ec: let cros_ec_suspend() call cros_ec_suspend_*
@ 2024-04-30 2:09 Tzung-Bi Shih
2024-05-14 19:47 ` Prashant Malani
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Tzung-Bi Shih @ 2024-04-30 2:09 UTC (permalink / raw)
To: bleung, groeck; +Cc: tzungbi, chrome-platform
After commit 2fbe479c0024 ("platform/chrome: cros_ec: Handle events
during suspend after resume completion"), cros_ec_resume() starts to
call cros_ec_resume_early() and cros_ec_resume_complete().
To be neat, let cros_ec_suspend() call cros_ec_suspend_prepare() and
cros_ec_suspend_late().
Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
---
drivers/platform/chrome/cros_ec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/chrome/cros_ec.c b/drivers/platform/chrome/cros_ec.c
index 47d19f7e295a..e821b3d39590 100644
--- a/drivers/platform/chrome/cros_ec.c
+++ b/drivers/platform/chrome/cros_ec.c
@@ -388,8 +388,8 @@ EXPORT_SYMBOL(cros_ec_suspend_late);
*/
int cros_ec_suspend(struct cros_ec_device *ec_dev)
{
- cros_ec_send_suspend_event(ec_dev);
- cros_ec_disable_irq(ec_dev);
+ cros_ec_suspend_prepare(ec_dev);
+ cros_ec_suspend_late(ec_dev);
return 0;
}
EXPORT_SYMBOL(cros_ec_suspend);
--
2.44.0.769.g3c40516874-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] platform/chrome: cros_ec: let cros_ec_suspend() call cros_ec_suspend_*
2024-04-30 2:09 [PATCH] platform/chrome: cros_ec: let cros_ec_suspend() call cros_ec_suspend_* Tzung-Bi Shih
@ 2024-05-14 19:47 ` Prashant Malani
2024-05-27 3:10 ` patchwork-bot+chrome-platform
2024-05-27 3:10 ` patchwork-bot+chrome-platform
2 siblings, 0 replies; 4+ messages in thread
From: Prashant Malani @ 2024-05-14 19:47 UTC (permalink / raw)
To: Tzung-Bi Shih; +Cc: bleung, groeck, chrome-platform
On Mon, Apr 29, 2024 at 7:09 PM Tzung-Bi Shih <tzungbi@kernel.org> wrote:
>
> After commit 2fbe479c0024 ("platform/chrome: cros_ec: Handle events
> during suspend after resume completion"), cros_ec_resume() starts to
> call cros_ec_resume_early() and cros_ec_resume_complete().
>
> To be neat, let cros_ec_suspend() call cros_ec_suspend_prepare() and
> cros_ec_suspend_late().
>
> Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
Reviewed-by: Prashant Malani <pmalani@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] platform/chrome: cros_ec: let cros_ec_suspend() call cros_ec_suspend_*
2024-04-30 2:09 [PATCH] platform/chrome: cros_ec: let cros_ec_suspend() call cros_ec_suspend_* Tzung-Bi Shih
2024-05-14 19:47 ` Prashant Malani
@ 2024-05-27 3:10 ` patchwork-bot+chrome-platform
2024-05-27 3:10 ` patchwork-bot+chrome-platform
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+chrome-platform @ 2024-05-27 3:10 UTC (permalink / raw)
To: Tzung-Bi Shih; +Cc: bleung, groeck, chrome-platform
Hello:
This patch was applied to chrome-platform/linux.git (for-kernelci)
by Tzung-Bi Shih <tzungbi@kernel.org>:
On Tue, 30 Apr 2024 10:09:24 +0800 you wrote:
> After commit 2fbe479c0024 ("platform/chrome: cros_ec: Handle events
> during suspend after resume completion"), cros_ec_resume() starts to
> call cros_ec_resume_early() and cros_ec_resume_complete().
>
> To be neat, let cros_ec_suspend() call cros_ec_suspend_prepare() and
> cros_ec_suspend_late().
>
> [...]
Here is the summary with links:
- platform/chrome: cros_ec: let cros_ec_suspend() call cros_ec_suspend_*
https://git.kernel.org/chrome-platform/c/47ef58cdbd7f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] platform/chrome: cros_ec: let cros_ec_suspend() call cros_ec_suspend_*
2024-04-30 2:09 [PATCH] platform/chrome: cros_ec: let cros_ec_suspend() call cros_ec_suspend_* Tzung-Bi Shih
2024-05-14 19:47 ` Prashant Malani
2024-05-27 3:10 ` patchwork-bot+chrome-platform
@ 2024-05-27 3:10 ` patchwork-bot+chrome-platform
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+chrome-platform @ 2024-05-27 3:10 UTC (permalink / raw)
To: Tzung-Bi Shih; +Cc: bleung, groeck, chrome-platform
Hello:
This patch was applied to chrome-platform/linux.git (for-next)
by Tzung-Bi Shih <tzungbi@kernel.org>:
On Tue, 30 Apr 2024 10:09:24 +0800 you wrote:
> After commit 2fbe479c0024 ("platform/chrome: cros_ec: Handle events
> during suspend after resume completion"), cros_ec_resume() starts to
> call cros_ec_resume_early() and cros_ec_resume_complete().
>
> To be neat, let cros_ec_suspend() call cros_ec_suspend_prepare() and
> cros_ec_suspend_late().
>
> [...]
Here is the summary with links:
- platform/chrome: cros_ec: let cros_ec_suspend() call cros_ec_suspend_*
https://git.kernel.org/chrome-platform/c/47ef58cdbd7f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-05-27 3:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-30 2:09 [PATCH] platform/chrome: cros_ec: let cros_ec_suspend() call cros_ec_suspend_* Tzung-Bi Shih
2024-05-14 19:47 ` Prashant Malani
2024-05-27 3:10 ` patchwork-bot+chrome-platform
2024-05-27 3:10 ` patchwork-bot+chrome-platform
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox