* [PATCH] platform/chrome: cros_ec_debugfs: fix wrong EC message version
@ 2024-06-11 11:31 Tzung-Bi Shih
2024-06-11 16:07 ` Guenter Roeck
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Tzung-Bi Shih @ 2024-06-11 11:31 UTC (permalink / raw)
To: bleung, groeck; +Cc: tzungbi, chrome-platform, stable
ec_read_version_supported() uses ec_params_get_cmd_versions_v1 but it
wrongly uses message version 0.
Fix it.
Cc: stable@vger.kernel.org
Fixes: e86264595225 ("mfd: cros_ec: add debugfs, console log file")
Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
---
drivers/platform/chrome/cros_ec_debugfs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/chrome/cros_ec_debugfs.c b/drivers/platform/chrome/cros_ec_debugfs.c
index f0e9efb543df..4525ad1b59f4 100644
--- a/drivers/platform/chrome/cros_ec_debugfs.c
+++ b/drivers/platform/chrome/cros_ec_debugfs.c
@@ -334,6 +334,7 @@ static int ec_read_version_supported(struct cros_ec_dev *ec)
if (!msg)
return 0;
+ msg->version = 1;
msg->command = EC_CMD_GET_CMD_VERSIONS + ec->cmd_offset;
msg->outsize = sizeof(*params);
msg->insize = sizeof(*response);
--
2.45.2.505.gda0bf45e8d-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] platform/chrome: cros_ec_debugfs: fix wrong EC message version
2024-06-11 11:31 [PATCH] platform/chrome: cros_ec_debugfs: fix wrong EC message version Tzung-Bi Shih
@ 2024-06-11 16:07 ` Guenter Roeck
2024-06-12 2:30 ` patchwork-bot+chrome-platform
2024-06-12 2:30 ` patchwork-bot+chrome-platform
2 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2024-06-11 16:07 UTC (permalink / raw)
To: Tzung-Bi Shih; +Cc: bleung, groeck, chrome-platform, stable
On Tue, Jun 11, 2024 at 4:31 AM Tzung-Bi Shih <tzungbi@kernel.org> wrote:
>
> ec_read_version_supported() uses ec_params_get_cmd_versions_v1 but it
> wrongly uses message version 0.
>
> Fix it.
>
> Cc: stable@vger.kernel.org
> Fixes: e86264595225 ("mfd: cros_ec: add debugfs, console log file")
> Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
> ---
> drivers/platform/chrome/cros_ec_debugfs.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/chrome/cros_ec_debugfs.c b/drivers/platform/chrome/cros_ec_debugfs.c
> index f0e9efb543df..4525ad1b59f4 100644
> --- a/drivers/platform/chrome/cros_ec_debugfs.c
> +++ b/drivers/platform/chrome/cros_ec_debugfs.c
> @@ -334,6 +334,7 @@ static int ec_read_version_supported(struct cros_ec_dev *ec)
> if (!msg)
> return 0;
>
> + msg->version = 1;
> msg->command = EC_CMD_GET_CMD_VERSIONS + ec->cmd_offset;
> msg->outsize = sizeof(*params);
> msg->insize = sizeof(*response);
> --
> 2.45.2.505.gda0bf45e8d-goog
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] platform/chrome: cros_ec_debugfs: fix wrong EC message version
2024-06-11 11:31 [PATCH] platform/chrome: cros_ec_debugfs: fix wrong EC message version Tzung-Bi Shih
2024-06-11 16:07 ` Guenter Roeck
@ 2024-06-12 2:30 ` patchwork-bot+chrome-platform
2024-06-12 2:30 ` patchwork-bot+chrome-platform
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+chrome-platform @ 2024-06-12 2:30 UTC (permalink / raw)
To: Tzung-Bi Shih; +Cc: bleung, groeck, chrome-platform, stable
Hello:
This patch was applied to chrome-platform/linux.git (for-kernelci)
by Tzung-Bi Shih <tzungbi@kernel.org>:
On Tue, 11 Jun 2024 11:31:10 +0000 you wrote:
> ec_read_version_supported() uses ec_params_get_cmd_versions_v1 but it
> wrongly uses message version 0.
>
> Fix it.
>
> Cc: stable@vger.kernel.org
> Fixes: e86264595225 ("mfd: cros_ec: add debugfs, console log file")
> Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
>
> [...]
Here is the summary with links:
- platform/chrome: cros_ec_debugfs: fix wrong EC message version
https://git.kernel.org/chrome-platform/c/c2a28647bbb4
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] platform/chrome: cros_ec_debugfs: fix wrong EC message version
2024-06-11 11:31 [PATCH] platform/chrome: cros_ec_debugfs: fix wrong EC message version Tzung-Bi Shih
2024-06-11 16:07 ` Guenter Roeck
2024-06-12 2:30 ` patchwork-bot+chrome-platform
@ 2024-06-12 2:30 ` patchwork-bot+chrome-platform
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+chrome-platform @ 2024-06-12 2:30 UTC (permalink / raw)
To: Tzung-Bi Shih; +Cc: bleung, groeck, chrome-platform, stable
Hello:
This patch was applied to chrome-platform/linux.git (for-next)
by Tzung-Bi Shih <tzungbi@kernel.org>:
On Tue, 11 Jun 2024 11:31:10 +0000 you wrote:
> ec_read_version_supported() uses ec_params_get_cmd_versions_v1 but it
> wrongly uses message version 0.
>
> Fix it.
>
> Cc: stable@vger.kernel.org
> Fixes: e86264595225 ("mfd: cros_ec: add debugfs, console log file")
> Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
>
> [...]
Here is the summary with links:
- platform/chrome: cros_ec_debugfs: fix wrong EC message version
https://git.kernel.org/chrome-platform/c/c2a28647bbb4
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-06-12 2:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-11 11:31 [PATCH] platform/chrome: cros_ec_debugfs: fix wrong EC message version Tzung-Bi Shih
2024-06-11 16:07 ` Guenter Roeck
2024-06-12 2:30 ` patchwork-bot+chrome-platform
2024-06-12 2:30 ` patchwork-bot+chrome-platform
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox