From: Tzung-Bi Shih <tzungbi@kernel.org>
To: bleung@chromium.org, groeck@chromium.org
Cc: chrome-platform@lists.linux.dev, tzungbi@kernel.org,
markhas@chromium.org, bhanumaiya@chromium.org, error27@gmail.com
Subject: [PATCH] platform/chrome: cros_ec_uart: fix negative type promoted to high
Date: Mon, 9 Jan 2023 16:15:54 +0800 [thread overview]
Message-ID: <20230109081554.3792547-1-tzungbi@kernel.org> (raw)
serdev_device_write_buf() returns negative numbers on errors. When
the return value compares to unsigned integer `len`, it promotes to
quite large positive number.
Fix it.
Fixes: 04a8bdd135cc ("platform/chrome: cros_ec_uart: Add transport layer")
Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
---
Reported in https://lore.kernel.org/chrome-platform/Y7fhw4S7Tb0GcHMF@kili/T/#u.
drivers/platform/chrome/cros_ec_uart.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/chrome/cros_ec_uart.c b/drivers/platform/chrome/cros_ec_uart.c
index 6916069f1599..788246559bbb 100644
--- a/drivers/platform/chrome/cros_ec_uart.c
+++ b/drivers/platform/chrome/cros_ec_uart.c
@@ -149,9 +149,10 @@ static int cros_ec_uart_pkt_xfer(struct cros_ec_device *ec_dev,
resp->status = 0;
ret = serdev_device_write_buf(serdev, ec_dev->dout, len);
- if (ret < len) {
+ if (ret < 0 || ret < len) {
dev_err(ec_dev->dev, "Unable to write data\n");
- ret = -EIO;
+ if (ret >= 0)
+ ret = -EIO;
goto exit;
}
--
2.39.0.314.g84b9a713c41-goog
next reply other threads:[~2023-01-09 8:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 8:15 Tzung-Bi Shih [this message]
2023-01-09 18:51 ` [PATCH] platform/chrome: cros_ec_uart: fix negative type promoted to high Mark Hasemeyer
2023-01-10 3:27 ` Tzung-Bi Shih
2023-01-17 8:12 ` Tzung-Bi Shih
2023-01-17 8:19 ` Dan Carpenter
2023-01-17 14:45 ` Benson Leung
2023-01-18 3:00 ` patchwork-bot+chrome-platform
2023-01-18 6:20 ` patchwork-bot+chrome-platform
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230109081554.3792547-1-tzungbi@kernel.org \
--to=tzungbi@kernel.org \
--cc=bhanumaiya@chromium.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=error27@gmail.com \
--cc=groeck@chromium.org \
--cc=markhas@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox