From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Mark Hasemeyer <markhas@chromium.org>
Cc: bleung@chromium.org, groeck@chromium.org,
chrome-platform@lists.linux.dev, bhanumaiya@chromium.org,
error27@gmail.com
Subject: Re: [PATCH] platform/chrome: cros_ec_uart: fix negative type promoted to high
Date: Tue, 10 Jan 2023 11:27:13 +0800 [thread overview]
Message-ID: <Y7zbEdGeFBxsttQU@google.com> (raw)
In-Reply-To: <CANg-bXANdV=EpDu2Zn0BJh5s6cJPYRxyjmVfbWUQ0CufC9CuSA@mail.gmail.com>
On Mon, Jan 09, 2023 at 11:51:56AM -0700, Mark Hasemeyer wrote:
> > 175 if (host_response->data_len > ec_msg->insize) {
> > 176 dev_err(ec_dev->dev, "Resp too long (%d bytes, expected %d)\n",
> > 177 host_response->data_len, ec_msg->insize);
> > 178 ret = -ENOSPC;
> >
> > ret = -EINVAL; (Unless you are discussing harddrives).
> >
> > 179 goto exit;
> > 180 }
> The report also suggested modifying the return value if a response packet is too
> long.
Replied on the original mail. Let's discuss the case there if possible.
next prev parent reply other threads:[~2023-01-10 3:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 8:15 [PATCH] platform/chrome: cros_ec_uart: fix negative type promoted to high Tzung-Bi Shih
2023-01-09 18:51 ` Mark Hasemeyer
2023-01-10 3:27 ` Tzung-Bi Shih [this message]
2023-01-17 8:12 ` Tzung-Bi Shih
2023-01-17 8:19 ` Dan Carpenter
2023-01-17 14:45 ` Benson Leung
2023-01-18 3:00 ` patchwork-bot+chrome-platform
2023-01-18 6:20 ` patchwork-bot+chrome-platform
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7zbEdGeFBxsttQU@google.com \
--to=tzungbi@kernel.org \
--cc=bhanumaiya@chromium.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=error27@gmail.com \
--cc=groeck@chromium.org \
--cc=markhas@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox