* [PATCH v1 07/14] hwmon:: Use non-OF thermal cooling device register function [not found] <20260419182203.4083985-1-daniel.lezcano@oss.qualcomm.com> @ 2026-04-19 18:21 ` Daniel Lezcano 2026-04-22 11:59 ` Guenter Roeck 0 siblings, 1 reply; 3+ messages in thread From: Daniel Lezcano @ 2026-04-19 18:21 UTC (permalink / raw) To: rafael Cc: gaurav.kohli, Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Lucas Stach, Russell King, Christian Gmeiner, David Airlie, Simona Vetter, Guenter Roeck, Joel Stanley, Andrew Jeffery, Thomas Weißschuh, Benson Leung, Pali Rohár, Avi Fishman, Tomer Maimon, Tali Perry, Patrick Venture, Nancy Yuen, Benjamin Fair, Heiko Stuebner, Thierry Reding, Jonathan Hunter, Bjorn Andersson, Konrad Dybcio, Amit Daniel Kachhap, Viresh Kumar, Neil Armstrong, Amit Kucheria, linux-pm, linux-kernel, linux-hwmon, open list:CHROMEOS EC HARDWARE MONITORING Make HWMON drivers which are not based on device tree to use the corresponding non-OF functions. Signed-off-by: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com> --- drivers/hwmon/cros_ec_hwmon.c | 4 ++-- drivers/hwmon/dell-smm-hwmon.c | 4 ++-- drivers/hwmon/mlxreg-fan.c | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/hwmon/cros_ec_hwmon.c b/drivers/hwmon/cros_ec_hwmon.c index 6cf5ab0f4b73..77dd9f28962d 100644 --- a/drivers/hwmon/cros_ec_hwmon.c +++ b/drivers/hwmon/cros_ec_hwmon.c @@ -532,8 +532,8 @@ static void cros_ec_hwmon_register_fan_cooling_devices(struct device *dev, cpriv->hwmon_priv = priv; cpriv->index = i; - cdev = devm_thermal_of_cooling_device_register(dev, NULL, type, cpriv, - &cros_ec_thermal_cooling_ops); + cdev = devm_thermal_cooling_device_register(dev, type, cpriv, + &cros_ec_thermal_cooling_ops); if (IS_ERR(cdev)) { dev_warn(dev, "failed to register fan %zu as a cooling device: %pe\n", i, cdev); diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c index 038edffc1ac7..47b373ea6db4 100644 --- a/drivers/hwmon/dell-smm-hwmon.c +++ b/drivers/hwmon/dell-smm-hwmon.c @@ -1161,8 +1161,8 @@ static int dell_smm_init_cdev(struct device *dev, u8 fan_num) if (cdata) { cdata->fan_num = fan_num; cdata->data = data; - cdev = devm_thermal_of_cooling_device_register(dev, NULL, name, cdata, - &dell_smm_cooling_ops); + cdev = devm_thermal_cooling_device_register(dev, name, cdata, + &dell_smm_cooling_ops); if (IS_ERR(cdev)) { devm_kfree(dev, cdata); ret = PTR_ERR(cdev); diff --git a/drivers/hwmon/mlxreg-fan.c b/drivers/hwmon/mlxreg-fan.c index 137a90dd2075..860de6cfd8a4 100644 --- a/drivers/hwmon/mlxreg-fan.c +++ b/drivers/hwmon/mlxreg-fan.c @@ -583,8 +583,8 @@ static int mlxreg_fan_cooling_config(struct device *dev, struct mlxreg_fan *fan) pwm->fan = fan; /* Set minimal PWM speed. */ pwm->last_hwmon_state = MLXREG_FAN_PWM_DUTY2STATE(MLXREG_FAN_MIN_DUTY); - pwm->cdev = devm_thermal_of_cooling_device_register(dev, NULL, mlxreg_fan_name[i], - pwm, &mlxreg_fan_cooling_ops); + pwm->cdev = devm_thermal_cooling_device_register(dev, mlxreg_fan_name[i], + pwm, &mlxreg_fan_cooling_ops); if (IS_ERR(pwm->cdev)) { dev_err(dev, "Failed to register cooling device\n"); return PTR_ERR(pwm->cdev); -- 2.43.0 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1 07/14] hwmon:: Use non-OF thermal cooling device register function 2026-04-19 18:21 ` [PATCH v1 07/14] hwmon:: Use non-OF thermal cooling device register function Daniel Lezcano @ 2026-04-22 11:59 ` Guenter Roeck 2026-04-22 15:43 ` Daniel Lezcano 0 siblings, 1 reply; 3+ messages in thread From: Guenter Roeck @ 2026-04-22 11:59 UTC (permalink / raw) To: Daniel Lezcano, rafael Cc: gaurav.kohli, Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Lucas Stach, Russell King, Christian Gmeiner, David Airlie, Simona Vetter, Joel Stanley, Andrew Jeffery, Thomas Weißschuh, Benson Leung, Pali Rohár, Avi Fishman, Tomer Maimon, Tali Perry, Patrick Venture, Nancy Yuen, Benjamin Fair, Heiko Stuebner, Thierry Reding, Jonathan Hunter, Bjorn Andersson, Konrad Dybcio, Amit Daniel Kachhap, Viresh Kumar, Neil Armstrong, Amit Kucheria, linux-pm, linux-kernel, linux-hwmon, open list:CHROMEOS EC HARDWARE MONITORING On 4/19/26 11:21, Daniel Lezcano wrote: > Make HWMON drivers which are not based on device tree to use the > corresponding non-OF functions. > > Signed-off-by: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com> Acked-by: Guenter Roeck <linux@roeck-us.net> > --- > drivers/hwmon/cros_ec_hwmon.c | 4 ++-- > drivers/hwmon/dell-smm-hwmon.c | 4 ++-- > drivers/hwmon/mlxreg-fan.c | 4 ++-- > 3 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/hwmon/cros_ec_hwmon.c b/drivers/hwmon/cros_ec_hwmon.c > index 6cf5ab0f4b73..77dd9f28962d 100644 > --- a/drivers/hwmon/cros_ec_hwmon.c > +++ b/drivers/hwmon/cros_ec_hwmon.c > @@ -532,8 +532,8 @@ static void cros_ec_hwmon_register_fan_cooling_devices(struct device *dev, > > cpriv->hwmon_priv = priv; > cpriv->index = i; > - cdev = devm_thermal_of_cooling_device_register(dev, NULL, type, cpriv, > - &cros_ec_thermal_cooling_ops); > + cdev = devm_thermal_cooling_device_register(dev, type, cpriv, > + &cros_ec_thermal_cooling_ops); > if (IS_ERR(cdev)) { > dev_warn(dev, "failed to register fan %zu as a cooling device: %pe\n", i, > cdev); > diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c > index 038edffc1ac7..47b373ea6db4 100644 > --- a/drivers/hwmon/dell-smm-hwmon.c > +++ b/drivers/hwmon/dell-smm-hwmon.c > @@ -1161,8 +1161,8 @@ static int dell_smm_init_cdev(struct device *dev, u8 fan_num) > if (cdata) { > cdata->fan_num = fan_num; > cdata->data = data; > - cdev = devm_thermal_of_cooling_device_register(dev, NULL, name, cdata, > - &dell_smm_cooling_ops); > + cdev = devm_thermal_cooling_device_register(dev, name, cdata, > + &dell_smm_cooling_ops); > if (IS_ERR(cdev)) { > devm_kfree(dev, cdata); > ret = PTR_ERR(cdev); > diff --git a/drivers/hwmon/mlxreg-fan.c b/drivers/hwmon/mlxreg-fan.c > index 137a90dd2075..860de6cfd8a4 100644 > --- a/drivers/hwmon/mlxreg-fan.c > +++ b/drivers/hwmon/mlxreg-fan.c > @@ -583,8 +583,8 @@ static int mlxreg_fan_cooling_config(struct device *dev, struct mlxreg_fan *fan) > pwm->fan = fan; > /* Set minimal PWM speed. */ > pwm->last_hwmon_state = MLXREG_FAN_PWM_DUTY2STATE(MLXREG_FAN_MIN_DUTY); > - pwm->cdev = devm_thermal_of_cooling_device_register(dev, NULL, mlxreg_fan_name[i], > - pwm, &mlxreg_fan_cooling_ops); > + pwm->cdev = devm_thermal_cooling_device_register(dev, mlxreg_fan_name[i], > + pwm, &mlxreg_fan_cooling_ops); > if (IS_ERR(pwm->cdev)) { > dev_err(dev, "Failed to register cooling device\n"); > return PTR_ERR(pwm->cdev); ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 07/14] hwmon:: Use non-OF thermal cooling device register function 2026-04-22 11:59 ` Guenter Roeck @ 2026-04-22 15:43 ` Daniel Lezcano 0 siblings, 0 replies; 3+ messages in thread From: Daniel Lezcano @ 2026-04-22 15:43 UTC (permalink / raw) To: Guenter Roeck, rafael Cc: gaurav.kohli, Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Lucas Stach, Russell King, Christian Gmeiner, David Airlie, Simona Vetter, Joel Stanley, Andrew Jeffery, Thomas Weißschuh, Benson Leung, Pali Rohár, Avi Fishman, Tomer Maimon, Tali Perry, Patrick Venture, Nancy Yuen, Benjamin Fair, Heiko Stuebner, Thierry Reding, Jonathan Hunter, Bjorn Andersson, Konrad Dybcio, Amit Daniel Kachhap, Viresh Kumar, Neil Armstrong, Amit Kucheria, linux-pm, linux-kernel, linux-hwmon, open list:CHROMEOS EC HARDWARE MONITORING On 4/22/26 13:59, Guenter Roeck wrote: > On 4/19/26 11:21, Daniel Lezcano wrote: >> Make HWMON drivers which are not based on device tree to use the >> corresponding non-OF functions. >> >> Signed-off-by: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com> > > Acked-by: Guenter Roeck <linux@roeck-us.net> Thanks for the review ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-04-22 15:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20260419182203.4083985-1-daniel.lezcano@oss.qualcomm.com>
2026-04-19 18:21 ` [PATCH v1 07/14] hwmon:: Use non-OF thermal cooling device register function Daniel Lezcano
2026-04-22 11:59 ` Guenter Roeck
2026-04-22 15:43 ` Daniel Lezcano
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox