Re: [PATCH] platform/chrome: cros_kbd_led_backlight: support Google Link

[Brandon Casey <drafnel@gmail.com>]

On November 14, 2024 2:53:47 AM CST, Tzung-Bi Shih <tzungbi@kernel.org> wrote:
>On Wed, Nov 13, 2024 at 10:38:36PM -0600, Brandon Casey wrote:

>> I can only assume that Google did not ever ship a firmware update
>> for Link that included that patch. I believe this device has all
>> ChromeOS updates applied, so it represents a stock
>> system, though no longer supported, and aside from being in
>> developer mode and having a Linux partition.

>Please try to wrap your message to fit to 80-column.  See [2].

Sorry about that. I didn't realize my email client was doing that.

>> Is there any reason why we shouldn't do the same thing here for the 
>> keyboard backlight that was done in drivers/platform/chrome/chromeos_acpi.c
>> and support both the legacy ID and the official ACPI ID? I see your
>> commit 703e77134 which added GOOG0016 in addition to GGL0001.
>
>- The most important reason: "GGL0002" is assigned to other purpose.

Ah, so this seems to be the crux of it :-(

>- For some reason, your machine is using a quite old firmware.  It makes
>  less sense to me for supporting a should-be-deprecated PNP ID by [1].

You seem to be suggesting that my machine is in some odd/abnormal state.
Do you know whether Google has actually ever pushed an updated firmware
for this device (LINK) that included the patch referenced in [1]? If not, then
shouldn't my machine be considered to be in the "normal" state, not the
oddity?

-Brandon