From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Brandon Casey <drafnel@gmail.com>
Cc: bleung@chromium.org, chrome-platform@lists.linux.dev
Subject: Re: [PATCH] platform/chrome: cros_kbd_led_backlight: support Google Link
Date: Thu, 14 Nov 2024 02:07:42 +0000 [thread overview]
Message-ID: <ZzVbbh86elpYQG5s@google.com> (raw)
In-Reply-To: <B7B50D15-7465-4370-8D82-47C75A16A3AC@gmail.com>
On Wed, Nov 13, 2024 at 02:44:55AM -0600, Brandon Casey wrote:
>
>
> On November 13, 2024 12:46:18 AM CST, Tzung-Bi Shih <tzungbi@kernel.org> wrote:
> >On Tue, Nov 12, 2024 at 08:29:05PM -0600, Brandon Casey wrote:
> >> On the Google Pixel chromebook (aka Google Link), the keyboard led
> >> backlight has the ACPI device id "GGL0002". Let's add it to the
> >> configuration array.
> >
> >Why it can't be matched by "GOOG0002"? [1]
>
> I'm not sure I understand this question. On my device the backlight has ACPI id "GGL0002", not "GOOG0002"?
>
> >Have you tried to update your AP firmware?
>
> I have not explicitly updated any firmware. It has whatever firmware Chromeos has installed.
IIUC, if your AP firmware includes patch [1] (submitted in 2015), it should
report "GOOG0002" instead of "GGL0002".
[1]: https://review.coreboot.org/c/coreboot/+/11478
next prev parent reply other threads:[~2024-11-14 2:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 2:29 detect kbd backlight on Google Link (original Chromebook Pixel) Brandon Casey
2024-11-13 2:29 ` [PATCH] platform/chrome: cros_kbd_led_backlight: support Google Link Brandon Casey
2024-11-13 6:46 ` Tzung-Bi Shih
2024-11-13 8:44 ` Brandon Casey
2024-11-14 2:07 ` Tzung-Bi Shih [this message]
2024-11-14 4:38 ` Brandon Casey
2024-11-14 8:53 ` Tzung-Bi Shih
2024-11-18 18:58 ` Brandon Casey
2024-11-21 0:54 ` Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZzVbbh86elpYQG5s@google.com \
--to=tzungbi@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=drafnel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox