Chrome platform driver development
 help / color / mirror / Atom feed
From: Prashant Malani <pmalani@chromium.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-kernel@vger.kernel.org, patches@lists.linux.dev,
	chrome-platform@lists.linux.dev,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, Benson Leung <bleung@chromium.org>,
	Guenter Roeck <groeck@chromium.org>,
	Douglas Anderson <dianders@chromium.org>,
	Hsin-Yi Wang <hsinyi@chromium.org>,
	"Joseph S. Barrera III" <joebar@chromium.org>
Subject: Re: [PATCH v4 0/2] Input: cros-ec-keyb: Better matrixless support
Date: Tue, 10 May 2022 23:04:09 +0000	[thread overview]
Message-ID: <Ynrvadrl/P/6CrMQ@chromium.org> (raw)
In-Reply-To: <20220503204212.3907925-1-swboyd@chromium.org>

Hi Dmitry,

On May 03 13:42, Stephen Boyd wrote:
> This is a followup to my previous patch[1] that skips keyboard registration
> when the matrix properties aren't present. This adds a compatible string
> for this scenario so we can ease existing DTBs over to the new design.
> 
> Changes from v3 (https://lore.kernel.org/r/20220503042242.3597561-1-swboyd@chromium.org):
>  * s/register_keyboard/has_keyboard/
>  * Pick up review tags
>  * Indicate properties are required in example #2 in yaml file
> 
> Changes from v2 (https://lore.kernel.org/r/20220429233112.2851665-1-swboyd@chromium.org):
>  * Drop rows/cols check now that compatible schema handles it
>  * Make binding require rows,cols,keymap for cros-ec-keyb compatible
> 
> Changes from v1 (https://lore.kernel.org/r/20220427203026.828183-1-swboyd@chromium.org):
>  * Better enforcement of properties in DT binding
>  * Skip registration by means of adding compatible to device id list
> 
> Stephen Boyd (2):
>   dt-bindings: google,cros-ec-keyb: Introduce switches only compatible
>   Input: cros-ec-keyb - skip keyboard registration w/o cros-ec-keyb
>     compatible

Do these need input maintainers Acked-by? Also, should these go through
the chrome-platform branch?

Thanks,

-Prashant 
> 
>  .../bindings/input/google,cros-ec-keyb.yaml   | 87 +++++++++++++++++--
>  drivers/input/keyboard/cros_ec_keyb.c         | 19 ++--
>  2 files changed, 91 insertions(+), 15 deletions(-)
> 
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: <devicetree@vger.kernel.org>
> Cc: Benson Leung <bleung@chromium.org>
> Cc: Guenter Roeck <groeck@chromium.org>
> Cc: Douglas Anderson <dianders@chromium.org>
> Cc: Hsin-Yi Wang <hsinyi@chromium.org>
> Cc: "Joseph S. Barrera III" <joebar@chromium.org>
> 
> [1] https://lore.kernel.org/all/20220425210726.3813477-1-swboyd@chromium.org/
> 
> base-commit: 4352e23a7ff2f8a4ff229dd1283ed2f2b708ec51
> -- 
> https://chromeos.dev
> 
> 

      parent reply	other threads:[~2022-05-10 23:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-03 20:42 [PATCH v4 0/2] Input: cros-ec-keyb: Better matrixless support Stephen Boyd
2022-05-03 20:42 ` [PATCH v4 1/2] dt-bindings: google,cros-ec-keyb: Introduce switches only compatible Stephen Boyd
2022-05-03 20:42 ` [PATCH v4 2/2] Input: cros-ec-keyb - skip keyboard registration w/o cros-ec-keyb compatible Stephen Boyd
2022-05-10 23:04 ` Prashant Malani [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ynrvadrl/P/6CrMQ@chromium.org \
    --to=pmalani@chromium.org \
    --cc=bleung@chromium.org \
    --cc=chrome-platform@lists.linux.dev \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=groeck@chromium.org \
    --cc=hsinyi@chromium.org \
    --cc=joebar@chromium.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@lists.linux.dev \
    --cc=robh+dt@kernel.org \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox