[PATCH] platform/chrome: cros_ec_lpc: Handle EC without CRS section

[PATCH] platform/chrome: cros_ec_lpc: Handle EC without CRS section

[Gwendal Grignou]

Fix logic to support GOOG0004 device without CRS section.
Instead of failing, assume there are not memory mapped EC registers.

Fixes: be4fccb5e1fb ("platform/chrome: cros_ec_lpc: Support direct EC register memory access")

Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
---
 drivers/platform/chrome/cros_ec_lpc.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/platform/chrome/cros_ec_lpc.c b/drivers/platform/chrome/cros_ec_lpc.c
index 288ef9198bb0a..a878758b9211c 100644
--- a/drivers/platform/chrome/cros_ec_lpc.c
+++ b/drivers/platform/chrome/cros_ec_lpc.c
@@ -562,11 +562,7 @@ static int cros_ec_lpc_probe(struct platform_device *pdev)
 		 */
 		status = acpi_walk_resources(adev->handle, METHOD_NAME__CRS,
 					     cros_ec_lpc_resources, ec_lpc);
-		if (ACPI_FAILURE(status)) {
-			dev_err(dev, "failed to get resources\n");
-			return -ENODEV;
-		}
-		if (ec_lpc->mem32.address_length) {
+		if (ACPI_SUCCESS(status) && ec_lpc->mem32.address_length) {
 			ec_lpc->base = devm_ioremap(dev,
 						    ec_lpc->mem32.address,
 						    ec_lpc->mem32.address_length);
-- 
2.48.0.rc2.279.g1de40edade-goog

Re: [PATCH] platform/chrome: cros_ec_lpc: Handle EC without CRS section

[Tzung-Bi Shih]

On Tue, Jan 14, 2025 at 12:21:22PM -0800, Gwendal Grignou wrote:
> Fix logic to support GOOG0004 device without CRS section.
> Instead of failing, assume there are not memory mapped EC registers.
>
> [...]

Applied to

    https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next

[1/1] platform/chrome: cros_ec_lpc: Handle EC without CRS section
      commit: fccebbdde2067e359f01382a72c31ed2af7acbac

Thanks!