From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Guenter Roeck <groeck@google.com>
Cc: bleung@chromium.org, groeck@chromium.org,
chrome-platform@lists.linux.dev, guillaume.tucker@collabora.com,
denys.f@collabora.com, ricardo.canuelo@collabora.com,
usama.anjum@collabora.com, briannorris@chromium.org
Subject: Re: [PATCH v2] platform/chrome: chromeos_acpi: print hex string for ACPI_TYPE_BUFFER
Date: Thu, 3 Aug 2023 09:20:22 +0800 [thread overview]
Message-ID: <ZMsA1kx8oYXzvYnC@google.com> (raw)
In-Reply-To: <CABXOdTdV-UnTCWnq_fD6bvJ3c0gX1jvx5ZbkV3qOHjtk5+HWOA@mail.gmail.com>
On Wed, Aug 02, 2023 at 09:04:10AM -0700, Guenter Roeck wrote:
> On Wed, Aug 2, 2023 at 2:58 AM Tzung-Bi Shih <tzungbi@kernel.org> wrote:
> > +truncating:
> > + dev_info(dev, "truncating sysfs content for %s\n", name);
>
> I really dislike that because it will, if it happens, clog the log
> (the condition will be permanent). How about using dev_info_once() ?
Fix in v3(https://patchwork.kernel.org/project/chrome-platform/patch/20230803011245.3773756-1-tzungbi@kernel.org/).
prev parent reply other threads:[~2023-08-03 1:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 9:57 [PATCH v2] platform/chrome: chromeos_acpi: print hex string for ACPI_TYPE_BUFFER Tzung-Bi Shih
2023-08-02 15:15 ` Muhammad Usama Anjum
2023-08-03 1:23 ` Tzung-Bi Shih
2023-08-03 4:17 ` Muhammad Usama Anjum
2023-08-07 3:37 ` Tzung-Bi Shih
2023-08-10 3:06 ` Tzung-Bi Shih
2023-08-02 16:04 ` Guenter Roeck
2023-08-03 1:20 ` Tzung-Bi Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMsA1kx8oYXzvYnC@google.com \
--to=tzungbi@kernel.org \
--cc=bleung@chromium.org \
--cc=briannorris@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=denys.f@collabora.com \
--cc=groeck@chromium.org \
--cc=groeck@google.com \
--cc=guillaume.tucker@collabora.com \
--cc=ricardo.canuelo@collabora.com \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox