From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc: bleung@chromium.org, groeck@chromium.org,
chrome-platform@lists.linux.dev, guillaume.tucker@collabora.com,
denys.f@collabora.com, ricardo.canuelo@collabora.com,
briannorris@chromium.org
Subject: Re: [PATCH v2] platform/chrome: chromeos_acpi: print hex string for ACPI_TYPE_BUFFER
Date: Mon, 7 Aug 2023 11:37:26 +0800 [thread overview]
Message-ID: <ZNBm9lXir2aI10lo@google.com> (raw)
In-Reply-To: <f4ae9de4-7b05-a797-087e-d895f7333167@collabora.com>
On Thu, Aug 03, 2023 at 09:17:23AM +0500, Muhammad Usama Anjum wrote:
> On 8/3/23 6:23 AM, Tzung-Bi Shih wrote:
> > On Wed, Aug 02, 2023 at 08:15:31PM +0500, Muhammad Usama Anjum wrote:
> >> On 8/2/23 2:57 PM, Tzung-Bi Shih wrote:
> >>> `element->buffer.pointer` should be binary blob. `%s` doesn't work
> >>> perfect for them.
> >>>
> >>> Print hex string for ACPI_TYPE_BUFFER.
> >>>
> >>> Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
> >> Please add fixes tag and CC stable as well (stable@vger.kernel.org) in next
> >> revision.
> >>
> >> Fixes: 0a4cad9c11ad ("platform/chrome: Add ChromeOS ACPI device driver")
> >
> > I think a Fixes tag should be sufficient.
> Why do you think so? As this is a bug fix which exists in the driver since
> it was written, if we add fixes tag and probably cc stable as well, the
> patch will be applied to all LTS kernels which we really want. In this way,
> the bug would be fixed on all LTS kernels not just the latest kernel.
Without the patch, I observed some malfunctions of ChromiumOS userland program
`crossystem`. There is no kernel crashes and the system is bootable. Thus, I
think a Fixes tag should be sufficient.
next prev parent reply other threads:[~2023-08-07 3:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 9:57 [PATCH v2] platform/chrome: chromeos_acpi: print hex string for ACPI_TYPE_BUFFER Tzung-Bi Shih
2023-08-02 15:15 ` Muhammad Usama Anjum
2023-08-03 1:23 ` Tzung-Bi Shih
2023-08-03 4:17 ` Muhammad Usama Anjum
2023-08-07 3:37 ` Tzung-Bi Shih [this message]
2023-08-10 3:06 ` Tzung-Bi Shih
2023-08-02 16:04 ` Guenter Roeck
2023-08-03 1:20 ` Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNBm9lXir2aI10lo@google.com \
--to=tzungbi@kernel.org \
--cc=bleung@chromium.org \
--cc=briannorris@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=denys.f@collabora.com \
--cc=groeck@chromium.org \
--cc=guillaume.tucker@collabora.com \
--cc=ricardo.canuelo@collabora.com \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox