From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Rob Barnes <robbarnes@google.com>
Cc: chrome-platform@lists.linux.dev, gwendal@chromium.org,
groweck@chromium.org
Subject: Re: [PATCH] drivers/cros_ec: Reduce log polling period to 2s
Date: Sat, 23 Sep 2023 08:41:56 +0000 [thread overview]
Message-ID: <ZQ6k1K//086Ptqg0@google.com> (raw)
In-Reply-To: <20230921141935.3973069-1-robbarnes@google.com>
On Thu, Sep 21, 2023 at 02:19:35PM +0000, Rob Barnes wrote:
> 2. Yields more recent logs prior to a crash, facilitating easier debugging.
The approach depends on multiple parties before a system reboot: EC reports
on panic, AP sends EC commands for reading the logs, userland programs
(e.g. timberslide) write the logs to filesystem, and filesystem
synchronization. If anyone in the path didn't work in time, the logs
disappear.
An random idea: could we save the EC console logs to pstore when AP gets
notification on EC panic?
> ---
> drivers/platform/chrome/cros_ec_debugfs.c | 2 +-
If you have chance to send next version, please refer `git log` on the file
to see a good candidate of title prefixes.
next prev parent reply other threads:[~2023-09-23 8:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 14:19 [PATCH] drivers/cros_ec: Reduce log polling period to 2s Rob Barnes
2023-09-23 8:41 ` Tzung-Bi Shih [this message]
2023-09-26 18:57 ` Rob Barnes
2023-09-28 7:07 ` Tzung-Bi Shih
2024-05-02 17:13 ` Rob Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQ6k1K//086Ptqg0@google.com \
--to=tzungbi@kernel.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groweck@chromium.org \
--cc=gwendal@chromium.org \
--cc=robbarnes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox