From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Rob Barnes <robbarnes@google.com>
Cc: chrome-platform@lists.linux.dev, gwendal@chromium.org,
groeck@chromium.org
Subject: Re: [PATCH] drivers/cros_ec: Reduce log polling period to 2s
Date: Thu, 28 Sep 2023 15:07:25 +0800 [thread overview]
Message-ID: <ZRUmLWf6COwE8gtv@google.com> (raw)
In-Reply-To: <CA+Dqm30KGiSVnJ+z=ToT_i3xS6dN5+opCHbp-9tfd+ZqxdgJQA@mail.gmail.com>
On Tue, Sep 26, 2023 at 12:57:22PM -0600, Rob Barnes wrote:
> On Sat, Sep 23, 2023 at 2:42 AM Tzung-Bi Shih <tzungbi@kernel.org> wrote:
> >
> > On Thu, Sep 21, 2023 at 02:19:35PM +0000, Rob Barnes wrote:
> > > 2. Yields more recent logs prior to a crash, facilitating easier debugging.
> >
> > The approach depends on multiple parties before a system reboot: EC reports
> > on panic, AP sends EC commands for reading the logs, userland programs
> > (e.g. timberslide) write the logs to filesystem, and filesystem
> > synchronization. If anyone in the path didn't work in time, the logs
> > disappear.
>
> This change is just affecting the continuous polling period of the
> cros_ec driver.
> Syncing the log immediately after a panic is a separate path and will only work
> when EC supports system safe mode recovery, most don't.
I guess I misunderstood. Is the understanding "EC can't respond to further
host commands from AP after EC crashed unless some more special supports
(e.g. system safe mode)" correct?
If yes, how about after EC reported a panic but before EC crashed? Can EC
respond to host commands during the period?
> The hope with shortening the period is that cros_ec.previous will contain more
> relevant logs after a crash, even when safe mode isn't enabled.
What is current approach for getting EC crash dumps/logs from AP? If the
system didn't save them before system reset, are they available after next
boot?
next prev parent reply other threads:[~2023-09-28 7:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 14:19 [PATCH] drivers/cros_ec: Reduce log polling period to 2s Rob Barnes
2023-09-23 8:41 ` Tzung-Bi Shih
2023-09-26 18:57 ` Rob Barnes
2023-09-28 7:07 ` Tzung-Bi Shih [this message]
2024-05-02 17:13 ` Rob Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRUmLWf6COwE8gtv@google.com \
--to=tzungbi@kernel.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=robbarnes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox