From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Utkarsh Patel <utkarsh.h.patel@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
heikki.krogerus@linux.intel.com, pmalani@chromium.org,
chrome-platform@lists.linux.dev, bleung@chromium.org
Subject: Re: [PATCH v4 4/5] platform/chrome: cros_ec_typec: Add Displayport Alternatemode 2.1 Support
Date: Wed, 20 Sep 2023 17:42:46 +0300 [thread overview]
Message-ID: <ZQsE5hgm4qYpr/My@smile.fi.intel.com> (raw)
In-Reply-To: <20230920023243.2494410-5-utkarsh.h.patel@intel.com>
On Tue, Sep 19, 2023 at 07:32:42PM -0700, Utkarsh Patel wrote:
> Displayport Alternatemode 2.1 requires cable capabilities such as cable
> signalling, cable type, DPAM version which then will be used by mux
> driver for displayport configuration. These capabilities can be derived
> from the Cable VDO.
...
> + /**
Are you sure?
> + * Get cable VDO for thunderbolt cables and cables with DPSID but does not
> + * support DPAM2.1.
> + */
...
> + if (cable_dp_vdo & DP_CAP_DPAM_VERSION) {
> + dp_data.conf |= cable_dp_vdo;
> + } else if (cable_tbt_vdo) {
> + dp_data.conf |= TBT_CABLE_SPEED(cable_tbt_vdo) << DP_CONF_SIGNALLING_SHIFT;
> +
> + /* Cable Type */
> + if (cable_tbt_vdo & TBT_CABLE_OPTICAL)
> + dp_data.conf |= DP_CONF_CABLE_TYPE_OPTICAL << DP_CONF_CABLE_TYPE_SHIFT;
> + else if (cable_tbt_vdo & TBT_CABLE_RETIMER)
> + dp_data.conf |= DP_CONF_CABLE_TYPE_RE_TIMER << DP_CONF_CABLE_TYPE_SHIFT;
> + else if (cable_tbt_vdo & TBT_CABLE_ACTIVE_PASSIVE)
> + dp_data.conf |= DP_CONF_CABLE_TYPE_RE_DRIVER << DP_CONF_CABLE_TYPE_SHIFT;
> + } else if (PD_IDH_PTYPE(port->c_identity.id_header) == IDH_PTYPE_PCABLE) {
> + dp_data.conf |= VDO_TYPEC_CABLE_SPEED(port->c_identity.vdo[0]) <<
> + DP_CONF_SIGNALLING_SHIFT;
> + }
You can also make it a bit more readable with (use better names
if you think it's needed)
u32 signalling = 0;
u32 cable_type = 0;
...
if (cable_dp_vdo & DP_CAP_DPAM_VERSION) {
dp_data.conf |= cable_dp_vdo;
} else if (cable_tbt_vdo) {
signalling = TBT_CABLE_SPEED(cable_tbt_vdo);
/* Cable Type */
if (cable_tbt_vdo & TBT_CABLE_OPTICAL)
cable_type = DP_CONF_CABLE_TYPE_OPTICAL;
else if (cable_tbt_vdo & TBT_CABLE_RETIMER)
cable_type = DP_CONF_CABLE_TYPE_RE_TIMER;
else if (cable_tbt_vdo & TBT_CABLE_ACTIVE_PASSIVE)
cable_type = DP_CONF_CABLE_TYPE_RE_DRIVER;
} else if (PD_IDH_PTYPE(port->c_identity.id_header) == IDH_PTYPE_PCABLE) {
signalling = VDO_TYPEC_CABLE_SPEED(port->c_identity.vdo[0]);
}
dp_data.conf |= signalling << DP_CONF_SIGNALLING_SHIFT;
dp_data.conf |= cable_type << DP_CONF_CABLE_TYPE_SHIFT;
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-09-20 14:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 2:32 [PATCH v4 0/5] Displayport Alternate Mode 2.1 Support Utkarsh Patel
2023-09-20 2:32 ` [PATCH v4 1/5] usb: typec: Add " Utkarsh Patel
2023-09-20 2:32 ` [PATCH v4 2/5] usb: typec: Add Active or Passive cable defination to cable discover mode VDO Utkarsh Patel
2023-09-20 2:32 ` [PATCH v4 3/5] usb: pd: Add helper macro to get Type C cable speed Utkarsh Patel
2023-09-20 2:32 ` [PATCH v4 4/5] platform/chrome: cros_ec_typec: Add Displayport Alternatemode 2.1 Support Utkarsh Patel
2023-09-20 14:42 ` Andy Shevchenko [this message]
2023-09-25 15:54 ` Patel, Utkarsh H
2023-09-25 19:27 ` Andy Shevchenko
2023-09-28 1:31 ` Patel, Utkarsh H
2023-09-20 2:32 ` [PATCH v4 5/5] usb: typec: intel_pmc_mux: Configure Displayport Alternate mode 2.1 Utkarsh Patel
2023-09-20 9:10 ` Sergei Shtylyov
2023-09-26 2:00 ` Patel, Utkarsh H
2023-11-13 3:23 ` [PATCH v4 0/5] Displayport Alternate Mode 2.1 Support patchwork-bot+chrome-platform
2023-11-13 3:42 ` patchwork-bot+chrome-platform
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQsE5hgm4qYpr/My@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pmalani@chromium.org \
--cc=utkarsh.h.patel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox