From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Patel, Utkarsh H" <utkarsh.h.patel@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"heikki.krogerus@linux.intel.com"
<heikki.krogerus@linux.intel.com>,
"pmalani@chromium.org" <pmalani@chromium.org>,
"chrome-platform@lists.linux.dev"
<chrome-platform@lists.linux.dev>,
"bleung@chromium.org" <bleung@chromium.org>
Subject: Re: [PATCH v4 4/5] platform/chrome: cros_ec_typec: Add Displayport Alternatemode 2.1 Support
Date: Mon, 25 Sep 2023 22:27:50 +0300 [thread overview]
Message-ID: <ZRHfNoiDazz1ZDtD@smile.fi.intel.com> (raw)
In-Reply-To: <CY4PR11MB0037E70612B8067062AC1C40A9FCA@CY4PR11MB0037.namprd11.prod.outlook.com>
On Mon, Sep 25, 2023 at 03:54:40PM +0000, Patel, Utkarsh H wrote:
...
> > > + /**
> >
> > Are you sure?
> >
> > > + * Get cable VDO for thunderbolt cables and cables with DPSID but
> > does not
> > > + * support DPAM2.1.
> > > + */
> >
> Yes, there are TBT3 cables which advertise DPSID but does not provide any DP
> capabilities in the DP discover mode VDO but does support UHBR. In that
> case, need to use TBTSID and use capabilities from TBT discover mode VDO.
My comment was against the style of the comment, not about content.
...
> > You can also make it a bit more readable with (use better names if you think it's
> > needed)
> >
> > u32 signalling = 0;
> > u32 cable_type = 0;
>
> In v2 version of this patch I had them but there was feedback to remove extra
> variables and use them inline.
OK!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-09-25 19:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 2:32 [PATCH v4 0/5] Displayport Alternate Mode 2.1 Support Utkarsh Patel
2023-09-20 2:32 ` [PATCH v4 1/5] usb: typec: Add " Utkarsh Patel
2023-09-20 2:32 ` [PATCH v4 2/5] usb: typec: Add Active or Passive cable defination to cable discover mode VDO Utkarsh Patel
2023-09-20 2:32 ` [PATCH v4 3/5] usb: pd: Add helper macro to get Type C cable speed Utkarsh Patel
2023-09-20 2:32 ` [PATCH v4 4/5] platform/chrome: cros_ec_typec: Add Displayport Alternatemode 2.1 Support Utkarsh Patel
2023-09-20 14:42 ` Andy Shevchenko
2023-09-25 15:54 ` Patel, Utkarsh H
2023-09-25 19:27 ` Andy Shevchenko [this message]
2023-09-28 1:31 ` Patel, Utkarsh H
2023-09-20 2:32 ` [PATCH v4 5/5] usb: typec: intel_pmc_mux: Configure Displayport Alternate mode 2.1 Utkarsh Patel
2023-09-20 9:10 ` Sergei Shtylyov
2023-09-26 2:00 ` Patel, Utkarsh H
2023-11-13 3:23 ` [PATCH v4 0/5] Displayport Alternate Mode 2.1 Support patchwork-bot+chrome-platform
2023-11-13 3:42 ` patchwork-bot+chrome-platform
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRHfNoiDazz1ZDtD@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pmalani@chromium.org \
--cc=utkarsh.h.patel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox