Chrome platform driver development
 help / color / mirror / Atom feed
* [PATCH] pwm: cros-ec: Drop unused member from driver private data
@ 2023-11-16 10:52 Uwe Kleine-König
  2023-11-20  8:54 ` Tzung-Bi Shih
  2023-11-28 16:59 ` Thierry Reding
  0 siblings, 2 replies; 3+ messages in thread
From: Uwe Kleine-König @ 2023-11-16 10:52 UTC (permalink / raw)
  To: Thierry Reding
  Cc: Benson Leung, Guenter Roeck, linux-pwm, chrome-platform, kernel

.dev is unused since the driver was introduced in commit 1f0d3bb02785
("pwm: Add ChromeOS EC PWM driver"). Drop it.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/pwm/pwm-cros-ec.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pwm/pwm-cros-ec.c b/drivers/pwm/pwm-cros-ec.c
index 4fbd23e4ef69..9a8f1b6a4e13 100644
--- a/drivers/pwm/pwm-cros-ec.c
+++ b/drivers/pwm/pwm-cros-ec.c
@@ -25,7 +25,6 @@
  * @channel: array with per-channel data
  */
 struct cros_ec_pwm_device {
-	struct device *dev;
 	struct cros_ec_device *ec;
 	struct pwm_chip chip;
 	bool use_pwm_type;

base-commit: d27abbfd4888d79dd24baf50e774631046ac4732
-- 
2.42.0.586.gbc5204569f7d.dirty


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] pwm: cros-ec: Drop unused member from driver private data
  2023-11-16 10:52 [PATCH] pwm: cros-ec: Drop unused member from driver private data Uwe Kleine-König
@ 2023-11-20  8:54 ` Tzung-Bi Shih
  2023-11-28 16:59 ` Thierry Reding
  1 sibling, 0 replies; 3+ messages in thread
From: Tzung-Bi Shih @ 2023-11-20  8:54 UTC (permalink / raw)
  To: Uwe Kleine-König
  Cc: Thierry Reding, Benson Leung, Guenter Roeck, linux-pwm,
	chrome-platform, kernel

On Thu, Nov 16, 2023 at 11:52:13AM +0100, Uwe Kleine-König wrote:
> .dev is unused since the driver was introduced in commit 1f0d3bb02785
> ("pwm: Add ChromeOS EC PWM driver"). Drop it.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] pwm: cros-ec: Drop unused member from driver private data
  2023-11-16 10:52 [PATCH] pwm: cros-ec: Drop unused member from driver private data Uwe Kleine-König
  2023-11-20  8:54 ` Tzung-Bi Shih
@ 2023-11-28 16:59 ` Thierry Reding
  1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2023-11-28 16:59 UTC (permalink / raw)
  To: Uwe Kleine-König
  Cc: Benson Leung, Guenter Roeck, linux-pwm, chrome-platform, kernel


On Thu, 16 Nov 2023 11:52:13 +0100, Uwe Kleine-König wrote:
> .dev is unused since the driver was introduced in commit 1f0d3bb02785
> ("pwm: Add ChromeOS EC PWM driver"). Drop it.
> 
> 

Applied, thanks!

[1/1] pwm: cros-ec: Drop unused member from driver private data
      commit: 53231af13df265cb46da99d5936ed270f22a35e1

Best regards,
-- 
Thierry Reding <thierry.reding@gmail.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-11-28 17:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-16 10:52 [PATCH] pwm: cros-ec: Drop unused member from driver private data Uwe Kleine-König
2023-11-20  8:54 ` Tzung-Bi Shih
2023-11-28 16:59 ` Thierry Reding

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox