From: Tzung-Bi Shih <tzungbi@kernel.org>
To: "Dustin L. Howett" <dustin@howett.net>
Cc: Guenter Roeck <groeck@chromium.org>, chrome-platform@lists.linux.dev
Subject: Re: [PATCH v2 3/4] platform/chrome: cros_ec_lpc: add a "quirks" system
Date: Mon, 27 Nov 2023 11:30:58 +0800 [thread overview]
Message-ID: <ZWQNcgf5dFkPikH2@google.com> (raw)
In-Reply-To: <20231126192452.97824-4-dustin@howett.net>
On Sun, Nov 26, 2023 at 01:24:51PM -0600, Dustin L. Howett wrote:
> @@ -363,8 +386,11 @@ static int cros_ec_lpc_probe(struct platform_device *pdev)
> acpi_status status;
> struct cros_ec_device *ec_dev;
> struct cros_ec_lpc *ec_lpc;
> + struct lpc_driver_data *driver_data;
> + int region1_size = EC_HOST_CMD_REGION_SIZE;
> u8 buf[2] = {};
> int irq, ret;
> + u32 quirks = 0;
>
> ec_lpc = devm_kzalloc(dev, sizeof(*ec_lpc), GFP_KERNEL);
> if (!ec_lpc)
> @@ -372,6 +398,20 @@ static int cros_ec_lpc_probe(struct platform_device *pdev)
>
> ec_lpc->mmio_memory_base = EC_LPC_ADDR_MEMMAP;
>
> + driver_data = platform_get_drvdata(pdev);
> + if (driver_data) {
> + quirks = driver_data->quirks;
> +
From readability's perspective:
If seeing a variable is initialized, the code reader would expect: "there must
be some reasons" (at least for me). For the case, I think the reason is
unobvious.
next prev parent reply other threads:[~2023-11-27 3:31 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-05 16:06 [PATCH v1 0/4] cros_ec: add support for newer versions of the Framework Laptop Dustin L. Howett
2023-10-05 16:06 ` [PATCH v1 1/4] cros_ec_lpc: introduce cros_ec_lpc, a priv struct for the lpc device Dustin L. Howett
2023-10-11 5:29 ` Tzung-Bi Shih
2023-10-05 16:07 ` [PATCH v1 2/4] cros_ec_lpc: pass driver_data from DMI down to the device Dustin L. Howett
2023-10-11 5:29 ` Tzung-Bi Shih
2023-10-05 16:07 ` [PATCH v1 3/4] cros_ec_lpc: add a quirks system, and propagate quirks from DMI Dustin L. Howett
2023-10-11 5:30 ` Tzung-Bi Shih
2023-11-16 23:17 ` Thomas Weißschuh
2023-10-05 16:07 ` [PATCH v1 4/4] cros_ec_lpc: add quirks for the Framework Laptop Dustin L. Howett
2023-10-05 18:45 ` Mario Limonciello
2023-10-11 5:30 ` Tzung-Bi Shih
2023-10-11 5:29 ` [PATCH v1 0/4] cros_ec: add support for newer versions of " Tzung-Bi Shih
2023-11-26 19:22 ` Dustin Howett
2023-11-27 3:30 ` Tzung-Bi Shih
2023-11-26 19:24 ` [PATCH v2 0/4] platform/chrome: cros_ec_lpc: add support for AMD Framework Laptops Dustin L. Howett
2023-11-26 19:24 ` [PATCH v2 1/4] platform/chrome: cros_ec_lpc: introduce a priv struct for the lpc device Dustin L. Howett
2023-11-26 19:24 ` [PATCH v2 2/4] platform/chrome: cros_ec_lpc: pass driver_data from DMI to the device Dustin L. Howett
2023-11-26 19:24 ` [PATCH v2 3/4] platform/chrome: cros_ec_lpc: add a "quirks" system Dustin L. Howett
2023-11-27 3:30 ` Tzung-Bi Shih [this message]
2023-11-26 19:24 ` [PATCH v2 4/4] platform/chrome: cros_ec_lpc: add quirks for the Framework Laptop (AMD) Dustin L. Howett
2023-12-23 11:33 ` [PATCH v2 0/4] platform/chrome: cros_ec_lpc: add support for AMD Framework Laptops Thomas Weißschuh
2024-04-03 0:47 ` [PATCH v3 " Dustin L. Howett
2024-04-03 0:47 ` [PATCH v3 1/4] platform/chrome: cros_ec_lpc: introduce a priv struct for the lpc device Dustin L. Howett
2024-04-03 0:47 ` [PATCH v3 2/4] platform/chrome: cros_ec_lpc: pass driver_data from DMI to the device Dustin L. Howett
2024-04-03 0:47 ` [PATCH v3 3/4] platform/chrome: cros_ec_lpc: add a "quirks" system Dustin L. Howett
2024-04-03 0:47 ` [PATCH v3 4/4] platform/chrome: cros_ec_lpc: add quirks for the Framework Laptop (AMD) Dustin L. Howett
2024-04-04 18:53 ` [PATCH v3 0/4] platform/chrome: cros_ec_lpc: add support for AMD Framework Laptops Thomas Weißschuh
2024-04-04 18:59 ` Dustin Howett
2024-04-04 19:57 ` Thomas Weißschuh
2024-04-05 1:02 ` Dustin Howett
2024-04-06 18:48 ` Mario Limonciello
2024-04-06 19:23 ` Mario Limonciello
2024-04-08 9:30 ` patchwork-bot+chrome-platform
2024-04-08 9:30 ` patchwork-bot+chrome-platform
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZWQNcgf5dFkPikH2@google.com \
--to=tzungbi@kernel.org \
--cc=chrome-platform@lists.linux.dev \
--cc=dustin@howett.net \
--cc=groeck@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox