[PATCH 0/2] platform/chrome: Prevent build for big-endian systems

[PATCH 0/2] platform/chrome: Prevent build for big-endian systems

[Thomas Weißschuh]

Both ARM and ARM64 which are a dependency for CHROME_PLATFORMS have
seldomly used big-endian variants.

The ChromeOS EC framework and drivers are written under the assumption
that they will be running on a little-endian systems. Code which would
be broken on big-endian can be found trivially.

Prevent the build for big-endian systems.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
Thomas Weißschuh (2):
      platform/chrome: Remove superfluous dependencies from CROS_EC
      platform/chrome: Prevent build for big-endian systems

 drivers/platform/chrome/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
base-commit: 4178de898c341e6c259851a2be1c7649ac4f40ad
change-id: 20260530-cros-big-endian-86f8df2db678

Best regards,
--  
Thomas Weißschuh <linux@weissschuh.net>

[PATCH 1/2] platform/chrome: Remove superfluous dependencies from CROS_EC

[Thomas Weißschuh]

CROS_EC depends on CHROME_PLATFORMS which already declares these
dependencies.

Remove the duplication.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
 drivers/platform/chrome/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/platform/chrome/Kconfig b/drivers/platform/chrome/Kconfig
index 2281d6dacc9b..78acc052377b 100644
--- a/drivers/platform/chrome/Kconfig
+++ b/drivers/platform/chrome/Kconfig
@@ -75,7 +75,6 @@ config CHROMEOS_OF_HW_PROBER
 config CROS_EC
 	tristate "ChromeOS Embedded Controller"
 	select CROS_EC_PROTO
-	depends on X86 || ARM || ARM64 || COMPILE_TEST
 	help
 	  If you say Y here you get support for the ChromeOS Embedded
 	  Controller (EC) providing keyboard, battery and power services.

-- 
2.54.0

[PATCH 2/2] platform/chrome: Prevent build for big-endian systems

[Thomas Weißschuh]

Both ARM and ARM64 which are a dependency for CHROME_PLATFORMS have
seldomly used big-endian variants.

The ChromeOS EC framework and drivers are written under the assumption
that they will be running on a little-endian systems. Code which would
be broken on big-endian can be found trivially.

Some examples:
cros_ec.c: suspend_params.sleep_timeout_ms = ec_dev->suspend_timeout_ms
cros_ec_debugfs.c: resp->time_since_ec_boot_ms
cros_ec_wdt.c: arg.req.reboot_timeout_sec = wdd->timeout

Prevent the build for big-endian systems.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
 drivers/platform/chrome/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/chrome/Kconfig b/drivers/platform/chrome/Kconfig
index 78acc052377b..ca2e8442026e 100644
--- a/drivers/platform/chrome/Kconfig
+++ b/drivers/platform/chrome/Kconfig
@@ -6,6 +6,7 @@
 menuconfig CHROME_PLATFORMS
 	bool "Platform support for Chrome hardware"
 	depends on X86 || ARM || ARM64 || COMPILE_TEST
+	depends on !CPU_BIG_ENDIAN || COMPILE_TEST
 	help
 	  Say Y here to get to see options for platform support for
 	  various Chromebooks and Chromeboxes. This option alone does

-- 
2.54.0

Re: [PATCH 0/2] platform/chrome: Prevent build for big-endian systems

[Tzung-Bi Shih]

On Sun, May 31, 2026 at 03:20:14PM +0200, Thomas Weißschuh wrote:
> Both ARM and ARM64 which are a dependency for CHROME_PLATFORMS have
> seldomly used big-endian variants.
> 
> The ChromeOS EC framework and drivers are written under the assumption
> that they will be running on a little-endian systems. Code which would
> be broken on big-endian can be found trivially.
> 
> [...]

Applied to

    https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next

[1/2] platform/chrome: Remove superfluous dependencies from CROS_EC
      commit: 6b81cbaf36f4a4735c1bf2bb609c8e53e2d5706a
[2/2] platform/chrome: Prevent build for big-endian systems
      commit: 883f968dcbb08a155101e3a943557530d4ac0463

Thanks!